Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Date:   Mon, 17 Jul 2023 12:47:00 +0200
From:   Harald Freudenberger <freude@linux.ibm.com>
To:     Wang Ming <machel@vivo.com>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        linux-crypto@vger.kernel.org, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, opensource.kernel@vivo.com
Subject: Re: [PATCH v1] arch: s390: Use kfree_sensitive instead of kfree
Reply-To: freude@linux.ibm.com
Mail-Reply-To: freude@linux.ibm.com
In-Reply-To: <20230717094533.18418-1-machel@vivo.com>
References: <20230717094533.18418-1-machel@vivo.com>
Message-ID: <4206a7e79f32538e2505722ef4b57386@linux.ibm.com>
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023-07-17 11:45, Wang Ming wrote:
> key might contain private part of the key, so better use
> kfree_sensitive to free it.
> 
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
>  arch/s390/crypto/paes_s390.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/s390/crypto/paes_s390.c 
> b/arch/s390/crypto/paes_s390.c
> index d29a9d908797..38349150c96e 100644
> --- a/arch/s390/crypto/paes_s390.c
> +++ b/arch/s390/crypto/paes_s390.c
> @@ -103,7 +103,7 @@ static inline void _free_kb_keybuf(struct key_blob 
> *kb)
>  {
>  	if (kb->key && kb->key != kb->keybuf
>  	    && kb->keylen > sizeof(kb->keybuf)) {
> -		kfree(kb->key);
> +		kfree_sensitive(kb->key);
>  		kb->key = NULL;
>  	}
>  }

Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>