Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c879ceb-9133-5794-5248-f44160fec62a@nvidia.com>
Date:   Mon, 17 Jul 2023 13:41:51 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/1] net: gro: fix misuse of CB in udp socket lookup
Content-Language: en-US
To:     Richard Gobert <richardbgobert@gmail.com>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        willemdebruijn.kernel@gmail.com, dsahern@kernel.org,
        tom@herbertland.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20230707121650.GA17677@debian> <20230707122627.GA17845@debian>
From:   Gal Pressman <gal@nvidia.com>
In-Reply-To: <20230707122627.GA17845@debian>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c2l6b0gxbnU0WGw1azlDaTlpbWdhbnVmcUgzbXgveXFrTFpBZktWYmVnazNH?=
 =?utf-8?B?dTVYcWRJSGJEZU9wb2poL1BUSnNwZVkxdkl0ZWI5aFpqZS9naFp1UXpEellY?=
 =?utf-8?B?MTFIT2E4NmdOQy9ES1JGWlZsZTZVaG9rZ0NwQk5jOFo3TU1MbVlnWmtmTkRm?=
 =?utf-8?B?UFFLNDdGQVhDRy9hUlJXSVI5eEtFWnJVSFlOekYxd3ZFZ1FPR0JGQ3VKQWs1?=
 =?utf-8?B?aGU2cy9Fbm1CaFFEczVYS3p1R1BHM2dxY2M0RU5tYVB2dzRnWUlwTkFGeTdP?=
 =?utf-8?B?SllTeFFBVFkrMklSOGNBeG85a0szYVhIcjVERm8ra1B5QUFaa1Vvck1EbWdP?=
 =?utf-8?B?UDQyRDBsV09LNThseGxZeENYbkxCWTVMZjJRYldOL1I3TlZNYitveUtKNkly?=
 =?utf-8?B?UWlqQWlYVm54NFRVeHVMRTdqMVFFSmttZDJhT3VsRmRiTmErZXdwOTNuWHV6?=
 =?utf-8?B?WGpINFlIWUNIQXM3YjNqZWFJcmxRTHZRajdPdStMVndrNjZtMmxiRXJ5K2dp?=
 =?utf-8?B?ZlFySHphY3E4TVhhVTlOSXU5dlJXVUlibU1JZWtkV3RaZGwvTEt0TEUrU1lG?=
 =?utf-8?B?MlRSblJ5RkxoZlNuQ0F1eTdDVkV4dlhuZHNNU0JoWlV4QlF3Y2pmczhmekVS?=
 =?utf-8?B?TFAvZ2U5QjdWS2hKSjQxOXR6Z1RnZFJEUHRNQWk0MDhza0w2Znp6N1NNbWFs?=
 =?utf-8?B?eHdRWGxDb1VzTHA0STNMZDgwRmZOYkJiY3FCME15K0J6UWUvNlk4THNKUm9C?=
 =?utf-8?B?d0FBRGhxZUtJQ1pLMWR2K3JqMTcvRkxWcldvV3VCYkFQZW9OczJKNkdHc3Rx?=
 =?utf-8?B?WFA5dGRRUWc0MEpOYkJpV1pIcDFMVXBhZER1NDVZOFp3RnZWL1Y0S2JrUHN2?=
 =?utf-8?B?WG9ITWxNbVRBVTNMQ2VmTkZNdFNOY0FGRXY0S1J5VThWRW5ONzhkNjV5MnRW?=
 =?utf-8?B?YzF6WXNxZGp4K2hkc3J3QkluM2t2TE9QcWViaVFLdnpueHBiL0xkZVljQ2lv?=
 =?utf-8?B?Q21DTGpaVE1qU2JzT1NiOTl4bkhrT2lVMjVKVit4WWdVdVpaRzJPb2hsOWIz?=
 =?utf-8?B?MHN5R3EzdVRuZnBtMVU1NmtWa2pOVFk1Vnd6S2hqL2l1SXdiWDE4RUUya3JQ?=
 =?utf-8?B?bWIrc0lMZkExOGsxVTNvM05IcW8yaVJiVkFQblJhZWZyZGlEYjhVVnJleVZM?=
 =?utf-8?B?bWhmcDk3bkdmVERaRmt4ZTlJYkVEd2IydTVsdkE0VU1jTzJvODM1RTAwSVZI?=
 =?utf-8?B?TmZhUWhOMjZ0emN4S21yUWpUWWVNMW95Zkh3MWVQWVE4L3JZaFNtZHNTQldo?=
 =?utf-8?B?TFdJQTVxTUhhUDZoSDhYd01BaUFqY1NxcTBKY3MzMXRWTmlFVEVPeGF5bFpK?=
 =?utf-8?B?SVZyU0ZZbEJ6cU4zOG0yMWd4TWgwL3ljSFhCdjJtSG1Yb3kvejgvQm1ZbDRi?=
 =?utf-8?B?M29ETVJuNzVML0hRRHp5Q050S3FEYWRFdkNkZEdCbGJ3RHczc1NQaE56RVZv?=
 =?utf-8?B?cExkQTR1M1pKT0YyUDVBb2p4U2tUSlRvL2EwK21tUFpwYUNOSkh3cWh5ZUNL?=
 =?utf-8?B?YmtDRjFHYVY1S0RPbG1RUXpVQnRGQUZWYVdaTy9OTGlwK1dSU0N6NUdxZDcv?=
 =?utf-8?B?WWFNbkdWdldkVzg3N2JBU0FGVTlwMUdueXpWL2RtTnQ3VE41dGtmNUhLVmRG?=
 =?utf-8?B?aHpaYVFnYU1rWGhEZkE0RW9XbElKazQ3ZmFMUVFzcjVtQlhQWTh0eWR4c0R3?=
 =?utf-8?B?dFY1VHppRGhuOGwxVDNHWU1iK3lsOXI3NlZSbEdYalQ1Nnh5VWhMcHd1N3Mv?=
 =?utf-8?B?UDRLSGhCc2ttcnNpZlZvbzJ5ZVh5UmlwWUpGRzhXZTdNSm5RMitCZTcxNTZn?=
 =?utf-8?B?ZFo2ZTV2QXMwRWRYTTVCbGJ3UFdPc3IxMzQyNWlvUjZZdVQyWWNhdVFkLy9K?=
 =?utf-8?B?dGNFV0E5ekZydWtraEF2NG9sUHdFMVJLVGxtQjFpc3BkdWgwNkd6aDVTMzFK?=
 =?utf-8?B?eEZrQzltN0FyRHFpRzNuVGZkTlFqZTExQyt6QjVWeVdqb01qMXppTlNyTnZD?=
 =?utf-8?B?Vmg5ejJiNGpScU0rcXczYVFoL3AxdGhSWDYvaUhPTXdZaDA3WkZkSVZ1eEV3?=
 =?utf-8?Q?p9xrykmpXTJzyyLAiN4bIvPbj?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a9fa700-7605-4894-44c4-08db86b27253
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB6288.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 10:41:58.7416
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FdLRqw5pGWNmHXOGps115/CwbpIhnFKLg/MLjW0w/P/EqyERb8dfJFu14gQviaQ5
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6174
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/07/2023 15:26, Richard Gobert wrote:
> This patch fixes a misuse of IP{6}CB(skb) in GRO, while calling to
> `udp6_lib_lookup2` when handling udp tunnels. `udp6_lib_lookup2` fetch the
> device from CB. The fix changes it to fetch the device from `skb->dev`.
> l3mdev case requires special attention since it has a master and a slave
> device.
> 
> Fixes: a6024562ffd7 ("udp: Add GRO functions to UDP socket")
> Reported-by: Gal Pressman <gal@nvidia.com>
> Signed-off-by: Richard Gobert <richardbgobert@gmail.com>

Hi Richard,
Are you planning to submit a v2 for this patch?