Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5455689rwp; Mon, 17 Jul 2023 04:39:22 -0700 (PDT) X-Google-Smtp-Source: APBJJlEYlKWZ4s0iZOJXEMQ8jUMNdy9SelwbqykzD4l1qVK3UTkzRkP4zFst7xhPGHO5TIGbFnaJ X-Received: by 2002:a17:903:482:b0:1b8:a2af:fe23 with SMTP id jj2-20020a170903048200b001b8a2affe23mr8319809plb.2.1689593962105; Mon, 17 Jul 2023 04:39:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689593962; cv=none; d=google.com; s=arc-20160816; b=zNdzm0QpIpsECBEqJ+KJnJpDa683T2hK/1YUzTEiWhXIZeT58GLdel9MAZ/5u4daY2 D4uDbQhnPGdvCvRFkL12NqvPHvO0vMkmjO1KivgAXr3mPlftSUhHVrRgo64+30CFiW/c NtmXA0sxc5QAZRrVbxWQ30mmwjetNyMjI5pOHd6ZpCDhoNids/23mb50jPVPAGqiLUSY geQNpVuiC5lxuua+8VODQa2gQn9SDQZVcnQndVjBHU8LBijYXiV2GmIVOID7wB7ncRuR JjxgcglRt7AnuqIxIkLlvGw4LT/9ql2sbpnbVs0CgTxIATi3zw4jBfyBSGUEHlzQN6CL cnRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=5lZIHjb92Hzo3xoGL/o3cr99pjhKYTcIOhG3IAt7Af4=; fh=JypMSEOY5JGF3/aFXyQ5Az92j9BYa+5u/NdMWDJbLp0=; b=HwIvNK8XW8w83OMJQ3oGH+KeK3ne8mY3dPBkeIIfh7IxHItUbvzWJc8ch87PX/lu3u bsqh42jLbcfQDOFG8v7GSxyT0C7+luTgqGtNR6cN710Xwt/mN2GSMGipCkm5EoP0f/IW 6AWCHfcYDGGtk3BmjG7k5Vjb5A2cnT7lSeS0cdEl3rH//gXfj7JxjlRLTPqK+TMEQHwx o6EkVwE82SNvzkvKOe+dsJk2n0qf4O7Dkz91k+6vuQN3z10/rbRo4hXzXLVCVmzzaQt4 czqbleUU+MkfWu3rGCv8wXWiUiqQRj8O+ej1QNGb9Fhq3XnnTZOvOplQln3DwwlKSgYo ckIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t16-20020a170902e85000b001b7fdf423f3si11875240plg.566.2023.07.17.04.39.10; Mon, 17 Jul 2023 04:39:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230050AbjGQLKC (ORCPT + 99 others); Mon, 17 Jul 2023 07:10:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbjGQLKB (ORCPT ); Mon, 17 Jul 2023 07:10:01 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2A744E1 for ; Mon, 17 Jul 2023 04:09:56 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3AB881477 for ; Mon, 17 Jul 2023 04:10:39 -0700 (PDT) Received: from e110455-lin.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 718053F67D for ; Mon, 17 Jul 2023 04:09:55 -0700 (PDT) Date: Mon, 17 Jul 2023 12:07:47 +0100 From: Liviu Dudau To: Rob Herring Cc: David Airlie , Daniel Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Jagan Teki , Liu Ying , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Inki Dae , Marek Szyprowski , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Lucas Stach , Russell King , Christian Gmeiner , Seung-Woo Kim , Kyungmin Park , Krzysztof Kozlowski , Alim Akhtar , Xinliang Liu , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Laurentiu Palcu , Paul Cercueil , Qiang Yu , Paul Kocialkowski , Linus Walleij , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Abhinav Kumar , Dmitry B aryshkov , Sean Paul , Marijn Suijten , Marek Vasut , Stefan Agner , Sam Ravnborg , Jerry Han , Icenowy Zheng , Ondrej Jirman , Javier Martinez Canillas , Guido =?utf-8?Q?G=C3=BCnther?= , Purism Kernel Team , Jianhua Lu , Florian Fainelli , Broadcom internal kernel review list , Artur Weber , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Emma Anholt , Kieran Bingham , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Orson Zhai , Baolin Wang , Chunyan Zhang , Alain Volmat , Yannick Fertre , Raphael Gallais-Pou , Philippe Cornu , Maxime Coquelin , Alexandre Torgue , Chen-Yu Tsai , Samuel Holland , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Jyri Sarha , Tomi Valkeinen , Oleksandr Andrushchenko , devicetree@vger.kernel.org, Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, etnaviv@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-mips@vger.kernel.org, lima@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-rpi-kernel@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH] drm: Explicitly include correct DT includes Message-ID: References: <20230714174545.4056287-1-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230714174545.4056287-1-robh@kernel.org> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 14, 2023 at 11:45:34AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring > --- > > diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > index cc7664c95a54..14ee79becacb 100644 > --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c > @@ -6,7 +6,7 @@ > */ > #include > #include > -#include > +#include > #include > #include > #include > diff --git a/drivers/gpu/drm/arm/malidp_drv.c b/drivers/gpu/drm/arm/malidp_drv.c > index c03cfd57b752..a5a9534d4353 100644 > --- a/drivers/gpu/drm/arm/malidp_drv.c > +++ b/drivers/gpu/drm/arm/malidp_drv.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > For the komeda and malidp drivers: Acked-by: Liviu Dudau Best regards, Liviu > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c > index 99964f5a5457..2a6b91f752cb 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_cec.c > @@ -7,7 +7,6 @@ > > #include > #include > -#include > #include > #include > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > index 2254457ab5d0..b9957da0f55a 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -9,7 +9,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c > index f50d65f54314..7457d38622b0 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c > @@ -14,8 +14,7 @@ > #include > #include > #include > -#include > -#include > +#include > #include > #include > #include > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index f6822dfa3805..4aff817f82ce 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -29,7 +29,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/bridge/chipone-icn6211.c b/drivers/gpu/drm/bridge/chipone-icn6211.c > index 8bfce21d6b90..d205e755e524 100644 > --- a/drivers/gpu/drm/bridge/chipone-icn6211.c > +++ b/drivers/gpu/drm/bridge/chipone-icn6211.c > @@ -17,7 +17,7 @@ > #include > #include > #include > -#include > +#include > #include > #include > > diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c > index f7f436cf96e0..08bd5695ddae 100644 > --- a/drivers/gpu/drm/bridge/display-connector.c > +++ b/drivers/gpu/drm/bridge/display-connector.c > @@ -10,7 +10,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/gpu/drm/bridge/fsl-ldb.c b/drivers/gpu/drm/bridge/fsl-ldb.c > index b8e52156b07a..0e4bac7dd04f 100644 > --- a/drivers/gpu/drm/bridge/fsl-ldb.c > +++ b/drivers/gpu/drm/bridge/fsl-ldb.c > @@ -8,7 +8,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/bridge/imx/imx8qm-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qm-ldb.c > index 386032a02599..21471a9a28b2 100644 > --- a/drivers/gpu/drm/bridge/imx/imx8qm-ldb.c > +++ b/drivers/gpu/drm/bridge/imx/imx8qm-ldb.c > @@ -9,9 +9,9 @@ > #include > #include > #include > -#include > #include > #include > +#include > #include > #include > > diff --git a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > index c806576b1e22..7984da9c0a35 100644 > --- a/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > +++ b/drivers/gpu/drm/bridge/imx/imx8qxp-ldb.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > diff --git a/drivers/gpu/drm/bridge/lontium-lt9211.c b/drivers/gpu/drm/bridge/lontium-lt9211.c > index aa8d47e7f40d..4d404f5ef87e 100644 > --- a/drivers/gpu/drm/bridge/lontium-lt9211.c > +++ b/drivers/gpu/drm/bridge/lontium-lt9211.c > @@ -16,7 +16,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/bridge/lvds-codec.c b/drivers/gpu/drm/bridge/lvds-codec.c > index 67368f23d4aa..8c5668dca0c4 100644 > --- a/drivers/gpu/drm/bridge/lvds-codec.c > +++ b/drivers/gpu/drm/bridge/lvds-codec.c > @@ -7,7 +7,6 @@ > #include > #include > #include > -#include > #include > #include > #include > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c > index 4a5f5c4f5dcc..8d54091ec66e 100644 > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > @@ -16,8 +16,8 @@ > #include > #include > #include > -#include > #include > +#include > #include > #include > #include > diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c > index c9b6cb7678e3..ae3ab9262ef1 100644 > --- a/drivers/gpu/drm/bridge/parade-ps8622.c > +++ b/drivers/gpu/drm/bridge/parade-ps8622.c > @@ -12,7 +12,6 @@ > #include > #include > #include > -#include > #include > #include > > diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c > index 043b8109e64a..46b2c5027690 100644 > --- a/drivers/gpu/drm/bridge/samsung-dsim.c > +++ b/drivers/gpu/drm/bridge/samsung-dsim.c > @@ -16,8 +16,9 @@ > #include > #include > #include > -#include > +#include > #include > +#include > > #include