Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 10:12:50 -0400
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Yosry Ahmed <yosryahmed@google.com>,
        Christoph Hellwig <hch@infradead.org>,
        Nhat Pham <nphamcs@gmail.com>,
        Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
        konrad.wilk@oracle.com, vitaly.wool@konsulko.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: kill frontswap
Message-ID: <20230717141250.GA866068@cmpxchg.org>
References: <20230714194610.828210-1-hannes@cmpxchg.org>
 <ZLIVleBYOm4HIGTZ@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZLIVleBYOm4HIGTZ@casper.infradead.org>
Precedence: bulk

On Sat, Jul 15, 2023 at 04:42:13AM +0100, Matthew Wilcox wrote:
> On Fri, Jul 14, 2023 at 03:46:08PM -0400, Johannes Weiner wrote:
> > diff --git a/mm/zswap.c b/mm/zswap.c
> > index 62195f72bf56..1b0128060792 100644
> > --- a/mm/zswap.c
> > +++ b/mm/zswap.c
> > @@ -2,7 +2,7 @@
> >  /*
> >   * zswap.c - zswap driver file
> >   *
> > - * zswap is a backend for frontswap that takes pages that are in the process
> > + * zswap is a cache that takes pages that are in the process
> >   * of being swapped out and attempts to compress and store them in a
> >   * RAM-based memory pool.  This can result in a significant I/O reduction on
> >   * the swap device and, in the case where decompressing from RAM is faster
> > @@ -20,7 +20,6 @@
> >  #include <linux/spinlock.h>
> >  #include <linux/types.h>
> >  #include <linux/atomic.h>
> > -#include <linux/frontswap.h>
> >  #include <linux/rbtree.h>
> >  #include <linux/swap.h>
> >  #include <linux/crypto.h>
> 
> To make this patch compile, I had to add zswap.h to the include list.

I can fix that up, but I'm curious what kind of failure you saw. It
built fine for me, not even a warning.