Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5678051rwp; Mon, 17 Jul 2023 07:57:06 -0700 (PDT) X-Google-Smtp-Source: APBJJlHxZCrnNXEIjVyQpg7/4hE02JZjAsT89TP6jclgJTX2DMMzD2gcRX6KN9HMmM4CgvkbsiUa X-Received: by 2002:a05:6871:708:b0:1b3:d39a:968f with SMTP id f8-20020a056871070800b001b3d39a968fmr13144449oap.58.1689605826518; Mon, 17 Jul 2023 07:57:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689605826; cv=none; d=google.com; s=arc-20160816; b=cJjTdxgb9GSRj8khCtL+0Wkj1DBSIRdyuVtVhBNfg1a0KeHwuq6Sza6E1g0C6CJr/A RRrdB0sLxP7opD80LtwMOP76atwHQDcWC1kD4Ctg5xEXYR4wKOmI0taLkbGh+JWLMJtw Rvkjcfx62hDI9+YZZ0vPFTaoOWmokdlJxkTac3umsIun2r1v//iUjjBO+E7IZkZZhSQw x6QJHjV81VL5jhPXvZLO1dFPA2+gJ47hXqAM7oppcUzEg5M1oPak9O9M6R3zbyHhYHZX 6Qg4GjlhSkCIGeiOgEPdH6VPSXj2boDzv5Hgv4sP22fhltfw7Girf8+eyu13FS4VLn0O uWmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=hYdvvx3Wztv7mJtjl9ImGavA/ndheVeUx2jppMNxuoU=; fh=cGbWEtPpDdh29edBXga4LEYz4ZwZhuJgBk5/L6IxV5I=; b=Ju92aBpJ4Tu5ENbJNc6gdGo3phOfw/berVQchcWBK1/ANGZZjhh7rwnbJVKlX0YN/B J39CPVipPUGhfnZtBJQgIx3jJ7wcVigaw8m5Z2mAAdVMc2nOngUpPVnJ01KOR9sSUWif AGo5C29ob4QQZSpuxy3W48Z5fFTOh+ZCF8Fa1MKtUBNzIrmQu3EqG+y292KxIesO+MhV ShLj3remyP81rvBtaNyJRHhk9hdv2y9R+B4L7i3lQD6/wrd5pySbx1fOLhrhtyTnVPus A8qsOoOAdFFFQ1ohusfUvJ2PXTGtICzIzEDr3OQ1BLOkCoGDJRd1YNtOFSINsU/OOND+ cxQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d21-20020a656215000000b005538fc7243asi11319638pgv.507.2023.07.17.07.56.54; Mon, 17 Jul 2023 07:57:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231524AbjGQOS1 (ORCPT + 99 others); Mon, 17 Jul 2023 10:18:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbjGQOSU (ORCPT ); Mon, 17 Jul 2023 10:18:20 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8376E10DF; Mon, 17 Jul 2023 07:18:18 -0700 (PDT) X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="365983707" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="365983707" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 07:17:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="788667913" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="788667913" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 17 Jul 2023 07:17:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLP2a-000J8E-12; Mon, 17 Jul 2023 17:17:32 +0300 Date: Mon, 17 Jul 2023 17:17:32 +0300 From: Andy Shevchenko To: Andrei Coardos Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, florian.fainelli@broadcom.com, linus.walleij@linaro.org, sbranden@broadcom.com, brgl@bgdev.pl, Alexandru Ardelean Subject: Re: [PATCH] gpio: bcm-kona: remove unneeded platform_set_drvdata() call Message-ID: References: <20230717125521.6369-1-aboutphysycs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717125521.6369-1-aboutphysycs@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_SOFTFAIL,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 03:55:21PM +0300, Andrei Coardos wrote: > The platform_set_drvdata() call was never used, ever since the driver was > originally added. > It looks like this copy+paste left-over. Possibly the author copied from a > driver that had this line, but also had a remove hook. Cool, I'll incorporate this into my series. I'll make it as v2 to avoid clashes with this one. -- With Best Regards, Andy Shevchenko