Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230714175035.4065508-1-robh@kernel.org> <317a9fd8-0ae9-daa0-012b-3908ca248b74@suse.de>
In-Reply-To: <317a9fd8-0ae9-daa0-012b-3908ca248b74@suse.de>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 17 Jul 2023 09:22:10 -0600
Message-ID: <CAL_JsqJ2bkBU0WQG2jt755c_V4x4uR36Dvt2qEeXv52zCWeUmw@mail.gmail.com>
Subject: Re: [PATCH] fb: Explicitly include correct DT includes
To:     Thomas Zimmermann <tzimmermann@suse.de>
Cc:     Helge Deller <deller@gmx.de>, Michal Simek <michal.simek@amd.com>,
        devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sat, Jul 15, 2023 at 12:34=E2=80=AFPM Thomas Zimmermann <tzimmermann@sus=
e.de> wrote:
>
> Hi
>
> Am 14.07.23 um 19:50 schrieb Rob Herring:
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it as merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those includ=
e
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> [...]
> >
> > @@ -48,7 +48,7 @@ int sbusfb_mmap_helper(struct sbus_mmap_map *map,
> >       unsigned long map_offset =3D 0;
> >       unsigned long off;
> >       int i;
> > -
> > +
>
> The various whitespace fixes should rather go into a separate patch. You
> can add
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
> to the whitespace fix and the include cleanup.

Indeed. I missed dropping the whitespace change.

Rob