Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 17:24:15 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Akhil R <akhilrajeev@nvidia.com>
Cc:     christian.koenig@amd.com, digetx@gmail.com, jonathanh@nvidia.com,
        ldewangan@nvidia.com, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
        sumit.semwal@linaro.org, wsa@kernel.org
Subject: Re: [PATCH] i2c: tegra: Fix the check during DMA channel release
Message-ID: <ZLVdHzFm8yngLDj2@orome>
References: <20230717151240.68899-1-akhilrajeev@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="nLWHGpg7Oa2TX09f"
Content-Disposition: inline
In-Reply-To: <20230717151240.68899-1-akhilrajeev@nvidia.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--nLWHGpg7Oa2TX09f
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 17, 2023 at 08:42:40PM +0530, Akhil R wrote:
> Check for error and NULL before attempting to release DMA channel.
>=20
> This, otherwise, was causing panic and crash in kernel when the
> dma_chan has an invalid value. The condition occurs during init_dma()
> when the dma_request_chan() function returns an error.
>=20
> Fixes: fcc8a89a1c83 ("i2c: tegra: Share same DMA channel for RX and TX")
> Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

There's already another patch on the list that should address this:

	https://patchwork.ozlabs.org/project/linux-tegra/patch/20230707132619.2998=
382-1-thierry.reding@gmail.com/

Can you please test and provide feedback on that one?

Thanks,
Thierry

--nLWHGpg7Oa2TX09f
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS1XRwACgkQ3SOs138+
s6FbUg//eQas1PGvjAKhlbkAfch8OIRGKxFyIfolkP8ed7bK93zPFTsGFV/OhPGJ
y5pmAvL8I4Ey7gJxi7LAUbPo8rcGnhRjS8QvsDgN9c0SO9E1mKSM71rsVKXu0Ett
E+z+vIh8knWeC6JsBDqk3ymJBtMxg9fzjhhsXd+b0TqVHTIf7SevmZN90zsdNZ4W
/0Q8kkZ/Nl0GSt1uaecEaD28KIFk6eSo5mXmKsHJPlO9JUf+FZO48zS+YGZc9BBb
pFs3iZO1O3z7CzJ9o5yctqnpqiy/Ldx1nJe5RV59DYc118EGvhuDZjsBtkj8hHqM
wgd5pSOvydwOpGFYnChMJxkKQTynTbXm3LHDxE0HJ8P8++nEqaDu9rVTU6U0N1pv
tZ977b1vQInDih23GNDveiVHf9/ZLKD/PSezxi3bGRkmUMk6O/Q8DiAwMSd4ngfA
qJ1jXjo4o4NKFpmyKUYsLNNeFlwEkRDtQhglYTWnt3MdL9VZkcgFzqDxmj4s1UYN
SOqLCOQ68tw4+apgrcotgU9Sq4A8URap2LGsG+ro5L9l0n41K28Bf+7um1DIMl8p
svl9yPnF8dHUwDVxrfNhgx6TSFKGkDvkHgY7SISPTppWpxeBiF2cgi6arLnmQ1Bi
B27SUl2OXZVxA8ilhy3A7R+NTy99Mx2yn74eIyo2wdppWmbq5MI=
=Gm2m
-----END PGP SIGNATURE-----

--nLWHGpg7Oa2TX09f--