Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <125a610b-b205-52ba-1fe6-e7e0add0f8b9@linaro.org>
Date:   Mon, 17 Jul 2023 19:03:39 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 0/2] Add support for gigadevice and macronix SPI-NOR
To:     Sridharan S N <quic_sridsn@quicinc.com>, pratyush@kernel.org,
        michael@walle.cc, miquel.raynal@bootlin.com, richard@nod.at,
        vigneshr@ti.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
References: <20230717153536.25700-1-quic_sridsn@quicinc.com>
From:   Tudor Ambarus <tudor.ambarus@linaro.org>
Content-Language: en-US
In-Reply-To: <20230717153536.25700-1-quic_sridsn@quicinc.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17.07.2023 18:35, Sridharan S N wrote:
> This series add support for SPI NOR devices mentioned below:
> 
> gigadevice:
> gd25lb256e   - This supports quad read and uniform 4K-byte erase.
> gd25d{2,4}0c - These supports dual read and uniform 4K-byte erase.
> 
> macronix:
> mx66u1g45g - This chip supports stateless 4-byte opcodes, dual and quad
>              read and uniform 4K-byte erase.
> Sridharan S N (2):
>   mtd: spi-nor: gigadevice: Add support for gd25lb256e and gd25d{2,4}0c
>   mtd: spi-nor: macronix: Add support for mx66u1g45g
> 
>  drivers/mtd/spi-nor/gigadevice.c | 6 ++++++
>  drivers/mtd/spi-nor/macronix.c   | 3 +++
>  2 files changed, 9 insertions(+)
> 

All these flashes should support SFDP, thus you don't need to explicitly
define them. See
https://lore.kernel.org/linux-mtd/bfc85475bdcea46ea6c3ece98cc1e9cc@walle.cc/T/#mf79010e7031b03bda31690b4229a4f27f712f3a7