Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7046e828625a2acd97c48aec9f3b0ef0cc4930ed.camel@collabora.com>
Subject: Re: [PATCH] media: rkvdec: increase max supported height for H.264
From:   Nicolas Dufresne <nicolas.dufresne@collabora.com>
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        ezequiel@vanguardiasur.com.ar, mchehab@kernel.org,
        gregkh@linuxfoundation.org
Cc:     linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
        kernel@collabora.com
Date:   Mon, 17 Jul 2023 11:45:04 -0400
In-Reply-To: <20230717150611.42832-1-benjamin.gaignard@collabora.com>
References: <20230717150611.42832-1-benjamin.gaignard@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

Le lundi 17 juillet 2023 =C3=A0 17:06 +0200, Benjamin Gaignard a =C3=A9crit=
=C2=A0:
> After testing it is possible for the hardware to decode H264
> bistream with a height up to 2560.
>=20
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>

Thanks, this could possibly have a Fixes tag ?
Fixes: cd33c830448ba ("media: rkvdec: Add the rkvdec driver")

With or without the that though:
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/staging/media/rkvdec/rkvdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/staging/media/rkvdec/rkvdec.c b/drivers/staging/medi=
a/rkvdec/rkvdec.c
> index 134e2b9fa7d9..84a41792cb4b 100644
> --- a/drivers/staging/media/rkvdec/rkvdec.c
> +++ b/drivers/staging/media/rkvdec/rkvdec.c
> @@ -120,7 +120,7 @@ static const struct rkvdec_coded_fmt_desc rkvdec_code=
d_fmts[] =3D {
>  			.max_width =3D 4096,
>  			.step_width =3D 16,
>  			.min_height =3D 48,
> -			.max_height =3D 2304,
> +			.max_height =3D 2560,
>  			.step_height =3D 16,
>  		},
>  		.ctrls =3D &rkvdec_h264_ctrls,