Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5797615rwp; Mon, 17 Jul 2023 09:32:31 -0700 (PDT) X-Google-Smtp-Source: APBJJlH8hM1nHfrHIKfEzuI/aQfIpWN9j2I03l9YqmkdSjI1vQ5eeE6D3U10p6ci6VFik3uhkIIi X-Received: by 2002:aa7:d94e:0:b0:514:96f9:4f20 with SMTP id l14-20020aa7d94e000000b0051496f94f20mr201802eds.41.1689611550819; Mon, 17 Jul 2023 09:32:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689611550; cv=none; d=google.com; s=arc-20160816; b=Padj3GBmmS7GvRAJ73VzQILgJ5SStErqeFhx5r9bKSNiPEI462V5dcMXca/VASJ6p7 vf/lm6Ai3B9HKzG3dsi0jSE9mcBFUDlLQN6C6l1IIXmwNNeSrjsaCJ/1FC1L3T0O7Mt7 Y+ubZX13JRVGMB2XpFpXZc3xzkkhXmYuv1OfDwbi1hmtBkdE3gNmSgo9jLitI7bLXdlC Nm2QzH27ZL7tmcjEk/GqZe0kN/Jus4aYeOIXip9KohH7FEvzZgDiFR9T0lJPpmMPKJ6E 5kndoJ3MrtUbOOHA5bcrQPAewrqnMskrw4jjaZO3wFCdMIs7B/QYWQE1ucdlbquKKhSp f5+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EVLkRmgVDoNyOeJX5xEWdxWRdqJrLABMUE+a/PEo+CQ=; fh=h3KMI+TgbhpHnD/O+ZmPUnLmX222ZUuyhFWVQw8aw60=; b=Lns6Dw7HTptnAFhCbVBli/LBAnm6jlotZ6SUr0F5l6r1klDaxQDXEHzfJcuzQxB8X9 H9C5k3DOGIYsK8qxBElOuyLbOki76EqFUb+px8Z/GdbWHjYD8RuTBI+rrsvDylPs6uFE SCa0qQpNGUBwm306P3tF6Zvs0RSHgDdTpvgkUpUISQ5W9d/6a6N5knEam/TmxqDqRcpH cKhWxAchoRuWL2IJZqdPgYW37rtw+aQjUIzdzRCOh7TIi5pMz9bEH9oGRlmrjvBjJclH /lJTkpVlxKmMB/eTk83WhiImp8Zb4Avgzj9ij7osyO3r7fLRZdhnBn5WUXpK4aNJEAaG sNXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P65KOabz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m17-20020aa7d351000000b0052061adfbb4si7145222edr.80.2023.07.17.09.32.06; Mon, 17 Jul 2023 09:32:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=P65KOabz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231910AbjGQQJM (ORCPT + 99 others); Mon, 17 Jul 2023 12:09:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbjGQQJL (ORCPT ); Mon, 17 Jul 2023 12:09:11 -0400 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D65D91AC for ; Mon, 17 Jul 2023 09:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1689610150; x=1721146150; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=YY+53Xlu9otT4LWLR5OcoAlxNJ/QtG/+upDrxe/Yolg=; b=P65KOabzOwl4OpdSQaLCVVuqN68gevKGsBi9Wky7i80V6ub4lCWvnoZ2 U9xfN4GBZphQWV3s23it90+V+aLhONwsIEBaPLkijR93eAg5MmnMBBfT6 ktV/aNyNT3J0wYQL2UeLXbqaThfx9tMlEw52Fi9RTJvCjdze7sabx8FJM LAnfCV5mSmygzYp424bnhwGzHE/9b61mcRh2HxDlPPnwYTr+rZH4Z2N41 Avb1oZ8b2WhL6P0ik3yQXEHNUjRDjqJaPUodiDhexU4DgdhM8tZ1KVfTR u3i+hRxA9zJYwvxEcwRhZYWQLlmYrZr6R24rM5AKVbP81gdJH7s09Q6TR A==; X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="432142360" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="432142360" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2023 09:05:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10774"; a="847351900" X-IronPort-AV: E=Sophos;i="6.01,211,1684825200"; d="scan'208";a="847351900" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 17 Jul 2023 09:05:46 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qLQjI-004Gx5-2x; Mon, 17 Jul 2023 19:05:44 +0300 Date: Mon, 17 Jul 2023 19:05:44 +0300 From: Andy Shevchenko To: Kees Cook Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/1] seq_file: Replace strncpy()+nul by strscpy() Message-ID: References: <20230717093332.54236-1-andriy.shevchenko@linux.intel.com> <202307170826.397635AD@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202307170826.397635AD@keescook> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 08:43:55AM -0700, Kees Cook wrote: > On Mon, Jul 17, 2023 at 12:33:32PM +0300, Andy Shevchenko wrote: ... > I think this doesn't need to use seq_show_option_n() at all. Quite likely. Nevertheless, it's one of the dozens (?) warnings like this. ... > Reviewed-by: Kees Cook Thank you for the review! I think it's you who may take it as seq_file.h seems everybody's playground. -- With Best Regards, Andy Shevchenko