Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762237AbXJYQ5n (ORCPT ); Thu, 25 Oct 2007 12:57:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753004AbXJYQ5c (ORCPT ); Thu, 25 Oct 2007 12:57:32 -0400 Received: from ebiederm.dsl.xmission.com ([166.70.28.69]:53564 "EHLO ebiederm.dsl.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752882AbXJYQ5b (ORCPT ); Thu, 25 Oct 2007 12:57:31 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Thomas Gleixner Cc: "Huang, Ying" , Andrew Morton , "H. Peter Anvin" , Ingo Molnar , Andi Kleen , Chandramouli Narayanan , LKML , Arjan van de Ven Subject: Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support References: <1193295473.23935.202.camel@caritas-dev.intel.com> Date: Thu, 25 Oct 2007 10:55:44 -0600 In-Reply-To: (Thomas Gleixner's message of "Thu, 25 Oct 2007 18:09:49 +0200 (CEST)") Message-ID: User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1146 Lines: 33 Thomas Gleixner writes: > On Thu, 25 Oct 2007, Huang, Ying wrote: > >> This patch adds basic runtime services support for EFI x86_64 >> system. The main file of the patch is the addition of efi.c for >> x86_64. This file is modeled after the EFI IA32 avatar. > > modeled means copied and modified, right? > > This is wrong. I compared efi_32.c and efi_64.c and a large amount of > the code is simply the same. The small details can be sorted out by > two sets of macros/inline functions easily. > > Please fix this up. I don't think there is a compelling case for us to use any efi services at this time so unification should be easy: rm arch/x86/kernel/efi_32.c arch/x86/kernel/efi_stub_32.c Especially for accessing the real time clock that has a well defined hardware interface going through efi an additional software emulation layer looks like asking for trouble. Eric - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/