Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5a854236-0ddf-cecb-a86f-d81bc5fa4f4c@intel.com>
Date:   Mon, 17 Jul 2023 09:19:12 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH] cxl: Fix memory leak bug in alloc_mock_res()
To:     Chenyuan Mi <michenyuan@huawei.com>, <dan.j.williams@intel.com>
CC:     <Jonathan.Cameron@huawei.com>, <rrichter@amd.com>,
        <alison.schofield@intel.com>, <linux-kernel@vger.kernel.org>
References: <20230717041609.1162445-1-michenyuan@huawei.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230717041609.1162445-1-michenyuan@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NGxlQkJ6Y2o2ckllVHNPSytJSGlBOXVyUmFVUXdZVUpNMkdwOGVZMHRiRVlL?=
 =?utf-8?B?ZUVyeFdnR0ZPMFJRQ2txTkh0QXF2NmhxZGZRVjVwK1E0MitpQ2FOWkdaTmFI?=
 =?utf-8?B?QytBV1JJaG5sSFdDQzB2ckhDR0VYdmlnTWhvOWxtYkZmQzdUOTdWQklBeVI3?=
 =?utf-8?B?UEh4TG1SdHJqWGowWW5OUE5QeEI1WkFWaXB3dmJPU1M1WWtTY3ZiNGg2aCth?=
 =?utf-8?B?WWF3aHJpK2xsSVRrd3BBUDVHTXN1ejhFVFEvZy83cEhwQnp2ZFhGbFRlT2o2?=
 =?utf-8?B?a3JzcHN6SDg0V2JRUUVNQnZuYmF1SDd5cXFWT2Rqb0pYQi9tMW1aRklHdlBE?=
 =?utf-8?B?dmhPT1h5U3kxV3hBOUNPbDdIelRIT1RQV0ZGVzdiL1RPaGgzQUZQOWk5YWI4?=
 =?utf-8?B?VWFVSVNZc25VNUdtUWsvQjl4TnlHZTBDd2RMdWhzK2JYMythYzdpNUFDK1dT?=
 =?utf-8?B?TG1HeTRxT2FpRzBMaUt3S2tMK2FCRnB2ZHI2V3p3WWdWVmpRMUVhMWZKUEZU?=
 =?utf-8?B?MUR6bmM0SzdGU01Nbit2QWRtQWp1cVBrWEpaKzBGSkVVckFybDR1NU4wVHhJ?=
 =?utf-8?B?OG5BRzVZS3JUSXU2S0FHa1ZySkt0MmIxSmRIeGNUMVJ4ZXhobkQ1S1Bhb3Jj?=
 =?utf-8?B?OW5qN0xDY2FDY3NxcVVmMU82cU0ydS9WTVAxWlB3RHJlcDd4SUJGdUZ3M1J2?=
 =?utf-8?B?VDE3a1ZHZ2tVRWp0bURoOE9XZG5iRmdVR09iL3lRS01IbktUVTNETnJoME5I?=
 =?utf-8?B?SnpCWTBNalFEbUtwdllvTC9KcHlMNENhU0FaeS9QK1hMb0dQaEVEamJMRXh4?=
 =?utf-8?B?a2thU2NjRVpLeXBiVDB4RktKQU9aUTZQbURnamVuU1BrMkE0NGl1d0xsNlFx?=
 =?utf-8?B?eEQzci91Ukl3TnFZb2wvbGFXcmFhRE5DRFRtalhEZU9sczI4YmZKT04vZXA0?=
 =?utf-8?B?U2JsSEo4T3hsMElUY1BEMmxtcGo2Rmh6NWFKeEZWbGpFK3JZZHQvVk9YaTlm?=
 =?utf-8?B?K3k5UkZRVDVGYnV3b25zdG0vd3dPWWk2UnE3cXhRc2ZBZm42c2Y1ZHVyVTda?=
 =?utf-8?B?Z1RxaWpYR1JlZmgxU3NFc0g0WVF3L21UeWtac1lCcXkyV1VObmppU2Y3NnYz?=
 =?utf-8?B?OW55WnlsRDdTYWZwak9xczgzT1F1UHhOWTRGbzJPclR4MHh5cGxiL2JWbDBE?=
 =?utf-8?B?Rk5FbkRkSE5XL05TSlJmWFY2YzE5RTdDSll5Umd1cDkzQ1NQOC91N3FBY296?=
 =?utf-8?B?My91UGhJNExtb2dOWkRlV1doTEVxZ1pZZkUzbmdTY1pGS3lVSDhmYnJGM1Fm?=
 =?utf-8?B?UkcyalpGNlgvd2dSYkJMYzNIRFplN0FCY0Z0UFViT0NFcDYxR1dSZ0dKRjYw?=
 =?utf-8?B?azhTMXh6VzJMdkExa016L05LSVBaOXh6U3NZcU5UeTZ3cWJvWlBuU3pPV1BH?=
 =?utf-8?B?bFY0WTVTc3pCYWpTT1lFNG5EVWRuQS9waEdPc2p4VWVlM3BwU0VoTkJWWW1p?=
 =?utf-8?B?Q09BYTU2L1Y1eC9ia2JDZ0NiUGRhQUE1T29tdThlVUFqYmxZamxpM0ZqNlFG?=
 =?utf-8?B?WldpYW1WSWdSQjduMjZQUld6cGlNb3RwL1IzUEcvaVYzOWFoZFNoSjA3eU5P?=
 =?utf-8?B?Y0Jyc0k3TjdkOUp0ZHRIK0JxYm9EdndzZDJ1WUkweGpZMFJZekJhRFdEc3d1?=
 =?utf-8?B?TWVGWnBvbjhKN3VLV3QvT2o1UE13UmpmV3ZQQS8rSW81MGt6Z2s1eUhCTUtU?=
 =?utf-8?B?VkpGcTlJNzBaQ2szK3RXdC9KNEtDbTQ1TEZ4akhGVHgvTUo2a2l3UnBlNmR6?=
 =?utf-8?B?aStjcVA4dUJtci9XTTNyaGZlbW5EeTRleDExWFduMDUxcWdwR1NJUTRSeUJU?=
 =?utf-8?B?MHdHRCtrNlkxQVQzY0lxV01PZlFzU3F6TUVYVDRWRmlVVUhFOW9uQXFsV3h2?=
 =?utf-8?B?NG40MzRkUWo2bGtOb1ltTHV2QzJBdHZmREt6eHhkN3hkdkZDa0FkK0NGcy95?=
 =?utf-8?B?YzJ6SThvUzVvdHdhVzc5a0V2b0hQV2ZsRTZLV1dFSnAzMVpLOWVYZXY3VDQx?=
 =?utf-8?B?bWxneHBiNkFIa25DM3RHeStINnJZSDBwbVJQdVRWZUJFTWo5RW4rSXJBNTZy?=
 =?utf-8?Q?GxeKNAkGNSbDFLWN9P9CFnhHo?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1051ddbf-3e66-4404-1a06-08db86e190c2
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 16:19:15.9081
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oKFZtJ+ATo7WuZRRq+KNSxcTrRabdkJBg2Xf3iPg4MOqawojwPCujYC1IQf9+mkHzTBPdxtyf7xUak5AvudbmA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7066
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/16/23 21:16, Chenyuan Mi wrote:
> When gen_pool_alloc_algo() fails, the error handling path
> forgets to free 'res'. It would cause a memory leak bug.
> 
> Fix it by add kfree() in error handling path.
> 
> Signed-off-by: Chenyuan Mi <michenyuan@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>

> ---
>   tools/testing/cxl/test/cxl.c |   4 +++-
>   1 files changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
> index 0e78d8e19895..250ffd147067 100644
> --- a/tools/testing/cxl/test/cxl.c
> +++ b/tools/testing/cxl/test/cxl.c
> @@ -405,8 +405,10 @@ static struct cxl_mock_res *alloc_mock_res(resource_size_t size, int align)
>   	INIT_LIST_HEAD(&res->list);
>   	phys = gen_pool_alloc_algo(cxl_mock_pool, size,
>   				   gen_pool_first_fit_align, &data);
> -	if (!phys)
> +	if (!phys) {
> +		kfree(res);
>   		return NULL;
> +	}
>   
>   	res->range = (struct range) {
>   		.start = phys,