Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a607c370-030a-2b96-9aca-886a23248e83@intel.com>
Date:   Mon, 17 Jul 2023 09:28:47 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH] cxl/acpi: Use printk specifier for resource
To:     Breno Leitao <leitao@debian.org>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <jonathan.cameron@huawei.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        "Ira Weiny" <ira.weiny@intel.com>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <leit@meta.com>, kernel test robot <lkp@intel.com>,
        "open list:COMPUTE EXPRESS LINK (CXL)" <linux-cxl@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20230717102625.4083462-1-leitao@debian.org>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230717102625.4083462-1-leitao@debian.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU92SDkraU8vaHZ0NW9uQjBENkxQT2FPczNSbjRDUVc1VUcyUTVIWnhsMGx6?=
 =?utf-8?B?V0txWFlOQTV2eHhUUGlMQWFobndBMUw1Y0JvcGVYL1ZhQ1UrWmpnK0c2WGJH?=
 =?utf-8?B?ek9PbktsUTF0a3lkZktZMXNZa0xqempoUWhPeWhYcjhSNUVoVEkzQlNmaHZR?=
 =?utf-8?B?cHdZVTRoMHYrL0dQcVplc2FjNEt6cTNHWDdlV1VwZjNHU0MvM1QrVTFkajYv?=
 =?utf-8?B?Mjc0WWlwVjN1MDBhS05kQUV5VTlSZWhYaUZncC9aTTB4YmRyZi9LUUgwVzho?=
 =?utf-8?B?b09tM3ZpeXFKNFVBSnFORUJLVUp1YnB6cW1ZTmQrSW9sOFZZa1hGeWZMMHIx?=
 =?utf-8?B?OHZ6NnZkSyszSGhYV0EwNVRidzI4ZkZtSmIwZkNaZGpHK1A5THJ6cVVOT3I1?=
 =?utf-8?B?bUFhTzQxWk4zQ1RKekY0THpPd0s3TFQ5blllejQvT1pUV3RvaWI5cUtTYnY2?=
 =?utf-8?B?a1BqZytKZGxUTWV0UkZmL0MrUW1DZm1OckozTnZ1RkdwZWhmMWhIWERxOU1M?=
 =?utf-8?B?YS84Y2w3TThLOGE4dGxiQm84aHFMVTNoTWhFdXltVmZtSUpuUnE2TXJQNlVr?=
 =?utf-8?B?aTJmdnYrQW9heitIQXFTcmZCVk9VZUZTZXVwd3RwWkVac2xqajNQenZXdTNS?=
 =?utf-8?B?VlhUdVBUeVI2M3FOK0ZCeG1HUWMwN1NlSzBNMDhMS0x6VGdkU3VwWFM5Sm1F?=
 =?utf-8?B?cklraE15Z2NwaHE4NHZwSEd4KzNmR2VSS0YwZkU5dXZnNUJQL3d2ZWJocm9x?=
 =?utf-8?B?ZTQ1eVFpcXJQZW4wV1RwNGxmOFgzTlJyVmZiQnd5eU5YeWFGRUhnWlNkWXA2?=
 =?utf-8?B?WUlUeFpmMlJHeFVlTmlUTlhhK1VzeXRQRW1MZFVvdzdhMmZiZlQzMm9NeDVR?=
 =?utf-8?B?WXRrU0hiVTMwV1E2NFVKbUJmQ1BQOEI1YWJjaldsSUlPdE5WL3IwM0dCWk9n?=
 =?utf-8?B?REJrYXVuY2FyMjdrU2JraXpobGRaTkJ5QmlidGN5ZzV6aExQb0ZxOTA5YzZq?=
 =?utf-8?B?bnh6YnFKYzFtMXZ2VnlNWnF3bmlJMjh3VkpodWFWMnIyT3JidjlRWk1rZExL?=
 =?utf-8?B?U3VzVGhCd3V1NXEwT3JzUmtMc0NpWEF0dCtYUkdhWFhOZmJhSWxuRDBjczc3?=
 =?utf-8?B?UGF5cnpHZEhtTEhpZmZCcUVjMWpVOXhTWFdic2h4T1VyVUJxVDM0cFRTMmQ3?=
 =?utf-8?B?QTJ0dFBER3ZpZ1kyMzdMbXFwTTh5a0p5MUszWlJMRnR6UHg5RURSeHVhcWtW?=
 =?utf-8?B?dE9nSnNaWHdLNFRkbWYrL0Z6SFgxOTV4WTg0T08zbXI2dVRYNTFwWmtXREVU?=
 =?utf-8?B?SGFGY2F6SjJsT0pieG9SMnEveVQyY0dyMC9hZDZyZHY2SjlHSnpJMTBIdDdp?=
 =?utf-8?B?Q0xhNFRwSmtWY2dmNmZoblFjSDQ3ZTN6WUpEbzM5TGlSVUNXbEUzRFFjQ3cw?=
 =?utf-8?B?Q1VCWktKZ2FUMlpLVVlKOENQaGMrL0xKSEhTL2tlNGFyMm5tYmNtWjBmYWlY?=
 =?utf-8?B?ZXhlNUtPSkM1Skp4aHh4bjNpUU0rVTdTU0xaWWY4T3ZKZ05rQld1djNEK0k2?=
 =?utf-8?B?cy9GdWVXam10Zzc5VktNQXZOWHJPa2ZERXQzWksyMHh2WmJvYjk0a3F6cldD?=
 =?utf-8?B?QXovWDhwalMyM1FQRERLVE1kR0RDdkRnZ1JVSEpqQU53V0JzZWRNSmFHeTA3?=
 =?utf-8?B?WGRid3BDakNwVUdreGlGYmRNbU16cmdlUVhaTW94REJFeHJMYXNSUkRWdG1r?=
 =?utf-8?B?STRaa3lGN2tydzBYTUJHa1RxVW1CaVVLK3psTXNWdGRSMWpDU2hXREF4UStL?=
 =?utf-8?B?STlSaHFKMGdkQ2tPeUpPUXlLbXhpc0ZQNEVVV0JBOXk4c0Q4ZEZRR3hrNEdQ?=
 =?utf-8?B?cERTanFubm5XSmNrck1DRUFMbzRrdk9RNUpwSDBjb09OVGVJdUp5K3ZqSEd5?=
 =?utf-8?B?cHdiQ0pSN1llc2hVTHRsVlRma1RJRUlSaEtFTmV6c2FzMlV0U3FQQjdWTVJO?=
 =?utf-8?B?WDVqbG56VUhFNFZaeWk4OUV0Sy9wcnh2MW50L0t1Z2g0Q090NkFXSUJZbWY2?=
 =?utf-8?B?OXJHRjlRcHFpWkFpRzhwK3NkNFRSWE4vM2F4Y1cyZGREbVBmb1RqbDI2VU1r?=
 =?utf-8?Q?+gPq7LzhzNUUUtSrGACW2byd3?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 69276b99-8c9a-48fd-2d53-08db86e2e78d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 16:28:51.0964
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: M+R7RUzomMn9H0wHz66KLANgINh98Dim9F2kiBmicfjdYqMCQU33efU2kGtxvVgy6/rQVZGHv4CwySwNWcYtsA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7205
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/17/23 03:26, Breno Leitao wrote:
> Commit 3840e10e8dca ("cxl/acpi: Fix a use-after-free in cxl_parse_cfmws()")
> is using %llx to print resources pointers, but it is incorrect on 32-bits
> system, causing the following compilation warning on i386:
> 
> 	 drivers/cxl/acpi.c:300:4: warning: format specifies type 'unsigned long long' but the argument has type 'resource_size_t' (aka 'unsigned int') [-Wformat]
> 
> Instead of using pointers to the resource, uses the proper printk
> specifier that knows how to handle the struct "resources".
> 
> This is the new format, being printed now:
> 
> 	Failed to add decode range: [mem 0x4080000000-0x2baffffffff flags 0x200]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202307151059.2vvBt55H-lkp@intel.com/
> Fixes: 3840e10e8dca ("cxl/acpi: Fix a use-after-free in cxl_parse_cfmws()")
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>   drivers/cxl/acpi.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 815b43859c16..d1c559879dcc 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -296,8 +296,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,
>   	else
>   		rc = cxl_decoder_autoremove(dev, cxld);
>   	if (rc) {
> -		dev_err(dev, "Failed to add decode range [%#llx - %#llx]\n",
> -			res->start, res->end);
> +		dev_err(dev, "Failed to add decode range: %pr", res);
>   		return rc;
>   	}
>   	dev_dbg(dev, "add: %s node: %d range [%#llx - %#llx]\n",