Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc32013a-9f72-6a67-29ed-9a300ea1131e@intel.com>
Date:   Mon, 17 Jul 2023 09:09:17 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 04/19] selftests/resctrl: Close perf value read fd on
 errors
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>
CC:     <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Babu Moger <babu.moger@amd.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20230713131932.133258-1-ilpo.jarvinen@linux.intel.com>
 <20230713131932.133258-5-ilpo.jarvinen@linux.intel.com>
 <a4fa6303-4637-815a-e0fa-57f33babfb10@intel.com>
 <c14286ec-807c-8613-a4cc-d8ac733a87a1@linux.intel.com>
 <4531fca1-2f3b-0c08-351b-f8e06c5f9f5c@intel.com>
 <8b904781-c5d-8164-b8dc-903d412330fd@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <8b904781-c5d-8164-b8dc-903d412330fd@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDMyUFZySGczRmx3eHVQbmMvVEJyOUZSaUgybU9KYXlkNkNQMXRzTkkrRDQz?=
 =?utf-8?B?MWp3TnRIVHJvR0RNTE42NlEwMXQ1cFZBKzZvWmVuM2RXTjZaTk4xc011Yis1?=
 =?utf-8?B?bWNzS2lZZE83TWpGYUQvNnNOc0pMZmhicmR5NmJCcEJyZk1lOHYvODA5ZVov?=
 =?utf-8?B?SE9Da1FEOVJSVXFmWFdSYk5udDBLbXNhS2VXbVRWa09QOWdXY2J5TlgwNDNh?=
 =?utf-8?B?a093bkF3NHdtblVVVHUvK0UzQUZmbzcrUnE2S0w0ZjNxR0pqMFQxYjhZZUUr?=
 =?utf-8?B?aDVEK2g3ZTBjS0wvaDY3YVZiMTJ2YzdkRHBGaWVIVlFRTSs3ME4vcTZzVHox?=
 =?utf-8?B?dG05QUVocmRKbFJMS2RjZG9IU0xUZlpzWmVYOTVwOVBCR3hlVk8rRVNvbUov?=
 =?utf-8?B?OUZleW8wSS91NHpJcTVwNjEvUjVSM0c3dVFtWU15NlE4TUNKTjZnMlFyLy9y?=
 =?utf-8?B?MlY3K2FhemR5UUI3OHlGODdqQzg0UmpBQUMxQjlDMXNVZS9yZXRDRG5uRWdT?=
 =?utf-8?B?S09wMmlUMlJmTStkd20xcFF0NGpyUHlXbHN4RFNJZkFmUmtJMm9jR0xWUU1U?=
 =?utf-8?B?Vk5Cc2JxRy8xSWJWbkExc21tbENwbnMxTUJ0aDVUS3Y4VjU4c2ljU0RmaVds?=
 =?utf-8?B?Z1RTUUsyZFBFVzRhVmIvSHhUUFIvTWRSbFFqd1FEQm1tMEc2ZVNDQWVpUFZt?=
 =?utf-8?B?dTBuWjcxN3lPTE44bVJVSmRGTFJFeTRzTFRDa1RPMzlWdzkrdSswUXJKanRq?=
 =?utf-8?B?VjVHcXhTYTNrdHppQzJFQktEUnlHVk5NY0JTSTBva2N0SEtpaW5Kb3g5U0Fu?=
 =?utf-8?B?bjljZEZYMUg0YnNFNnpnMUJxTVBiWkRobWZWeDFCRzBPb0Z6aTVMblNzT09W?=
 =?utf-8?B?bUIvQ2E3YWVLTG84NVZ3TjVVUmtyUE1OSmU4S2tjOGR3cTVzQjBkSE1LWVlQ?=
 =?utf-8?B?S0ZtYnZtWFRGT0UvblRmd0NRMFRqV3FsWXBVZmhhOHBqU3RUUFg4R0NUVk5X?=
 =?utf-8?B?R1VpU3FtQ1pQaG1wTHhLNWw4VHBPVUhLeFdLd0JKK3Bzd1lUSDM1WGdURHFD?=
 =?utf-8?B?cXVaeVRkTklsNVdzSFNpejN5cVE1eWZXRmVjVy9HamlrSTBsUHVLcktyT1l0?=
 =?utf-8?B?MWp3VFREbE85aGxSaFJlSW5sczdGNVo5NTkrajJWQ2VZeHRibElaeHd3bzUx?=
 =?utf-8?B?Y3NrNEZCOENMUjJleE5xTUwycms0K0QvODd3ajZIMDd5YkF6NEZUdTRHaElM?=
 =?utf-8?B?dWF0dFg3dU5sNStubE1oeEc4cFhkS1pWOTk4WVc4cXpqRE9aTVI4OXo3ZWxv?=
 =?utf-8?B?VE1vKzMySFhjbGU5NVlWYTFVY2FzZkt1dWVhUW5RQmhEZkpodVVxN2RFQktX?=
 =?utf-8?B?WnhTcTI1T2QvZjlwODV6djBMZHovMVFKSC9RRkJFYXlySjhTcUE0UFE5MjZC?=
 =?utf-8?B?WjUzMG9jemQwUU5seFN1WitZR3lMd1pjd0pmN0NGbDRodE0yanpvU3RHRXVU?=
 =?utf-8?B?OVZTd0hvQXE4Zlc2em1ONmQrK2N3V2dVWExDS3dZRVd2dmlLTkJZbVY3OHpQ?=
 =?utf-8?B?TkdvdlYxMnhqWWlvc3lXTjQ0SDh6SXdVRDNWRVozQUN4RG9lVkRRa0dhMjlk?=
 =?utf-8?B?a1h3VEtlQ3RlUHBBek5CUTh5REZQcGRvcVE1SEJ4WHB6dFJTcWU4NmpqMkxC?=
 =?utf-8?B?V0xpOU1YVDNMM3hmUGZ3SllXYUtrbU1pdTVvOVprVXMrQTNqajJBdEpYT0ts?=
 =?utf-8?B?TUVyN0Jna3N3WDFKQTVHZDlrOVZycUY5WHN1QzdnYUNQZmhCMm5QdGFIcmxi?=
 =?utf-8?B?VXhHTnEzaXVzVk5Nekg2U2wxQmlJV3VYK3dDcDlmRFdyeUlUcWhlS3FIeGpr?=
 =?utf-8?B?clN3QW9hUUlRS2tsN2xDTXdCYWx0MC80RGpMREQ2UlJLbVJQcVQrNXRtU25I?=
 =?utf-8?B?UHo1ajZKc1Rvdm1ocVJidENGM2hsaEs0cWRvQXRqT2ZYVE5aamlpcWw5dDZO?=
 =?utf-8?B?NzU5NTFTQlA3ZHp2RTJuT1Mxbmk2RFhGVjEyNVhSc0JwZ2sxanlKbXRacDU1?=
 =?utf-8?B?M0hVYVVuc0RxbXpNQ1AvR1JRYWowRTdUTm55Z3JMckFpNzEvVW5JcjAxeWw3?=
 =?utf-8?B?WnhvQUd4ZkQ4VDB0dTZ5RGVZOWVJSVB0QjNHQURmWllxRmpwZTZpMEVVVldJ?=
 =?utf-8?B?MXc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a85fdfec-ec4d-4123-a130-08db86e02df6
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 16:09:20.6722
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0sFWOD7FiqoSLtxMZ2BTeT8FhDbOwKNOH31u1wMCJh9tDH16mJzCz/qxRc+IlQqWbubMJqkjT7JUbYs2dk7qcc2HxQdGQU6LthXj/yc5LeY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB7153
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Ilpo,

On 7/17/2023 6:05 AM, Ilpo Järvinen wrote:
> On Fri, 14 Jul 2023, Reinette Chatre wrote:
>> * add check in get_llc_perf() that it does not attempt ioctl()
>>   on "fd_lm == -1" (later addition would be error checking of
>>   the ioctl())
> 
> The other two things suggested seem unnecessary and I've not implemented 
> them, I don't thinkg fd_lm can be -1 at ioctl(). Given this code is going 
> to be replaced soonish, putting any extra "safety" effort into it now 
> seems waste of time.

Yes, this suggestion was indeed to make the code more robust. I
certainly do not want to waste your time. Please keep in mind 
when you respond that I do not have insight into the reworks
you are still planning. 

Reinette