Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230717124013.38796-2-samsagax@gmail.com> <20230717124013.38796-5-samsagax@gmail.com>
 <2023071739-remedy-sloping-64f6@gregkh> <89c6c7e8-0407-b6bb-7085-be11efce2524@roeck-us.net>
In-Reply-To: <89c6c7e8-0407-b6bb-7085-be11efce2524@roeck-us.net>
From:   Joaquin Aramendia <samsagax@gmail.com>
Date:   Mon, 17 Jul 2023 13:40:30 -0300
Message-ID: <CABgtM3i9__CghL1ikLDRRL3n+kSU2K7jCiQouNTjyZZdAbTVew@mail.gmail.com>
Subject: Re: [PATCH 3/3] hwmon: (oxp-sensors) Refactor init() and remove probe()
To:     Guenter Roeck <linux@roeck-us.net>
Cc:     Greg KH <gregkh@linuxfoundation.org>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Guenter and Greg:

> > Again, as in patch 2/3, you forgot a signed-off-by line.

Will resubmit with proper Sign-off

> > You are creating a fake platform device out of no where here, which is
> > tied to nothing, which isn't ok.  Keep it in the proper device tree and
> > have it be passed to you by the driver core in the probe() function.
> >
>
> This is a system with dmi data, so it won't support devicetree. Other
> than that, you are correct, this patch is definitely not a good idea
> and needs to be dropped.
>
> Thanks,
> Guenter
>
> > I think you will see that this changed where in /sys/devices/ your
> > device is now, right?

The attribute is created in the same place as before this patch. And
works the same as before this patch.

I can drop this patch and only resubmit 1 and 2. Thanks for the review
to both of you.

--=20
Joaqu=C3=ADn I. Aramend=C3=ADa