Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <399a6448-184b-1433-3f23-1a599656a713@suse.cz>
Date:   Mon, 17 Jul 2023 18:19:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: mprotect and hugetlb mappings
Content-Language: en-US
To:     Mike Kravetz <mike.kravetz@oracle.com>,
        Matthew Wilcox <willy@infradead.org>
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        David Hildenbrand <david@redhat.com>,
        Rik van Riel <riel@surriel.com>,
        Michal Hocko <mhocko@suse.com>, Peter Xu <peterx@redhat.com>,
        Dave Hansen <dave.hansen@linux.intel.com>
References: <20230705230808.GA41006@monkey>
 <ZKX7PerFpnoMT5Pc@casper.infradead.org> <20230705235322.GD41006@monkey>
From:   Vlastimil Babka <vbabka@suse.cz>
In-Reply-To: <20230705235322.GD41006@monkey>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/6/23 01:53, Mike Kravetz wrote:
> On 07/06/23 00:22, Matthew Wilcox wrote:
>> On Wed, Jul 05, 2023 at 04:08:08PM -0700, Mike Kravetz wrote:
>> > I was recently asked about the behavior of mprotect on a hugetlb
>> > mapping where addr or addr+len is not hugetlb page size aligned.  As
>> > one might expect, EINVAL is returned in such cases.  However, the man
>> > page makes no mention of alignment requirements for hugetlb mappings.
>> > 
>> > I am happy to submit man page updates if people agree this is the correct
>> > behavior.  We might even want to check alignment earlier in the code
>> > path as we fail when trying to split the vma today.
>> > 
>> > An alternative behavior would be to operate on whole hugetlb pages within
>> > the range addr - addr+len.
>> 
>> After a careful re-reading of the mprotect() man page, I suggest the
>> following behaviour ...
>> 
>> addr must be a multiple of the hpage size.  Otherwise -EINVAL.
>> len should be rounded up to hpage size.
>> 
>> I wonder how likely this change would be to break userspace code.
>> Maybe some test cases.
> 
> My concern is that this is the approach I took with huegtlb MADV_DONTNEED,
> and this caused problems discussed and eventually modified here:
> https://lore.kernel.org/linux-mm/20221021154546.57df96db@imladris.surriel.com/
> 
> In the MADV_DONTNEED case we were throwing away data.  With mprotect we are
> only modifying access to data.

That can still confuse some userspace, no? I think realistically we can only
document the current implementation better, maybe improve it without
changing observed behavior as you suggested wrt the split vma fail. But
changing it would be dangerous.