Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 19:08:21 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Oleg Nesterov <oleg@redhat.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/ptrace: Fix an error handling path in
 sve_set_common()
Message-ID: <3f78a04c-bafe-4def-8eeb-734589fdaaa0@sirena.org.uk>
References: <aa61301ed2dfd079b74b37f7fede5f179ac3087a.1689616473.git.christophe.jaillet@wanadoo.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="NPez/l1+KHinqP20"
Content-Disposition: inline
In-Reply-To: <aa61301ed2dfd079b74b37f7fede5f179ac3087a.1689616473.git.christophe.jaillet@wanadoo.fr>
Precedence: bulk


--NPez/l1+KHinqP20
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 17, 2023 at 07:55:05PM +0200, Christophe JAILLET wrote:
> All error handling paths go to 'out', except this one. Be consistent and
> also branch to 'out' here.

This looks like a reasonable cleanup.

Reviewed-by: Mark Brown <broonie@kernel.org>

> Fixes: e12310a0d30f ("arm64/sme: Implement ptrace support for streaming mode SVE registers")

>  		default:
>  			WARN_ON_ONCE(1);
> -			return -EINVAL;
> +			ret = -EINVAL;
> +			goto out;
>  		}

It's not exactly a fix though (probably not worth backporting for
example, which tends to get keyed off the fixes tag) since something's
incredibly confused if this code path ever gets executed, we're setting
an unknown SVE vector type hence the WARN_ON() there.

--NPez/l1+KHinqP20
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmS1g5QACgkQJNaLcl1U
h9A8/Af+JXJu75jwI/gRy39NDWPw+FkhjHQRmj8kzHLuDTOiij8wPld/G/DbE7Hi
xcZTeLirHTQRX38WBHssHbpyMh8PCsr9UPtmAGNY74WARmvFlNEli0FExVge0DIj
fPeJ5ljgrq7u9DDF+p01HXAFogOdh4fx5sXRbnJJUdDe9ltAiE2O2guCAkro/p0K
Da5c0LsGYzMqupJXernIg9rA8E/EVDKoFLweq3CHliRRlsDsSKQAdSffK1r50rW6
r1brrHk7vtOIzlxzRq8AEIOGigxtj+tSwVyCjxsfcarq0JZRbm/CmnQis2dbX6TZ
asCtZu1AqqePGzNtecVUS4FG/m6A7g==
=i1qh
-----END PGP SIGNATURE-----

--NPez/l1+KHinqP20--