Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp5958213rwp; Mon, 17 Jul 2023 12:15:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEWyYzrV8VHOS0AZr4BTMpEs3DivvaVm4TKwHyV/yh0iAdmI/GufPb0GKmViIyPQOtwAG7P X-Received: by 2002:a05:6402:31e2:b0:51d:e59c:6190 with SMTP id dy2-20020a05640231e200b0051de59c6190mr12049251edb.2.1689621343540; Mon, 17 Jul 2023 12:15:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689621343; cv=none; d=google.com; s=arc-20160816; b=wEMZYkklR8rvQJrQR+Cj8e6wqNKUqRGIDMAPq471zZ93VydB6jYrb1G9FpjwZS789J 9iV4dnw7vCGdXCJqyUmOP330L2+wj1cuhRRYrNRXALPG2kCRwjetNN2C5PVz+x8OLCIB JZctN2AqrF7J6EO6yNNdYLJCUtTPp/leaUOrOeWgxY9Y5rGgTU1OwdbVb1scy3TU2/FK 1fJmWDX8SfOkGsZxetbeDJrBiLpb4c2dreijUVHvIF/Mtf0G0HotRYPo8PtDG9hq3zyw rLnxYarWrhtr5aaRoTCVMWaB8fZN7CiusYOv1taLpIR4/cTgIVhS/ur99zySdIYC/1Kf NIBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=WnUsVHtWOhbBc6SqMYJ3oA4XGwTAbIDV93qcCN9I8QI=; fh=40WEAb2Oasn8JKeHK6IE3leC4rVyYCh70dgF1CW0ayY=; b=s0O8wt/qugQLul7Kvu38KRYdmdLNauTEYbpofrUxjnJGrcL/f+fXzLUsY4edgcHig7 jCSiVhXXrEDTucdFKvbhLjDHrNy5E7hgyL4c9D1gsERtJNPkVGEiwPUDJxkHzgqMQOnd oq/X2xiusbIaZ6A4kV0mfStC7xqON8PpAqrW3bWDxpkRFwRMwwGRCgIZdErn/Sp0Zlbi YeUh5Njmh+nY31IMSpV+qxxaZCz8EOkLD7AecIS03LGGk9k205WxlBmgA1mN0aEdNziP 12u+GYfOTuXyKXXTbGyUN0fs9RYG5mkQjrc2r+ya7lDwihFoKgAd6C8ur6Fn8kUA6D6y YbzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=sWvLA6Cg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b15-20020aa7df8f000000b0051e0ea52f6esi33870edy.171.2023.07.17.12.15.18; Mon, 17 Jul 2023 12:15:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=sWvLA6Cg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbjGQSov (ORCPT + 99 others); Mon, 17 Jul 2023 14:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41336 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229870AbjGQSou (ORCPT ); Mon, 17 Jul 2023 14:44:50 -0400 Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DEE949D; Mon, 17 Jul 2023 11:44:48 -0700 (PDT) Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-78363cc070aso271777539f.1; Mon, 17 Jul 2023 11:44:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689619488; x=1692211488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=WnUsVHtWOhbBc6SqMYJ3oA4XGwTAbIDV93qcCN9I8QI=; b=sWvLA6CgADJ/Pb2Z/tcxN22e+YnTrODv/utZE95TV2bUYwj0iERCCE7NL9bd0QiX70 PzZqiCDCFHWtQnnIZJMXkud0LsPma9s2YcLkKwlmBcSmT40Dh092DDpN3GLFa1S+Oly8 KWWLlHkPHKETyKwqnDU5HU3x2PTa1040FcOFeOshBlSI7xR//SYr61eBN/lNz+FaeAK9 EqOxsB50Ztj16BB1iY5eiY+yIaf7PkY3y4kS+2SAcdkro6Nrd66aqlZWt1pAH61+/2ck EjL1oPUiuL+j5JVeeI+oZIc/BSRIWouGhGXdl/Rzqb98ngcAvL6MpFomvf5ZRv6EETIC vayA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689619488; x=1692211488; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WnUsVHtWOhbBc6SqMYJ3oA4XGwTAbIDV93qcCN9I8QI=; b=jQgFCmPMvr7UGTNFFFyjIEbcbuP+Ai9uO63IpZ6eIG3Q6woZc7QlxLB+nkEcH2gVzQ ZHOZE+TCsyOE2qruY6PS7pR1O6QMffULOWGYJ0mANDTE2cEjXi0FFWtbNyXa20FymdV1 nsAxwZp8qnl6pqLbUsebSBGOJQkmwwMRXOCALiAboENhXSOKPUqeCCmMSdJOJxddKe4b 2UWTctvsCZ1BBq/SRR76GlgvhbLPcux/wNwZrfI0IksYuw/ZR03ezx6p9ZhcTB6KiaFG lYQOuR2hkOOHn1qOfschZFgqFgjczG2OksR8lkYL1GDSOA3Ry/41Sv/NWq3Oo4UbbcjE kN5w== X-Gm-Message-State: ABy/qLZTNcMoAGYBV/ktpSbBrYvN7VqZQKqMru60kjbh3u+SxRqGsx37 p2mR7pikGvkM+aBKrTUyMgk= X-Received: by 2002:a5e:a719:0:b0:785:cb8d:f1c5 with SMTP id b25-20020a5ea719000000b00785cb8df1c5mr534928iod.12.1689619488067; Mon, 17 Jul 2023 11:44:48 -0700 (PDT) Received: from localhost (dhcp-72-235-13-41.hawaiiantel.net. [72.235.13.41]) by smtp.gmail.com with ESMTPSA id q19-20020a02c8d3000000b0042b35e163besm14365jao.88.2023.07.17.11.44.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 11:44:47 -0700 (PDT) Sender: Tejun Heo Date: Mon, 17 Jul 2023 08:44:46 -1000 From: Tejun Heo To: Kamalesh Babulal Cc: Zefan Li , Johannes Weiner , Tom Hromatka , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup: remove cgrp->kn check in css_populate_dir() Message-ID: References: <20230717143923.1781747-1-kamalesh.babulal@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717143923.1781747-1-kamalesh.babulal@oracle.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 08:09:23PM +0530, Kamalesh Babulal wrote: > cgroup_create() creates cgrp and assigns the kernfs_node to cgrp->kn, > then cgroup_mkdir() populates base and csses cft file by calling > css_populate_dir() and cgroup_apply_control_enable() with a valid > cgrp->kn. Check for NULL cgrp->kn, will always be false, remove it. > > Signed-off-by: Kamalesh Babulal Applied to cgroup/for-6.6. Thanks. -- tejun