Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 19:31:33 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Piyush Malgujar <pmalgujar@marvell.com>
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
        adrian.hunter@intel.com, ulf.hansson@linaro.org,
        p.zabel@pengutronix.de, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
        yamada.masahiro@socionext.com, devicetree@vger.kernel.org,
        jannadurai@marvell.com, cchavva@marvell.com
Subject: Re: [PATCH v4 5/6] dt-bindings: mmc: sdhci-cadence: SD6 support
Message-ID: <20230717-dirtiness-pardon-a3fbc0925202@spud>
References: <20230717125146.16791-1-pmalgujar@marvell.com>
 <20230717125146.16791-6-pmalgujar@marvell.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="fYdzJ3cGoqsmeGH1"
Content-Disposition: inline
In-Reply-To: <20230717125146.16791-6-pmalgujar@marvell.com>
Precedence: bulk


--fYdzJ3cGoqsmeGH1
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 17, 2023 at 05:51:45AM -0700, Piyush Malgujar wrote:
> From: Jayanthi Annadurai <jannadurai@marvell.com>
>=20
> Add support for SD6 controller on Marvell CN10K series SOCs. The
> existing sd4hc is not compatible with the SD6 changes.
>=20
> Signed-off-by: Jayanthi Annadurai <jannadurai@marvell.com>
> Signed-off-by: Piyush Malgujar <pmalgujar@marvell.com>
> ---
>  .../devicetree/bindings/mmc/cdns,sdhci.yaml   | 52 ++++++++++++++++---
>  1 file changed, 45 insertions(+), 7 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml b/Docu=
mentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> index 6c40611405a08717520f4ce3a78a9cb8dd9aac69..51f44c00a50505684c7c7c49c=
59c1ebd8d85d5d0 100644
> --- a/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> +++ b/Documentation/devicetree/bindings/mmc/cdns,sdhci.yaml
> @@ -4,19 +4,23 @@
>  $id: http://devicetree.org/schemas/mmc/cdns,sdhci.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
> =20
> -title: Cadence SD/SDIO/eMMC Host Controller (SD4HC)
> +title: Cadence SD/SDIO/eMMC Host Controller (SD4HC, SD6HC)
> =20
>  maintainers:
>    - Masahiro Yamada <yamada.masahiro@socionext.com>
> =20
>  properties:
>    compatible:
> -    items:
> -      - enum:
> -          - amd,pensando-elba-sd4hc
> -          - microchip,mpfs-sd4hc
> -          - socionext,uniphier-sd4hc
> -      - const: cdns,sd4hc
> +    oneOf:
> +      - items:
> +          - enum:
> +              - amd,pensando-elba-sd4hc
> +              - microchip,mpfs-sd4hc
> +              - socionext,uniphier-sd4hc
> +          - const: cdns,sd4hc
> +
> +      - items:
> +          - const: marvell,cdns-sd6hc

This seems like a strange compatible. Why have you not gone for
something like:
compatible =3D "marvell,$socname-sd6hc", "cdns,sd6hc";
?

> =20
>    reg:
>      minItems: 1
> @@ -139,6 +143,40 @@ allOf:
>          reg:
>            maxItems: 1
> =20
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: marvell,cdns-sd6hc
> +
> +    then:
> +      properties:
> +        marvell,iocell-input-delay-ps:
> +          description: Delay in ps across the input IO cells

Are all of these things marvell specific, or would other (future) sd6hc
users need these properties too?

Thanks,
Conor.

> +
> +        marvell,iocell-output-delay-ps:
> +          description: Delay in ps across the output IO cells
> +
> +        marvell,delay-element-ps:
> +          description: Delay element in ps used for calculating phy timi=
ngs
> +
> +        marvell,read-dqs-cmd-delay-ps:
> +          description: Command delay used in HS200 tuning
> +
> +        marvell,tune-val-start-ps:
> +          description: Staring value of data delay used in HS200 tuning
> +
> +        marvell,tune-val-step-ps:
> +          description: Incremental value of data delay used in HS200 tun=
ing
> +
> +      required:
> +        - marvell,iocell-input-delay-ps
> +        - marvell,iocell-output-delay-ps
> +        - marvell,delay-element-ps
> +        - marvell,read-dqs-cmd-delay-ps
> +        - marvell,tune-val-start-ps
> +        - marvell,tune-val-step-ps
> +
>  unevaluatedProperties: false
> =20
>  examples:
> --=20
> 2.17.1
>=20

--fYdzJ3cGoqsmeGH1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZLWJBQAKCRB4tDGHoIJi
0mfaAQDTApvAlStJn77X/J3xS3TnixYN7HlFW7aSinffcJPbewD/W3IbUWlgUyon
NU+xfPE81NTFNwtq7yiaCuUTfSndmAY=
=WM19
-----END PGP SIGNATURE-----

--fYdzJ3cGoqsmeGH1--