Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Mon, 17 Jul 2023 18:54:24 +0000
Message-Id: <CU4OBQ8MQ2LK.2GRBPLQGVTZ3@seitikki>
Cc:     <kai.huang@intel.com>, <reinette.chatre@intel.com>,
        <kristen@linux.intel.com>, <seanjc@google.com>,
        <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/sgx: fix a NULL pointer
From:   "Jarkko Sakkinen" <jarkko@kernel.org>
To:     "Jarkko Sakkinen" <jarkko@kernel.org>,
        "Haitao Huang" <haitao.huang@linux.intel.com>,
        <dave.hansen@linux.intel.com>, <linux-kernel@vger.kernel.org>,
        <linux-sgx@vger.kernel.org>,
        "Thomas Gleixner" <tglx@linutronix.de>,
        "Ingo Molnar" <mingo@redhat.com>, "Borislav Petkov" <bp@alien8.de>,
        <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>
References: <20230717181732.84039-1-haitao.huang@linux.intel.com>
 <CU4OB1RHGF50.1X9C9BVY4XM42@seitikki>
In-Reply-To: <CU4OB1RHGF50.1X9C9BVY4XM42@seitikki>
Precedence: bulk

On Mon Jul 17, 2023 at 6:53 PM UTC, Jarkko Sakkinen wrote:
> On Mon Jul 17, 2023 at 6:17 PM UTC, Haitao Huang wrote:
> > +static struct sgx_epc_page *sgx_encl_load_secs(struct sgx_encl *encl)
> > +{
> > +	struct sgx_epc_page *epc_page =3D encl->secs.epc_page;
> > +
> > +	if (!epc_page) {
> > +		epc_page =3D sgx_encl_eldu(&encl->secs, NULL);
> > +	}
>
> remove curly braces

And add an empty line before the return statement.

BR, Jarkko