Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 17 Jul 2023 14:45:23 -0400
From:   Frank Li <Frank.li@nxp.com>
To:     Manivannan Sadhasivam <mani@kernel.org>
Cc:     Minghuan Lian <minghuan.Lian@nxp.com>,
        Mingkai Hu <mingkai.hu@nxp.com>, Roy Zang <roy.zang@nxp.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= <kw@linux.com>,
        Rob Herring <robh@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linuxppc-dev@lists.ozlabs.org>,
        "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-pci@vger.kernel.org>,
        "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" 
        <linux-arm-kernel@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>, imx@lists.linux.dev
Subject: Re: [PATCH 2/2] PCI: layerscape: Add the workaround for lost link
 capablities during reset
Message-ID: <ZLWMQ0w/QDdsL7yF@lizhi-Precision-Tower-5810>
References: <20230615164113.2270698-1-Frank.Li@nxp.com>
 <20230615164113.2270698-2-Frank.Li@nxp.com>
 <20230717155910.GB35455@thinkpad>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20230717155910.GB35455@thinkpad>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2xMYXhXZGdIU09GaXdPUGQ4YXJ4T1hyZFRYMFdLODdVS0FnMWtNV0Mvclpw?=
 =?utf-8?B?OFZtd0NZaHBxZXNnQlZjVlErUTYvNmpVRFUzK0JhU3BRcGNYY3NQMGREVFA0?=
 =?utf-8?B?TWtKVU91NzdOY01zZHJJc2xSTDhsa0lsSDdJaWFhYi9xMkg2dllqeTN3dTR2?=
 =?utf-8?B?U1ppSDd2Ykt1QmZJWFc4Wmg4Ukt6VC9iSjhobEd3SHpxb2tpeG1nYXFvV0dy?=
 =?utf-8?B?U3BGREJ4ZnRyQkxUNHlMMXBBUytNVVN1NGtRbTVmOHpMOWVSTHgzMXl1QlRk?=
 =?utf-8?B?RTIwQjFieUljQndkaU4xZCtOSTlobEl4VHVuM2NKWk1RRFdlWUN4djdtSWRL?=
 =?utf-8?B?WjFLMlBVcGhaMXNXWnFST2ZNdDkzc05PcTNnd3h2YmNONFJFU2xSVXRzYno5?=
 =?utf-8?B?azYzVW1VL3NlM0hXeUFoMDVMeUY3MnB1RmxyWFZ0V2NkUk9vZkZwVklqR25y?=
 =?utf-8?B?K1p4NW5idFhPZklkZERsZllmVnBNYTY1L1lKS083ajJ5emc3NnMxTGtFSEl6?=
 =?utf-8?B?SExlMWRvV2VRVWU0ZTlGMjZTTDd1LzBBc0JoYVpWUDVYNzhxcnNkLy9qaWZ6?=
 =?utf-8?B?ajc3NjFIK29vMStXSUk4L2NrVmRxNmlyVXpZZWNJa2hIU29oUkcvSlBlaENl?=
 =?utf-8?B?MUIzMGlkRlZua2JnYXNyRFhkZm9jTmh6TDQ1dnpVb0VtU21sOGNHWDZTT2xu?=
 =?utf-8?B?NFl0N0lzVFVXUGtabDM2L2lGbFBPVDQ5Y3BPWjlMWjQzdFU5MXl2SmphNTdR?=
 =?utf-8?B?T08xQnZ4cHozZmFWM3EzcWNGTDV4aU9qdWZFem03UjZUMm94UFQ4d3Y2N2pV?=
 =?utf-8?B?VkJxeVN6TEJUbFRZZnZBVGI5bFFobEhva2J3YS9BVHFnaDVqUWdObWVrMXhp?=
 =?utf-8?B?RkI1WmZ6bFlybUM2aFlvQVU5dUMwS3BwOXVDREZFcjVRSi9FMit3MUl0eFpT?=
 =?utf-8?B?UFNURmxZVThaaklLMlBNTjUwKzlZMStmc1VzS0thdVI4U25MbENSWWh3bUkw?=
 =?utf-8?B?SjJOYVlxZDlJdUNzM2tFNC9mRVhWdFNIeGQySUVDYW1kcDRPWGdMTEVmNXlZ?=
 =?utf-8?B?U2VxdWtENWdYam1MMm5qY0pONXFXQUU2UFpSZHF3RWVDMVZ5emhqOUZKNklY?=
 =?utf-8?B?TUpwTHVPWlo1UFlrbk5SMW9wODRLK1BRdDBSdW5NdzBwU1NFRWV2aDRwejUr?=
 =?utf-8?B?WU1ZQUZDbk80NE1DMzQvcUNiN0UzcWYzY0NBSjE2R3RockVSazJPUkdIWmpq?=
 =?utf-8?B?bFVsTFNFWEZVcEgyd3FYMkNpaGptdUxybER5cy9aU0EvRzlzWWdmUkhHaUo0?=
 =?utf-8?B?aTV3dEJEbGhKa2VqeTd1UGJtSUxKRXFVWTl3OTVWSXh1RURJSU54b09YNHM5?=
 =?utf-8?B?L0d5NmxLK1RWRGhJYmtkM0lialVpc2RFd3BrKzg1cWtNV3dzSkc5emRRSHJo?=
 =?utf-8?B?OUg0Umx2WHZXL3MyWlJUZFcwTEVMZGk5WC9zbG1XaUJFUHZFK3dzK2FBYitI?=
 =?utf-8?B?UFZaV1N4U1JhUEQxTlRFL0g2WExaVXdzb2JkaFZkMU5FSEdLZVNZcmVTZ1lU?=
 =?utf-8?B?eWthaFdxcU91MEVxZTdtaWo0UVlUWStDMnFYSmhwNWg4K0JyMG1KTjZsM1c4?=
 =?utf-8?B?Tk03aGl1QXRjSjVEZFFUNEhIYW5KNTUxTWtUS0g4VGdoYXVFUVh4am41ejg5?=
 =?utf-8?B?RnZQR2dWRk9zOGNobnlBY0Ewd0hoNUZjVDdVcXNYNjNpL2kzNHJ6cEtpVTBX?=
 =?utf-8?B?NzY3Ylc5S00raDc3UTFWR1hvZ2FvL2FEWHNnQWpYOThjWnZiRDN5UitZOWRh?=
 =?utf-8?B?WGRMclNBMkVBN0NYRDRtQmRqRC81WlVRTWNKeERaUVJRQkRzYmRHSUh3M2Fs?=
 =?utf-8?B?MnVaeWZOKzVxQ1ZueWJRbXhiaUt5TVRXNFpUMEpmcDd0R0YwaEM2N1JTaGVv?=
 =?utf-8?B?YXlrS1JmZ21JOGFxS0huRk82a1h4S3VWVWt0YVBGMHFTU25hRFE0citBR2Qy?=
 =?utf-8?B?ZDl0em04VTJ3TC95bElJNVdod0xaS3hST2lOVmJ6bVl5ZWpXakY3TDVPQWJJ?=
 =?utf-8?B?TFpjNEFoaFBhQ1MyakNCbndnNkV3VnFMVUwvWmxVa0F1QmdlUkZFc2VYRHNv?=
 =?utf-8?Q?EyGE=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 69ca8425-829f-4f3f-bd51-08db86f6036a
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2023 18:45:38.1605
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QeoNdLYij41geyarJU2vT9SwbsQsShCCwl4OlO/MSO6evNHj7O2ZDs6D72Yr9bZB1YTerXqcc3mhscGi9aLGGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7832
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 17, 2023 at 09:29:10PM +0530, Manivannan Sadhasivam wrote:
> On Thu, Jun 15, 2023 at 12:41:12PM -0400, Frank Li wrote:
> > From: Xiaowei Bao <xiaowei.bao@nxp.com>
> > 
> > A workaround for the issue where the PCI Express Endpoint (EP) controller
> > loses the values of the Maximum Link Width and Supported Link Speed from
> > the Link Capabilities Register, which initially configured by the Reset
> > Configuration Word (RCW) during a link-down or hot reset event.
> > 
> 
> If this fixes an issue, then there should be a Fixes tag.

It is not fixed a exist software issue, just workaround a hardwre errata.

> 
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp.com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  drivers/pci/controller/dwc/pci-layerscape-ep.c | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> > 
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > index 4e4fdd1dfea7..2ef02d827eeb 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > @@ -45,6 +45,7 @@ struct ls_pcie_ep {
> >  	struct pci_epc_features		*ls_epc;
> >  	const struct ls_pcie_ep_drvdata *drvdata;
> >  	int				irq;
> > +	u32				lnkcap;
> >  	bool				big_endian;
> >  };
> >  
> > @@ -73,6 +74,7 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)
> >  	struct ls_pcie_ep *pcie = dev_id;
> >  	struct dw_pcie *pci = pcie->pci;
> >  	u32 val, cfg;
> > +	u8 offset;
> >  
> >  	val = ls_lut_readl(pcie, PEX_PF0_PME_MES_DR);
> >  	ls_lut_writel(pcie, PEX_PF0_PME_MES_DR, val);
> > @@ -81,6 +83,13 @@ static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id)
> >  		return IRQ_NONE;
> >  
> >  	if (val & PEX_PF0_PME_MES_DR_LUD) {
> > +
> 
> Please add a comment on why the LNKCAP is being restored here.
> 
> > +		offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
> > +
> > +		dw_pcie_dbi_ro_wr_en(pci);
> > +		dw_pcie_writew_dbi(pci, offset + PCI_EXP_LNKCAP, pcie->lnkcap);
> 
> lnkcap is a 32-bit variable, so you should use dw_pcie_writel_dbi().
> 
> - Mani
> 
> > +		dw_pcie_dbi_ro_wr_dis(pci);
> > +
> >  		cfg = ls_lut_readl(pcie, PEX_PF0_CONFIG);
> >  		cfg |= PEX_PF0_CFG_READY;
> >  		ls_lut_writel(pcie, PEX_PF0_CONFIG, cfg);
> > @@ -216,6 +225,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> >  	struct ls_pcie_ep *pcie;
> >  	struct pci_epc_features *ls_epc;
> >  	struct resource *dbi_base;
> > +	u8 offset;
> >  	int ret;
> >  
> >  	pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL);
> > @@ -252,6 +262,9 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev)
> >  
> >  	platform_set_drvdata(pdev, pcie);
> >  
> > +	offset = dw_pcie_find_capability(pci, PCI_CAP_ID_EXP);
> > +	pcie->lnkcap = dw_pcie_readl_dbi(pci, offset + PCI_EXP_LNKCAP);
> > +
> >  	ret = dw_pcie_ep_init(&pci->ep);
> >  	if (ret)
> >  		return ret;
> > -- 
> > 2.34.1
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்