Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jay Vosburgh <jay.vosburgh@canonical.com>
To:     Tariq Toukan <ttoukan.linux@gmail.com>
cc:     Wang Ming <machel@vivo.com>, Andy Gospodarek <andy@greyhouse.net>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Yufeng Mo <moyufeng@huawei.com>,
        Guangbin Huang <huangguangbin2@huawei.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        opensource.kernel@vivo.com, Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [PATCH net v3] net: bonding: Fix error checking for debugfs_create_dir()
In-reply-to: <1051f5ae-82de-2e52-64f5-545fa2dedff9@gmail.com>
References: <20230717085313.17188-1-machel@vivo.com> <1051f5ae-82de-2e52-64f5-545fa2dedff9@gmail.com>
Comments: In-reply-to Tariq Toukan <ttoukan.linux@gmail.com>
   message dated "Mon, 17 Jul 2023 21:36:58 +0300."
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2412.1689623712.1@famine>
Date:   Mon, 17 Jul 2023 12:55:12 -0700
Message-ID: <2413.1689623712@famine>
Precedence: bulk

Tariq Toukan <ttoukan.linux@gmail.com> wrote:
>On 17/07/2023 11:53, Wang Ming wrote:
>> The debugfs_create_dir() function returns error pointers,
>> it never returns NULL. Most incorrect error checks were fixed,
>> but the one in bond_create_debugfs() was forgotten.
>> Fixes: 52333512701b ("net: bonding: remove unnecessary braces")
>
>It's not this commit to blame...
>Issue was there in first place, starting in commit f073c7ca29a4 ("bonding:
>add the debugfs facility to the bonding driver").

	Agreed; please upate the Fixes: commit and resubmit, thanks.

	-J

>
>> Signed-off-by: Wang Ming <machel@vivo.com>
>> ---
>>   drivers/net/bonding/bond_debugfs.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/drivers/net/bonding/bond_debugfs.c
>> b/drivers/net/bonding/bond_debugfs.c
>> index 594094526648..d4a82f276e87 100644
>> --- a/drivers/net/bonding/bond_debugfs.c
>> +++ b/drivers/net/bonding/bond_debugfs.c
>> @@ -88,7 +88,7 @@ void bond_create_debugfs(void)
>>   {
>>   	bonding_debug_root = debugfs_create_dir("bonding", NULL);
>>   -	if (!bonding_debug_root)
>> +	if (IS_ERR(bonding_debug_root))
>>   		pr_warn("Warning: Cannot create bonding directory in debugfs\n");
>>   }
>>   

---
	-Jay Vosburgh, jay.vosburgh@canonical.com