Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760598AbXJYSm7 (ORCPT ); Thu, 25 Oct 2007 14:42:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754006AbXJYSmu (ORCPT ); Thu, 25 Oct 2007 14:42:50 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:33647 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753562AbXJYSmt (ORCPT ); Thu, 25 Oct 2007 14:42:49 -0400 Date: Thu, 25 Oct 2007 11:33:52 -0700 From: Greg KH To: Alan Stern Cc: Arnd Bergmann , gregkh@suse.de, linux-arch@vger.kernel.org, linux-usb-devel@lists.sourceforge.net, matthew@wil.cx, Peter Zijlstra , Ingo Molnar , LKML , ralf@linux-mips.org, Thomas Gleixner , viro@zeniv.linux.org.uk, viro@ftp.linux.org.uk, Andrew Morton , Linus Torvalds , adobriyan@gmail.com Subject: Re: [linux-usb-devel] USB HCD: avoid duplicate local_irq_disable() Message-ID: <20071025183352.GB2176@kroah.com> References: <200710230328.33915.arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 998 Lines: 28 On Tue, Oct 23, 2007 at 12:01:37AM -0400, Alan Stern wrote: > On Tue, 23 Oct 2007, Arnd Bergmann wrote: > > > usb_hcd_flush_endpoint() has a retry loop that starts with a spin_lock_irq(), > > but only gives up the spinlock, not the irq_disable before jumping to the > > rescan label. > > > > Split the spin_lock_irq into the retryable part and the local_irq_disable() > > that is only done once as a micro-optimization and slight cleanup. > > I agree with your sentiment, but it would be better to solve this > problem without using local_irq_disable(). The patch below does this. > > --- > > Signed-off-by: Alan Stern Alan, is this something you want added to the tree and in before 2.6.24 is out? thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/