Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6139645rwp; Mon, 17 Jul 2023 15:57:51 -0700 (PDT) X-Google-Smtp-Source: APBJJlG6f3wah2BTVh+cq93+kDdWyhvckNTCr7v/YlxxzkOkkpZ9133ROOsTDzzqE09fnFPwmU4a X-Received: by 2002:a17:903:2285:b0:1b8:5a49:a290 with SMTP id b5-20020a170903228500b001b85a49a290mr16847192plh.43.1689634670660; Mon, 17 Jul 2023 15:57:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689634670; cv=none; d=google.com; s=arc-20160816; b=kerrfQLiOGG7oAOGhXkL1dTf8Nwk/kyEfk/QQFGdVOGKeCpn5F7fvkOkJxdQHtUsW/ 6tG7NB7sj1FqJmN1GrHSiu+OCqLuIuTNG7zp8+BdWmOXwako+uQwRS+afs2K3SvokScx 9gTm8PegCOSOPktQ1i2kJRR1Urg5rRUX4fgK+rFULr1OtcfW2+Ey8+tJ3mwvJfFYMtSV 5P4izEHqHzfG+OePGFtonwwRA839C8Oi+3exBJ+izY1bTxkEC9eXXVvrqwc3F7WaVQ5D zsivi1dWAaxQqlVsCiQYXhlVbiqnDDRsUHZD49nT6BnSJFs4/rMab/pb4cto8jp0yqdV 2Xag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=22T4AJNsPZJV+E1q24Ne8LGvDnuZIqG3AB+8sQzRH74=; fh=xtfLt8Q5QcFdRr1PLlUL2oKPOWNEBSPpqK5PS3y+FWM=; b=Ju8TzDOFYicj103tyeRFeN0E2d0FP2HENKLNiArTJL1zLx0826AmX1XPnc+RDWvZEZ uryO/2H1zfenmApmCtjiPqzqhSF6ITtln2YqKMeysfEl9rmTk4hkmQegKU+eoEtRsBJs hU/qwc0sa4f0iBfuxTDFB91PPt7tPrStryHh3s+M+9Gg3xQjl5iVdqzMVwgQmLQxhVXV 8AZkeuFjCZp42Bg8iefFO6HxgkJQur+TIvPpZrP2pVvuwNvNwoBpbgcD5myk6v2a029q oOZo5amcSUbmQn3layrA4mOrsQeAumPTwl1yPfIw7nqbMeja2YCcfoaqvmeG7TB5+NLn ihdw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dAN1+K0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o5-20020a170902d4c500b001b88ff2d42fsi564815plg.603.2023.07.17.15.57.37; Mon, 17 Jul 2023 15:57:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=dAN1+K0q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230340AbjGQWab (ORCPT + 99 others); Mon, 17 Jul 2023 18:30:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjGQWaa (ORCPT ); Mon, 17 Jul 2023 18:30:30 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1E76C0; Mon, 17 Jul 2023 15:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=22T4AJNsPZJV+E1q24Ne8LGvDnuZIqG3AB+8sQzRH74=; b=dAN1+K0qIXYM5HsDssNUMlrTaI lTPDmbzC1brsIBqdZPHnL6gT1qu8B8B2LBejDqIULI9Jhs/rWiwkme6wd/Qb7BgEJpTqtzZbb9YL6 UoddfQmk7T5ZH1GmmbLUHO7j6GPaIWppJtRC5DQIMSfiprNUd6hwLc80P5vQo33flGiE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qLWjT-001aHO-HH; Tue, 18 Jul 2023 00:30:19 +0200 Date: Tue, 18 Jul 2023 00:30:19 +0200 From: Andrew Lunn To: Marco Felsch Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: Re: [PATCH net-next 2/2] net: stmmac: platform: add support for phy-supply Message-ID: References: <20230717164307.2868264-1-m.felsch@pengutronix.de> <20230717164307.2868264-2-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230717164307.2868264-2-m.felsch@pengutronix.de> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 17, 2023 at 06:43:07PM +0200, Marco Felsch wrote: > Add generic phy-supply handling support to control the phy regulator. > Use the common stmmac_platform code path so all drivers using > stmmac_probe_config_dt() and stmmac_pltfr_pm_ops can use it. > > Signed-off-by: Marco Felsch > --- > .../ethernet/stmicro/stmmac/stmmac_platform.c | 51 +++++++++++++++++++ > include/linux/stmmac.h | 1 + > 2 files changed, 52 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index eb0b2898daa3d..6193d42b53fb7 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -10,6 +10,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -423,6 +424,15 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > if (plat->interface < 0) > plat->interface = plat->phy_interface; > > + /* Optional regulator for PHY */ > + plat->phy_regulator = devm_regulator_get_optional(&pdev->dev, "phy"); > + if (IS_ERR(plat->phy_regulator)) { > + if (PTR_ERR(plat->phy_regulator) == -EPROBE_DEFER) > + return ERR_CAST(plat->phy_regulator); > + dev_info(&pdev->dev, "No regulator found\n"); > + plat->phy_regulator = NULL; > + } > + So this gets the regulator. When do you actually turn it on? Andrew