Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230714194610.828210-1-hannes@cmpxchg.org> <ZLIVleBYOm4HIGTZ@casper.infradead.org>
 <20230717141250.GA866068@cmpxchg.org> <901409ed-504b-9500-54d8-e42f832e07b0@suse.cz>
 <20230717160227.GA867137@cmpxchg.org> <ZLVnUhXeZ6ptNF2l@casper.infradead.org> <20230717215105.GA909920@cmpxchg.org>
In-Reply-To: <20230717215105.GA909920@cmpxchg.org>
From:   Nhat Pham <nphamcs@gmail.com>
Date:   Mon, 17 Jul 2023 15:58:45 -0700
Message-ID: <CAKEwX=N5ruUdkzfvwpXMZWQByCkqP4WJFsJzKVAWkTm8osHeUg@mail.gmail.com>
Subject: Re: [PATCH] mm: kill frontswap
To:     Johannes Weiner <hannes@cmpxchg.org>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Yosry Ahmed <yosryahmed@google.com>,
        Christoph Hellwig <hch@infradead.org>,
        Domenico Cerasuolo <cerasuolodomenico@gmail.com>,
        konrad.wilk@oracle.com, vitaly.wool@konsulko.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Jul 17, 2023 at 2:51=E2=80=AFPM Johannes Weiner <hannes@cmpxchg.org=
> wrote:
>
> On Mon, Jul 17, 2023 at 05:07:46PM +0100, Matthew Wilcox wrote:
> > On Mon, Jul 17, 2023 at 12:02:27PM -0400, Johannes Weiner wrote:
> > > -   pr_info("Adding %uk swap on %s.  Priority:%d extents:%d across:%l=
luk %s%s%s%s%s\n",
> > > +   pr_info("Adding %uk swap on %s.  Priority:%d extents:%d across:%l=
luk %s%s%s%s\n",
> > >             p->pages<<(PAGE_SHIFT-10), name->name, p->prio,
> > >             nr_extents, (unsigned long long)span<<(PAGE_SHIFT-10),
> > >             (p->flags & SWP_SOLIDSTATE) ? "SS" : "",
> > >             (p->flags & SWP_DISCARDABLE) ? "D" : "",
> > >             (p->flags & SWP_AREA_DISCARD) ? "s" : "",
> > > -           (p->flags & SWP_PAGE_DISCARD) ? "c" : "",
> > > -           (frontswap_map) ? "FS" : "");
> > > +           (p->flags & SWP_PAGE_DISCARD) ? "c" : "");
> >
> > Is it useful information (to the sysadmin) that zswap is enabled?  If s=
o,
> > we might want to print a "Z" instead of a "FS" here (would need to
> > know whether enabling zswap succeeded ...)
>
> I don't think it is needed in this particular place.
>
> zswap prints to dmesg when it is initialized. And it's easy to runtime
> check in sysfs or in /proc/meminfo if it's enabled - that's where I
> would look first if I checked a system that's showing zswap issues -
> not in the dmesg that may have long wrapped since swapon.
+1
I always use /sys/kernel/debug/* and  /sys/module/zswap/parameters/*
for debugging zswap issues too.
>
> There is also a warning to dmesg if zswap fails to enable for a given
> swapfile. But with the current page allocator implementation this
> can't actually fail.