Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     Rob Herring <robh@kernel.org>,
        Stanley Chu <stanley.chu@mediatek.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>
CC:     "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH] ufs: Explicitly include correct DT includes
Thread-Topic: [PATCH] ufs: Explicitly include correct DT includes
Thread-Index: AQHZtnu0BF8S1Q5yGkOLZV4P7Kxbba++uXGA
Date:   Tue, 18 Jul 2023 01:06:36 +0000
Message-ID: <TYBPR01MB534108F7223FA2CA5BC70E73D838A@TYBPR01MB5341.jpnprd01.prod.outlook.com>
References: <20230714175018.4064957-1-robh@kernel.org>
In-Reply-To: <20230714175018.4064957-1-robh@kernel.org>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y3VCAAkwPMiOQaQU8vgvweKnmHamhFb4+YkFc9WTr1kqD0k65kFBgb5pd7Bp?=
 =?us-ascii?Q?/06uywyE7LjXaCKL0jOiwFLomN8q998ndG6zduKoxDAh/sj579SI4Oorh5BI?=
 =?us-ascii?Q?My0YrhTRUVt5e7UdKMOmAjho75DECLJY0AIKlFU2YCFMyZKdQCT570Yczt2B?=
 =?us-ascii?Q?LFkD0LOzRM0Ag4zYERsUJLiwDLTNYxoHoaKffVaG1G0rXubm5TWz630Q70Sk?=
 =?us-ascii?Q?3HbRkzmcfcvLq6H7/2trylSg47p9427Au77/T6baKoZrCh3x8VxmVlw9w0ji?=
 =?us-ascii?Q?CPJUgibDoLaM/wYDG5qs60GfwJ7bZoBljXNKjVJoob5T0WRcjrzsdh1MbgBe?=
 =?us-ascii?Q?B6xeN88av8bSKYz2YrJIrHZxoBVKvHYouSDT++yXgizYWfwawUNGbg9Qjx95?=
 =?us-ascii?Q?V52roj2NOFPO84xHgUxr3Twrg/05O+ZM5nfidkioS8gmxqOyJtjoEfH8pWxb?=
 =?us-ascii?Q?CzPh0NdZddtM+6WSasunoA1+S4z5Sd54C/w8aWARzcs5NsIV9qLKV+iwUg3c?=
 =?us-ascii?Q?9e+hSY21yyp7PDD+Wo6dYuVVLq8ewxOfKL3n5ZObGwH0ovuDp1DwQOoGOpC+?=
 =?us-ascii?Q?63hlksxMTHcBrznpk5FzcNmT8ccPqzrJQSpJP9EPfMqUWdYKvC6lduFDI0AG?=
 =?us-ascii?Q?WnFtjXJuH2rfGdEgZ3Thm2G3ftWneHAuUcAnsvXE0mtLdBq/Z9vGLIz3tHA2?=
 =?us-ascii?Q?rqwKAjgKFhcTHDAB6TO+oQ2nQPmsB16pW1wCx4uDInEnyG9ewz+0Z7EnMHx3?=
 =?us-ascii?Q?Owur2jPE+o5SS3ZcbWYOHYUO5j0eVcLOGtNYzK4Qvhonx4EZzZ8CvF+/6YhI?=
 =?us-ascii?Q?bUCvB501kY/y8AvaAnqpakbaIajGxfBtmDxaHfpMlCJHd30G/t0vZQD7NjGz?=
 =?us-ascii?Q?rmNbj9HTS6KOqYzj7VEoecLHlxxo3YxrFe7aL4x36OhYtGXxv/wZJPj/RsU6?=
 =?us-ascii?Q?jEsddqgdW9ZNxE2GSa2Dj3pwFkdBlOlpsTv6eGyej9JPTIEMxiL0jrP+48bP?=
 =?us-ascii?Q?um71S6gYr+bc/mfpwwAX9oth53qkA79jndvjhwEDLfYcQ+/A1xHsVgIJbgju?=
 =?us-ascii?Q?GRuhXYl4ykNb7k87a/GiPOqzCK7BmgikzPybSgFHg+Qyt+J/Upj/zHLyBbnW?=
 =?us-ascii?Q?Zg2oaaTOPBYJe3xuy/au06LIhFc65hyjL7/Lqyq/t2mWdODE6VEZLYjAV90e?=
 =?us-ascii?Q?16NKj5sm9t2HSAC8jWkQEf0B9jMX0hEaIg9sHAQy4+MvtxUtPMRDQO7JxF7H?=
 =?us-ascii?Q?2YZ706st3np6zX17HDXHqC6x/EX5zO2nyEembPdmbBNdgNJq/Cm8rEmA6ZtX?=
 =?us-ascii?Q?weUIfEMgvqiSH6TWchezpNRD8xGJv0hLhX3+3CLh12XMB52c45tsj1W521fA?=
 =?us-ascii?Q?MzbHInkudAEk8R1qL31Wi5C86NnF7ox6lBtR/UX6iZ+AbsXg6ocXTOTiBfSE?=
 =?us-ascii?Q?Qngk2IUmB2A09CLEy/fQesFqtsz/FStfIGpyWQXgM3oOYMvMUsRn96/tdS7s?=
 =?us-ascii?Q?1wYjDGJFGam0uNqcd/atgci2nYMLJp0o+DskQZB5GmtXo2UfpNxaFCB2/GpO?=
 =?us-ascii?Q?p2ABvCHSZFTDdrcwsYqYkITY75IOT7WP2t7S8aI0rlnaMj5qWfU8nipUCZx0?=
 =?us-ascii?Q?Su83VQonFloyBhu7lTsGv5yxuddcvqy+FpNCj5aGDM1aUg8RJtWLifSIpMco?=
 =?us-ascii?Q?S8acNg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYBPR01MB5341.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b02095e1-14f0-4923-7384-08db872b3c4a
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 01:06:36.7591
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: oYYBnSUXdOrwxAZ15SkUFrAT925gVlxeqXNhCudOKcBqtGKbIC5Z81Ygkm5eZznqpoqhSax2ChQ06LMZKljN6YB4nGrzwF00y4tAHjXVhLOvuAe3UxVLK/udtFk8Q4By
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB9360
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Rob,

> From: Rob Herring, Sent: Saturday, July 15, 2023 2:50 AM
>=20
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>=20
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
...
>  drivers/ufs/host/ufs-renesas.c  | 2 +-

Thank you for the patch! About this renesas related file:

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

>  2 files changed, 2 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-media=
tek.c
> index e68b05976f9e..aceb3747f7b8 100644
> --- a/drivers/ufs/host/ufs-mediatek.c
> +++ b/drivers/ufs/host/ufs-mediatek.c
> @@ -14,6 +14,7 @@
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/of_device.h>
> +#include <linux/of_platform.h>
>  #include <linux/phy/phy.h>
>  #include <linux/platform_device.h>
>  #include <linux/pm_qos.h>
> diff --git a/drivers/ufs/host/ufs-renesas.c b/drivers/ufs/host/ufs-renesa=
s.c
> index f8a5e79ed3b4..49f7bafc7d55 100644
> --- a/drivers/ufs/host/ufs-renesas.c
> +++ b/drivers/ufs/host/ufs-renesas.c
> @@ -12,7 +12,7 @@
>  #include <linux/kernel.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> -#include <linux/of_device.h>
> +#include <linux/platform_device.h>
>  #include <linux/pm_runtime.h>
>  #include <ufs/ufshcd.h>
>=20
> --
> 2.40.1