Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <779227c4-65e2-1608-0abf-f19eedc386a6@intel.com>
Date:   Tue, 18 Jul 2023 09:14:07 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [PATCH v1 2/3] mm: Implement folio_remove_rmap_range()
Content-Language: en-US
To:     Ryan Roberts <ryan.roberts@arm.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        "David Hildenbrand" <david@redhat.com>,
        Yu Zhao <yuzhao@google.com>, Yang Shi <shy828301@gmail.com>,
        "Huang, Ying" <ying.huang@intel.com>, Zi Yan <ziy@nvidia.com>
CC:     <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
References: <20230717143110.260162-1-ryan.roberts@arm.com>
 <20230717143110.260162-3-ryan.roberts@arm.com>
From:   Yin Fengwei <fengwei.yin@intel.com>
In-Reply-To: <20230717143110.260162-3-ryan.roberts@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RThJc2dzZ0RTVVV5Q0drUHdxT3RucjFaSWthTXowU1JZUDRaQlBwRnNzZ3Ir?=
 =?utf-8?B?VDYyRUNmdzZzVTlsTzJ2cUcxRklwd3ZhK3I4M1gzZk8raDVoMnJYZHhsL0JS?=
 =?utf-8?B?WTJ2WGM5UUZ6cEd2N2J3eklnMGVkYTEreUxRV09WUjhVeVlNTTdoUVB2dVpW?=
 =?utf-8?B?OXhCRG1jdTZvR0NNVTJBQW9jMHYzVUtDQ1RsbFR6YU9ldUU3akRBcHZ2ejZw?=
 =?utf-8?B?L2xzbTQ2NTZRTG9mcmE4YmZocUNUTHJQd3FISGR1ZTBqa0lKeVVVQk93eEpR?=
 =?utf-8?B?R1IwbTh4NUI4R2VzbFU5MFFXdFNxOFFtaDhaM1Z0RXZaclFCS1hsK1hGWTk2?=
 =?utf-8?B?TVVHYVhoZk8wU0Y4M0dBV1NpZW0rMmt1TWdLZDF2SVR0S3pmam45RU05dU1K?=
 =?utf-8?B?b1R6MThIMXFlcmNLZ05Ub3ZaMHcvOUtZWGNrQnZ2Wm9MaTg1dGZMb3g0VnRa?=
 =?utf-8?B?S3FIUXVGVEpzRlBQblZlazI2REZsaXBucEpjRHJ0UndzNWV5amxxVTBwTHRv?=
 =?utf-8?B?NkxwZ0psQjNxV0EvQ2Y0N2tkdXVzUSt1UHkvOEw0MU1YUE1DSWJicnQ5bHFF?=
 =?utf-8?B?eE80U0xKRzIwaXl5UGlxc00vV1grUzJMME9xczFQMkRqTnVCaXg0Znp6UDFn?=
 =?utf-8?B?UUN5dmlZTzkvQ0x6VTJhTGlUd0NyVHpFcFZoMzBaM2pyQnMybW5zcjUyWFFW?=
 =?utf-8?B?SVFYOW9uUTRML2lYS2NGd1dYQk5BRjU0SllFcldrRHBVZHJnakIvMUlUT3Yv?=
 =?utf-8?B?THJpdlZ0dHBMVEthRWc2MG96eUJzbDlGd2g5TnZhWGhaTTc2emFRa0xUTjZs?=
 =?utf-8?B?dXpRL3BpMG9xbFJmbWMrWmJkOXVjQlo1QjQyS2RlRmV6K0h2Zjh2UlE5Q0FY?=
 =?utf-8?B?cVcvVWZUMFdISzFmUm1qOTZzSmRpUXMzRkhQb05rUjdLVVErbWp4UFpOK0dJ?=
 =?utf-8?B?a2J4dURHSHdoTG9JWktGSkNZWWtqbExEOGNzeUs4M0p0MVo2VytXQ2JGbFR0?=
 =?utf-8?B?NkdsV2NDaGhpSzcrQUtRZWFMaGY4Wlk0ajJHejdmSWdzTXFOR2tYNXlFYjhq?=
 =?utf-8?B?L2RtL254WVVyS3QwSk1RQW83ZXlxZWNXcndHYVF3M1RWUUwrWjdZdDIvcU43?=
 =?utf-8?B?WmpHMlhLaXozbDF0TVk5VlVEbFNpVDZ2eEk0VDJsOW9LYWhpOTBHbnZFcm1D?=
 =?utf-8?B?cDFiMVdSOEgzMHdMOWhlZ2RDM25CZW9rME5ZNU50L2IvYUdwbU10VzQ2Tll0?=
 =?utf-8?B?b1kwMitWMDlaZGdoS0F4cnVIS2Jlc3NWczI1a2ltSS9KQVpIM1lCemdVdTdC?=
 =?utf-8?B?N1ZrK2VIWGpMN01Sd2sxR2N1dElTRS9FV1JMeitFUHNrYnNWWHVoZGx3K29s?=
 =?utf-8?B?aExpWUFjNTdMRTAzd29uUnlQRFBDdlkwNFVCRkNrM1lueGFBSjUwOS9XT2RV?=
 =?utf-8?B?MDFXY2tlNEp0bENxRnFuKzJkTHZlcW50c01ZNFpYMjJZYkUvZzhJSzAvY0py?=
 =?utf-8?B?QlB0NnhIRmVGLzNGL042Nmh6c2VSeWlrdmlFTGtLSFBobEk1MEZCOERFMldT?=
 =?utf-8?B?clQ3RE9FYWNqVGZyY1FmOHlXQVZEalpCbHJsRkl3VHNQNG1uQTdzWlh2bFUv?=
 =?utf-8?B?MSs0b3VaMkhRWTVoMko2T0s5ZktyNkVNWFB5WlhhYW1ZMFdJUlZHd3NQQTVJ?=
 =?utf-8?B?TzRGL01HM1AwRVFhRjMrQXlETmRDRVl3TTltRWtHaXNtbGQ0TFJvMCs2OURZ?=
 =?utf-8?B?SUpkeXlRRWZuSVMrZExrY216dU5LUjdkNkljWVBvTmVwV1lIcGNLVnp0bXBk?=
 =?utf-8?B?bW51WEthVFBhcnROR2VtWGorWmptK1JIVnJSM0hyNUppNlNPelJqVURFdGVD?=
 =?utf-8?B?b0IxbTNEdlNmVzNFMXdVVlo4NFZ0Wjh6aDVTZi9VZDZRRithdkt4THBKbUhR?=
 =?utf-8?B?bEtwSHhrbzMxd0xKa1Z2dzdvUDhBZ0dmWTRXVHlPclNFNmd6UTVJNE0zVFlm?=
 =?utf-8?B?NHdMMGJrU2pLQTRyeWFDamRLVWpudmQzUXR5ak5hYmVMRlBqU0FkU2RRUklZ?=
 =?utf-8?B?b3Ara0lYLzh1K1pMbXJpQUc5WHhDbloxblFyM1Y0YVhjRWtpR1ZvU3VVNnZk?=
 =?utf-8?B?R0dNRG55YTZTWW1GWU5JY1VIaXFnZ01xbXUvb0V1aGpqKzd2Y2xScGIxR0xq?=
 =?utf-8?B?UEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1265e0a8-e513-439b-850b-08db872c4834
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 01:14:06.4223
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FBe9Bel/nmQVMRBJ84qdLHdeFUfHqLFtYBpXpheqrzYoOHRkMN9hGE2dJBKBDAa6p2PnGODwfSjQYTzCrRgPMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6391
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/17/23 22:31, Ryan Roberts wrote:
> Like page_remove_rmap() but batch-removes the rmap for a range of pages
> belonging to a folio. This can provide a small speedup due to less
> manipuation of the various counters. But more crucially, if removing the
> rmap for all pages of a folio in a batch, there is no need to
> (spuriously) add it to the deferred split list, which saves significant
> cost when there is contention for the split queue lock.
> 
> All contained pages are accounted using the order-0 folio (or base page)
> scheme.
> 
> Signed-off-by: Ryan Roberts <ryan.roberts@arm.com>

Reviewed-by: Yin Fengwei <fengwei.yin@intel.com>

Regards
Yin, Fengwei

> ---
>  include/linux/rmap.h |  2 ++
>  mm/rmap.c            | 65 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 67 insertions(+)
> 
> diff --git a/include/linux/rmap.h b/include/linux/rmap.h
> index b87d01660412..f578975c12c0 100644
> --- a/include/linux/rmap.h
> +++ b/include/linux/rmap.h
> @@ -200,6 +200,8 @@ void page_add_file_rmap(struct page *, struct vm_area_struct *,
>  		bool compound);
>  void page_remove_rmap(struct page *, struct vm_area_struct *,
>  		bool compound);
> +void folio_remove_rmap_range(struct folio *folio, struct page *page,
> +		int nr, struct vm_area_struct *vma);
>  
>  void hugepage_add_anon_rmap(struct page *, struct vm_area_struct *,
>  		unsigned long address, rmap_t flags);
> diff --git a/mm/rmap.c b/mm/rmap.c
> index 2baf57d65c23..1da05aca2bb1 100644
> --- a/mm/rmap.c
> +++ b/mm/rmap.c
> @@ -1359,6 +1359,71 @@ void page_add_file_rmap(struct page *page, struct vm_area_struct *vma,
>  	mlock_vma_folio(folio, vma, compound);
>  }
>  
> +/*
> + * folio_remove_rmap_range - take down pte mappings from a range of pages
> + * belonging to a folio. All pages are accounted as small pages.
> + * @folio:	folio that all pages belong to
> + * @page:       first page in range to remove mapping from
> + * @nr:		number of pages in range to remove mapping from
> + * @vma:        the vm area from which the mapping is removed
> + *
> + * The caller needs to hold the pte lock.
> + */
> +void folio_remove_rmap_range(struct folio *folio, struct page *page,
> +					int nr, struct vm_area_struct *vma)
> +{
> +	atomic_t *mapped = &folio->_nr_pages_mapped;
> +	int nr_unmapped = 0;
> +	int nr_mapped;
> +	bool last;
> +	enum node_stat_item idx;
> +
> +	if (unlikely(folio_test_hugetlb(folio))) {
> +		VM_WARN_ON_FOLIO(1, folio);
> +		return;
> +	}
> +
> +	if (!folio_test_large(folio)) {
> +		/* Is this the page's last map to be removed? */
> +		last = atomic_add_negative(-1, &page->_mapcount);
> +		nr_unmapped = last;
> +	} else {
> +		for (; nr != 0; nr--, page++) {
> +			/* Is this the page's last map to be removed? */
> +			last = atomic_add_negative(-1, &page->_mapcount);
> +			if (last) {
> +				/* Page still mapped if folio mapped entirely */
> +				nr_mapped = atomic_dec_return_relaxed(mapped);
> +				if (nr_mapped < COMPOUND_MAPPED)
> +					nr_unmapped++;
> +			}
> +		}
> +	}
> +
> +	if (nr_unmapped) {
> +		idx = folio_test_anon(folio) ? NR_ANON_MAPPED : NR_FILE_MAPPED;
> +		__lruvec_stat_mod_folio(folio, idx, -nr_unmapped);
> +
> +		/*
> +		 * Queue anon THP for deferred split if we have just unmapped at
> +		 * least 1 page, while at least 1 page remains mapped.
> +		 */
> +		if (folio_test_large(folio) && folio_test_anon(folio))
> +			if (nr_mapped)
> +				deferred_split_folio(folio);
> +	}
> +
> +	/*
> +	 * It would be tidy to reset folio_test_anon mapping when fully
> +	 * unmapped, but that might overwrite a racing page_add_anon_rmap
> +	 * which increments mapcount after us but sets mapping before us:
> +	 * so leave the reset to free_pages_prepare, and remember that
> +	 * it's only reliable while mapped.
> +	 */
> +
> +	munlock_vma_folio(folio, vma, false);
> +}
> +
>  /**
>   * page_remove_rmap - take down pte mapping from a page
>   * @page:	page to remove mapping from