Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sandor Yu <sandor.yu@nxp.com>
To:     Alexander Stein <alexander.stein@ew.tq-group.com>,
        "andrzej.hajda@intel.com" <andrzej.hajda@intel.com>,
        "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
        "Laurent.pinchart@ideasonboard.com" 
        <Laurent.pinchart@ideasonboard.com>,
        "jonas@kwiboo.se" <jonas@kwiboo.se>,
        "jernej.skrabec@gmail.com" <jernej.skrabec@gmail.com>,
        "airlied@gmail.com" <airlied@gmail.com>,
        "daniel@ffwll.ch" <daniel@ffwll.ch>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "krzysztof.kozlowski+dt@linaro.org" 
        <krzysztof.kozlowski+dt@linaro.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-phy@lists.infradead.org" <linux-phy@lists.infradead.org>
CC:     "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Oliver Brown <oliver.brown@nxp.com>,
        "sam@ravnborg.org" <sam@ravnborg.org>
Subject: RE: [EXT] Re: [PATCH v7 3/7] dt-bindings: display: bridge: Add
 Cadence MHDP850
Thread-Topic: [EXT] Re: [PATCH v7 3/7] dt-bindings: display: bridge: Add
 Cadence MHDP850
Thread-Index: AQHZuIUePa/zOSPAXUe6/zQl/U27da+9sp2AgAERxRA=
Date:   Tue, 18 Jul 2023 01:58:09 +0000
Message-ID: <PAXPR04MB94483425E2BC17597B7E555AF438A@PAXPR04MB9448.eurprd04.prod.outlook.com>
References: <cover.1689580812.git.Sandor.yu@nxp.com>
 <3646ea4d279838c78e00af1d746e3de34351b083.1689580812.git.Sandor.yu@nxp.com>
 <5693162.DvuYhMxLoT@steina-w>
In-Reply-To: <5693162.DvuYhMxLoT@steina-w>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?vo2vCz/YFvz7tMiN9mw91kl7fO1Us3mahQSGoeuc2dyxC/9ov31WgYIc8p?=
 =?iso-8859-1?Q?zbMEVaUzygDBH0Ua8gkSkUSgnelOvYtfi5z2t2Fc9fhT99QnUt+AyJlRcl?=
 =?iso-8859-1?Q?DDCUINPR0cnQ24/NH7r7V3Pn10pRiZXMTm3Mb/tqg+OGDKKDY5S5FwjrAo?=
 =?iso-8859-1?Q?dZ/LhpM+1YbFbFGPyU27rxCodaj/6Giw9jP+r7D3QFuZhJjrjTldtP8sZ2?=
 =?iso-8859-1?Q?f6JkfFM2RL2c0IiHYshnsGYoAPR8Y1o15oxu2y2LbHgo9zarJcI3kURtRb?=
 =?iso-8859-1?Q?LIQQ4Vu/k1svDdagQDfcmr15MQeI5fRIXHTv3gHATqBjdTMPB1xfseBu6e?=
 =?iso-8859-1?Q?KWdmtgA35YC1MyKENG3DST3J5qu0kz5cbmjOomukUlL2XyUvRv3cQnFUXZ?=
 =?iso-8859-1?Q?ZT2zRv42WortqxE7OfSl4TVQycDsVRV9HfCn1Q1CP30FoGZBJYPCj4t3fg?=
 =?iso-8859-1?Q?39DzlUTL5cWyCfS36P89uV7hDX5ZnqbHqfuaZ2OihqIv7eaQs2SfbEL9Tv?=
 =?iso-8859-1?Q?9kPr1FqN3sjCHJX0X6BhkX1mpEZEA/rc0jyg1TrD+NKDY/1riK7okqRowz?=
 =?iso-8859-1?Q?0P2FY5+u8Xu/bcDu5FQKq6q/Imuy3Y+FJjIOf95H6B4mobZfi+i9yVcFLF?=
 =?iso-8859-1?Q?9YVy8HDtG459ZICZsAbP2Qfm1U8Ji0gIbw1h34dtnApwyLEBqwrXdJSGf2?=
 =?iso-8859-1?Q?FY6z9bFd+pTJ4K+jGVeYdNSuFBWTFy/o2BzZbaJNET8Le83JhCBxHbyEE4?=
 =?iso-8859-1?Q?sWtrchR658jk97pd6Xa4lt+9bS4x3mIypDhyDInClYqIdrQpU7gAd4rhQt?=
 =?iso-8859-1?Q?WBhzPedCN+KnXpObCS0qPuLwWY5krRzHN2UAMmcN21lw4tUq2hta0B8yZK?=
 =?iso-8859-1?Q?DhLTf1oi4YEdx7yUlbTDcDD1AvuUK4qWsEsK0f9LMendcWNwY2cQIqL5mU?=
 =?iso-8859-1?Q?dFdkSXUL5hz0NWM8/Gh2JTiuukbscy2YhOJtldBwRpcR4BSmlfnr77fHTz?=
 =?iso-8859-1?Q?Eyuvqn43yNrMbeXXtDV+8rN5l9VoC+X2BS3WNdaSd4q1+/3acdpxYRjOPZ?=
 =?iso-8859-1?Q?0ChRmWTOC3kFPXWactyDsAecGgncakYIApUDXBF+knGngSz65cKNZIIZCu?=
 =?iso-8859-1?Q?vx87cec1TUa3X2i+j5bQJaDwVCWj82dTYOlUBltg1aHuxqXdciJGI9Qvuo?=
 =?iso-8859-1?Q?hZZBjGZ0ttOm4/OW162Qkiv6QqoheCuj6U7WRcjlRTW7XpM0mddEfG4ZzC?=
 =?iso-8859-1?Q?MYFP5aKqaNZx9Ex0K2G7Sl6a739Eeu5+54NTOnqfxdx5eJGcQI4QKC1rMU?=
 =?iso-8859-1?Q?wYrjlfxgGi0Ate5GauWf7zPTt9PvzrRuPkYSwpxmwCiAGZTr+Se3mqEfCp?=
 =?iso-8859-1?Q?OQawKEWjCYLoWoVYCsQAQWte0awhMJ6BLei2uOVYiKv6z7K0g/IOsFAHXV?=
 =?iso-8859-1?Q?I/svMY023pHgpKCZz71npguXK63Gvhm8aUfEDSHSktlzkpxCtafNGvONbH?=
 =?iso-8859-1?Q?11RvS87YilXgIF5t81693mAorN/EsO8OLRtPSV81XUtoUKvQnKh3RcrI3J?=
 =?iso-8859-1?Q?8q5TsTugOSXvnfaO1tlN6feHO8yJHmI0fvrQ3iJ4KwUmVpqjnMHHBoyLhk?=
 =?iso-8859-1?Q?qN7cvohW2VfP0=3D?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9448.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5930d55d-5799-43b2-2734-08db87326fbe
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 01:58:09.5845
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5f/DmCtjryd3QLJ5GI63sgjPcLGm1UM1vZlHg65d6iOgTfgDIn8Oq4304K6wkhbM01YOHtBs1vGVQhuTj6mgKA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR04MB10030
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alexander,

Thanks for your comments,

>
> Am Montag, 17. Juli 2023, 10:03:49 CEST schrieb Sandor Yu:
> > ********************
> > Achtung externe E-Mail: =D6ffnen Sie Anh=E4nge und Links nur, wenn Sie
> > wissen, dass diese aus einer sicheren Quelle stammen und sicher sind.
> > Leiten Sie die E-Mail im Zweifelsfall zur Pr=FCfung an den IT-Helpdesk =
weiter.
> > Attention external email: Open attachments and links only if you know
> > that they are from a secure source and are safe. In doubt forward the
> > email to the IT-Helpdesk to check it. ********************
> >
> > Add bindings for Cadence MHDP8501 DisplayPort/HDMI bridge..
> >
> > Signed-off-by: Sandor Yu <Sandor.yu@nxp.com>
> > ---
> >  .../display/bridge/cdns,mhdp8501.yaml         | 105
> ++++++++++++++++++
> >  1 file changed, 105 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> > b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.yaml
> > new file mode 100644 index 000000000000..b983ee765f54
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/display/bridge/cdns,mhdp8501.y
> > +++ aml
> > @@ -0,0 +1,105 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> > +http://devi/
> >
> +cetree.org%2Fschemas%2Fdisplay%2Fbridge%2Fcdns%2Cmhdp8501.yaml%
> 23&dat
> >
> +a=3D05%7C01%7CSandor.yu%40nxp.com%7C603a90f3f3c34d32a1e708db86a
> 8f868%7C
> >
> +686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63825183250590544
> 2%7CUnkno
> >
> +wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1
> haWwi
> >
> +LCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=3DJnbufeZplo%2B6JGW4HaK
> %2BLyC0MESK
> > +GsV%2FtjfeXCXqK4U%3D&reserved=3D0
> > +$schema:
> > +http://devi/
> >
> +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=3D05%7C01%7CSandor.
> yu%40n
> >
> +xp.com%7C603a90f3f3c34d32a1e708db86a8f868%7C686ea1d3bc2b4c6fa9
> 2cd99c5
> >
> +c301635%7C0%7C0%7C638251832505905442%7CUnknown%7CTWFpbGZs
> b3d8eyJWIjoi
> >
> +MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3
> 000%7C%
> >
> +7C%7C&sdata=3DrdOyjVz4gGnToVC40Rcfp%2Fk925yC%2F6xNwGbBAnOtcDQ
> %3D&reserv
> > +ed=3D0
> > +
> > +title: Cadence MHDP8501 DP/HDMI bridge
> > +
> > +maintainers:
> > +  - Sandor Yu <Sandor.yu@nxp.com>
> > +
> > +description:
> > +  Cadence MHDP8501 DisplayPort/HDMI interface.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - cdns,mhdp8501
> > +      - fsl,imx8mq-mhdp8501
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +    description: MHDP8501 DP/HDMI APB clock.
> > +
> > +  phys:
> > +    maxItems: 1
> > +    description:
> > +      phandle to the DisplayPort or HDMI PHY
> > +
> > +  interrupts:
> > +    items:
> > +      - description: Hotplug cable plugin.
> > +      - description: Hotplug cable plugout.
> > +
> > +  interrupt-names:
> > +    items:
> > +      - const: plug_in
> > +      - const: plug_out
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          Input port from display controller output.
> > +      port@1:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description:
> > +          Output port to DisplayPort or HDMI connector.
> > +
> > +    required:
> > +      - port@0
> > +      - port@1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - interrupts
> > +  - interrupt-names
> > +  - phys
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/clock/imx8mq-clock.h>
> > +    #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > +    mhdp_dp: dp-bridge@32c00000 {
>
> I'm not sure, but I would name this node just 'bridge', because it can be=
 either
> DP or HDMI depending on the connector. But DT folks will know better than
> me.
This name should update too after DP and HDMI driver combined.
I will change to "mhdp: mhdp-bridge@32c00000" in the next version.
B.R
Sandor
>
> Best regards,
> Alexander
>
> > +        compatible =3D "fsl,imx8mq-mhdp8501";
> > +        reg =3D <0x32c00000 0x100000>;
> > +        interrupts =3D <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
> > +                     <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> > +        interrupt-names =3D "plug_in", "plug_out";
> > +        clocks =3D <&clk IMX8MQ_CLK_DISP_APB_ROOT>;
> > +        phys =3D <&dp_phy>;
> > +
> > +        ports {
> > +            #address-cells =3D <1>;
> > +            #size-cells =3D <0>;
> > +
> > +            port@0 {
> > +                reg =3D <0>;
> > +
> > +                mhdp_in: endpoint {
> > +                    remote-endpoint =3D <&dcss_out>;
> > +                };
> > +            };
> > +
> > +            port@1 {
> > +                reg =3D <1>;
> > +
> > +                mhdp_out: endpoint {
> > +                    remote-endpoint =3D <&dp_connector>;
> > +                };
> > +            };
> > +        };
> > +    };
>
>
> --
> TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht M=FCnchen, HRB 105018
> Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
> http://www.tq/
> -group.com%2F&data=3D05%7C01%7CSandor.yu%40nxp.com%7C603a90f3f3c3
> 4d32a1e708db86a8f868%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C
> 0%7C638251832505905442%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4w
> LjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C
> %7C%7C&sdata=3Dm1JbdOzu8sx6h6fP2Q8OpyLAmvpguKFUj6ddCSB3OCs%3D&
> reserved=3D0
>