Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <045fe36e-ed5b-2b02-a40d-c185796464b2@intel.com>
Date:   Tue, 18 Jul 2023 10:06:51 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.11.0
Subject: Re: [RFC PATCH v2 3/3] mm: mlock: update mlock_pte_range to handle
 large folio
Content-Language: en-US
From:   Yin Fengwei <fengwei.yin@intel.com>
To:     Yu Zhao <yuzhao@google.com>
CC:     <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
        <akpm@linux-foundation.org>, <willy@infradead.org>,
        <david@redhat.com>, <ryan.roberts@arm.com>, <shy828301@gmail.com>
References: <20230712060144.3006358-1-fengwei.yin@intel.com>
 <20230712060144.3006358-4-fengwei.yin@intel.com>
 <CAOUHufYef--8MxFettL6fOGjVx2vyZHZQU6EEaTCoW0XBvuC8Q@mail.gmail.com>
 <CAOUHufZ6=9P_=CAOQyw0xw-3q707q-1FVV09dBNDC-hpcpj2Pg@mail.gmail.com>
 <40cbc39e-5179-c2f4-3cea-0a98395aaff1@intel.com>
 <CAOUHufZHyEvU-c2O6B6stM_QVMxc22zV4Szn52myYqjdZvptUA@mail.gmail.com>
 <d93030e9-938e-f394-8067-a7307f6acd30@intel.com>
In-Reply-To: <d93030e9-938e-f394-8067-a7307f6acd30@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm82SU91Zlp4WXgvSjVQVnkrVXYrMUpONU9ZVitzMFhQdDQ1R3drWGdJQ3dl?=
 =?utf-8?B?aTRZcm82YjRXL0dVVWZhYWNwT2tBWjlKdFFlSlhHUEQ4QThYYkxMenlReStN?=
 =?utf-8?B?VUNDS1U4SWFVa1RvWHdtN3BMYnZMT2E3TVk1UFRsNGsrUE0wdUVVczRGUW5W?=
 =?utf-8?B?YW9CaWg2dG5veTNIZWtUYWM4MWxBTnkyLzNLYW5pY3BRS0VVb0tGb05EOUc4?=
 =?utf-8?B?R3pGTDVXWXBMMkNWS1pOUnBSbDNIMGt4S096NGNKVHpjTzhkOFlWc1M4REFC?=
 =?utf-8?B?a2tEdENCeXA1bXdaYVlzOWNuUjEzQW5wR3BGYURMcFQ1aTExaXNHdXVDMzBx?=
 =?utf-8?B?MG8zTmZIT3IvK1BHdFhaOWlyall1bEZudmg5dVJQMVkrZ1BLRDJtNVcrT1Ax?=
 =?utf-8?B?WVpObFluenVuWEhDZy9SeEEwcTl6bDEzNldIMGFoMXRZWk1BZExqWUNSY3pi?=
 =?utf-8?B?RXZRVDJKVEF1cVZvSVV4R3NOUEVQcU9ZbGZZblVBMnZVYitpY1YxWk9rT3dv?=
 =?utf-8?B?c3JxVTF0dHBoZmR4bm5na2pqU1pSOFdMcDkzeTRlVFBkZ1NiQmtZZ29DUjV1?=
 =?utf-8?B?NDNyK1BQeWdTYUJiaGh0ZGh6OGJQRTRYTVcxUkFTbUl6KzA1aE5nZnExVkpN?=
 =?utf-8?B?NGtTQjlEdVhkRUQvMDZNM0FUV3plSXpoWS9mY3hUd1h0M0JJSTJrYVdUaDNU?=
 =?utf-8?B?YU5lWFJQNGR2d3pxeXp3MGRONkNkUE1qSDA3dnpvdDV1Z2h3S2xtWHVWTHZk?=
 =?utf-8?B?Nzc0Qmx6dk9qQTB6TytNOUoyVmZHb2Q2OU9tbS81YnNQU252c3ZreUhmZ0x5?=
 =?utf-8?B?c0h5VGlMTTJ2VUtWS2QvS1ppKzFiWjlqblA4MmtrbklrRDAveXNORkVSbDdL?=
 =?utf-8?B?c25kN01SNFNFRE5lOWc1Zk5ZSmcwdmNMRlVXRkdtR2FVNStCelNUZXRyc3Vt?=
 =?utf-8?B?bXpKWE44SjVvS0grUHBGcnhidXlDVTB1N3Uva21jKzIwZzByVUlCK25wc1d4?=
 =?utf-8?B?R0gzemdQQ2RyUW1HTUNGck1nZ1RFYjZ6S1kvWWg5OHh3UlYrSWhQNjhaZ2xN?=
 =?utf-8?B?QmdRNTBVVHNHMGlUQWpwSUU5d0phc05qQVlERzZlZ0EwQTlWUWxEZXdGM1BJ?=
 =?utf-8?B?anNGMkZzaWxYemMxdlFuQ05lRzZIZzRLcjBDbVRsaVpsZU42QVFVODk0OHZD?=
 =?utf-8?B?bVlYVERVRWRCWEtydmpjTHZPNHRNUE1PL2RrbHkxc1R5R0czb2dGamRtVStV?=
 =?utf-8?B?d3FISUR4T3pGQnlucjd1dlJvV3doRHBNRENJRmRoV2xYTnlhTG80bGFYaFlU?=
 =?utf-8?B?OVpmREQ4SWJscjJjUFhQalpXcG45dkVycE8zdkpMMjB6VkE3Wi9HSmxmUUlz?=
 =?utf-8?B?QmtSMTFnNXpPUzZ6TTl6c0VhcG5sR2U2V1lYUGRkUTQ0QjJZNHpDMi9YaExX?=
 =?utf-8?B?ZXV0U1N5clp6dlRONnNrTVJHQXdWd3RrcTg3MGdSekw3amNpcG9wTzQra044?=
 =?utf-8?B?YU5QV2xvZnVsRXZZVGs5Mlhkbmw2bWZxWVpPR3dPS1d0OXYyUUkzcUZsaXN2?=
 =?utf-8?B?Sk1CbndiWG9TN2NyVTlNZjc1MjFrVXdmSyt5Vkc0eGRDOEVxRnNsamx3OUFR?=
 =?utf-8?B?VE5RYk5VSC83MlRJdGpaZGpLZFUySkNzK1VFcGhhVEhRU2dzeXBCbUhERCs0?=
 =?utf-8?B?c2V4aGlnT3J6alRnRnE2WDYzRW9YKzVvczFKWmhBbXVnV0tqdjl4NGpyNHA2?=
 =?utf-8?B?dzgvc0p3ejFHWEVOV0hiSmtEQi9CTW5tZDVXajFNbE55dGYrcy9xZnF2ajlQ?=
 =?utf-8?B?Q0ljdHVaZmpUOGhsRndWMmRpZVNaUHBuZW1zdVJqUmpFNlk1S1dBZUppTW9k?=
 =?utf-8?B?YkNvTmQ5eVIyak84NExXV0Z5NThsV3pLbHZXaXAwYzFGdFRiRjlZYTFnNk9i?=
 =?utf-8?B?bFVkSVE4M2l0YjBqTUZLMVNPSnZDRlpIUUR6bXlpZHZxYUdBeTdzaWFaTWVN?=
 =?utf-8?B?NU45L2lQL0I1T1Rocmk4em5aT2dVM01TM3lVMEF5aFNvSExYYjJpOTk4aDJR?=
 =?utf-8?B?STZRdElvYzlBTE5UQk5NRUgwUDAxR0Y4VE9OQTlBd2NqNkFrOW94T2NYQ3Vq?=
 =?utf-8?B?ampwWkZ4WUFNN0lEU1VLSGN4NVFTYjJhSE9rRC9Sa2J0VlEwWWJwYk5hRE85?=
 =?utf-8?B?bmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 8e4fa280-85d8-472d-ef7d-08db8733a574
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 02:06:49.4423
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eRXnrkThyZx90uC//fkubKmVDHlx6XfbHg4wcpMoFKoHeLpsIW0Iwu+dMJ6xxDyQg5iVYZUsB9wbQjXqGxgjQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5044
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/17/23 16:12, Yin Fengwei wrote:
> 
> 
> On 7/17/23 08:35, Yu Zhao wrote:
>> On Sun, Jul 16, 2023 at 6:00 PM Yin, Fengwei <fengwei.yin@intel.com> wrote:
>>>
>>> On 7/15/2023 2:06 PM, Yu Zhao wrote:
>>>> There is a problem here that I didn't have the time to elaborate: we
>>>> can't mlock() a folio that is within the range but not fully mapped
>>>> because this folio can be on the deferred split queue. When the split
>>>> happens, those unmapped folios (not mapped by this vma but are mapped
>>>> into other vmas) will be stranded on the unevictable lru.
>>>
>>> This should be fine unless I missed something. During large folio split,
>>> the unmap_folio() will be migrate(anon)/unmap(file) folio. Folio will be
>>> munlocked in unmap_folio(). So the head/tail pages will be evictable always.
>>
>> It's close but not entirely accurate: munlock can fail on isolated folios.
> 
> I suppose normal 4K page can hit this problem also and following patch could
> fix it:
No. This patch is not necessary as unevictable folio will not be picked up by
page reclaim. It's not possible to munlock the isolated folio from lru list.

The possible cases I am ware are: page_migrate, madvise and damon_pa_pageout and
lru_gen_look_around. The first three already handle this case correctly by call
  folio_putback_lru().

If folio is isolated, the split_folio() will just fail. So looks we are fine
for this corner case. Let me know if I miss something here.


Regards
Yin, Fengwei

> 
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index 1080209a568bb..839b8398aa613 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -2498,7 +2498,7 @@ static unsigned int move_folios_to_lru(struct lruvec *lruvec,
>  
>                 VM_BUG_ON_FOLIO(folio_test_lru(folio), folio);
>                 list_del(&folio->lru);
> -               if (unlikely(!folio_evictable(folio))) {
> +               if (unlikely(!folio_evictable(folio) || folio_test_unevictable(folio))) {
>                         spin_unlock_irq(&lruvec->lru_lock);
>                         folio_putback_lru(folio);
>                         spin_lock_irq(&lruvec->lru_lock);
> @@ -2723,7 +2723,7 @@ static void shrink_active_list(unsigned long nr_to_scan,
>                 folio = lru_to_folio(&l_hold);
>                 list_del(&folio->lru);
>  
> -               if (unlikely(!folio_evictable(folio))) {
> +               if (unlikely(!folio_evictable(folio) || folio_test_unevictable(folio))) {
>                         folio_putback_lru(folio);
>                         continue;
>                 }
> @@ -5182,7 +5182,7 @@ static int evict_folios(struct lruvec *lruvec, struct scan_control *sc, int swap
>         sc->nr_reclaimed += reclaimed;
>  
>         list_for_each_entry_safe_reverse(folio, next, &list, lru) {
> -               if (!folio_evictable(folio)) {
> +               if (!folio_evictable(folio) || folio_test_unevictable(folio)) {
>                         list_del(&folio->lru);
>                         folio_putback_lru(folio);
>                         continue;
> 
> 
> 
> Regards
> Yin, Fengwei
>