Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liu Ying <victor.liu@nxp.com>
To:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc:     andrzej.hajda@intel.com, neil.armstrong@linaro.org,
        rfoss@kernel.org, Laurent.pinchart@ideasonboard.com,
        jonas@kwiboo.se, jernej.skrabec@gmail.com, airlied@gmail.com,
        daniel@ffwll.ch, Ulf Hansson <ulf.hansson@linaro.org>
Subject: [PATCH v2] drm/bridge: panel: Add a device link between drm device and panel device
Date:   Tue, 18 Jul 2023 10:38:03 +0800
Message-Id: <20230718023803.2157021-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x7HWZWwMCDSD+wLBekoYbJqI2sUYhmA6VMrW+PCS4g8R6ljTAF6LtkHiYw/G?=
 =?us-ascii?Q?UmLrnszuEmNgEn3PVwfmtID9DowKYk36Y0neuAm09OzZ6amyFPfK2ZGzXHf1?=
 =?us-ascii?Q?p4IsBReL8GGNejXYzieiUWx+9/Tcwd8/XToeyucFmttDYL7DlNi6405IL9tF?=
 =?us-ascii?Q?E3BA/VZMgXyZ9EuSTMhNDCiGtMVhY4zpLjHehZQ4jTv6eURa12c/Q/WsE1Cu?=
 =?us-ascii?Q?dTvokvsq9GcXN5wTJtw8DT1G6hSrX1fXwW+YeDYRtyKSQFrtcyQof8fhI7rV?=
 =?us-ascii?Q?I9mxcodtxDgSD20zz7McwAwaHw9JXPzhqD5CFTCuG764o1JBb0zFXz1QSdbh?=
 =?us-ascii?Q?Ju+y/z8rZoA4RMlr26oNDpX2hSKfoAtd2ug28+nsS77sZD4y2NEWLCZzNEQm?=
 =?us-ascii?Q?TtFZ67/AxFZPPyCY1XeIiJA1ruUIXrVW0zyJ3iz+0T2QYS9ryzL5rT9VFppf?=
 =?us-ascii?Q?BqpCozvdYb2f3Szz0OoQsbcKJ1jMxPbmq+QVMFy14hD03I+QiST1cQVk3NIP?=
 =?us-ascii?Q?Jp9giFqN+xqxFR9aKPAIWY+NbLp3H4iLnl8N+Czy6SwtYbg1qN4qUu2pKEpE?=
 =?us-ascii?Q?sqVq4LZ1acE40pDHtS2My7mhyX0/nzah7YbQvLA7MfwJ3NlUQzZJ+njga2jT?=
 =?us-ascii?Q?ARWft2w0+fvpalkKl1VuAHO00FciDPWqRSN+RtPU7nqYo6MJ/vXZ29vnoumV?=
 =?us-ascii?Q?7OHVB7fCAi9lrn0hCAsiMx0n2gvDGL506Y+F/R+pKU53a4YZ/v8+jQVMwTkw?=
 =?us-ascii?Q?aQ2sfMSEtPBaL6GPdvX8q7Ws0W7jmdamP1xIOnsiM8CZDqdfJ++wHtXLy1aq?=
 =?us-ascii?Q?gup4nqVlDv3LzZLqolVZsHzmOEwYl/Fctg9a7LSQBHhp1aKsz9lfqn72r0zZ?=
 =?us-ascii?Q?8hVALwGpcocX8O3xZP9Qx/MkRRoRbLzs0LtCgLaJPTUK2rZYWZNuRCc2mOlt?=
 =?us-ascii?Q?w/pY2uUxveyuG0YGCCYg0DfuWVJgILft75pTN3DNe1DFhsRXLDeyqbmKy/2+?=
 =?us-ascii?Q?zTtp9eDkRv5pXvTSU2K1gdoqoon+9dn2hpgqAZpnJvK7x70wpOpyboFrQL89?=
 =?us-ascii?Q?qtojpty/I9gaqWevFT8pvkmDbtZ0BIDRqLmQ3h9kR6eZaSb230G3pigTIZws?=
 =?us-ascii?Q?SPQkii2dpsWBb7kTTV+StW7OEiJPO0dJvR+5o2qST1bkPqg/pbaiA+FbhNMh?=
 =?us-ascii?Q?DC711yK9LF4MZMlx0kQhHdjJFr0vk3/xy0IJ77eTrBP3LfBukpYBDaa5k6zS?=
 =?us-ascii?Q?epE4hCRgo9Fodx+hX1Vt9/hotm9zDcMTl980qRht318/Ojlp4SlL4YQg5bKG?=
 =?us-ascii?Q?n8gK6vKasyBNYVX+83z16A8wU+9ALMEZJICs4T0u81+sMrLs1NXyF4SrgVI0?=
 =?us-ascii?Q?ngQGd5cS6GevinS/jd/OZsXPxeTBtOuaidWycXE5Ad3BqJ4oxW3EL1JFg0pT?=
 =?us-ascii?Q?wQv7YWTCcVuAFZCmLx6l5hPw6D3ALTZJiz/rY89FMP6iTG9MqBECw61JfQbn?=
 =?us-ascii?Q?/aX2P9CfT0rEE7OeqDTQIcaYL+Ney+BcMBpMBxQPbbwOJK4Jcnjr5CjiVXRC?=
 =?us-ascii?Q?8B8lKPFE3R85+Uv5ZMpcRM9YfSZOfUZN+YAfcqod?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 11058cbb-e523-4daa-1448-08db87375a31
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 02:33:21.1888
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AGE+jeGzDJWmVwBLr/3evewRbQu9tEKwVFpg6swC2LVdqzbXoufKGMNtFAvU/ZsLwC0ZYooCYJPaWkcwg7F/wg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7680
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add the device link when panel bridge is attached and delete the link
when panel bridge is detached.  The drm device is the consumer while
the panel device is the supplier.  This makes sure that the drm device
suspends eariler and resumes later than the panel device, hence resolves
problems where the order is swapped, like the problematic case mentioned
in the below link.

Link: https://lore.kernel.org/lkml/CAPDyKFr0XjrU_udKoUKQ_q8RWaUkyqL+8fV-7s1CTMqi7u3-Rg@mail.gmail.com/T/
Suggested-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
v1->v2:
* Fix bailout for panel_bridge_attach() in case device_link_add() fails.

 drivers/gpu/drm/bridge/panel.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
index 9316384b4474..a6587d233505 100644
--- a/drivers/gpu/drm/bridge/panel.c
+++ b/drivers/gpu/drm/bridge/panel.c
@@ -4,6 +4,8 @@
  * Copyright (C) 2017 Broadcom
  */
 
+#include <linux/device.h>
+
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
 #include <drm/drm_connector.h>
@@ -19,6 +21,7 @@ struct panel_bridge {
 	struct drm_bridge bridge;
 	struct drm_connector connector;
 	struct drm_panel *panel;
+	struct device_link *link;
 	u32 connector_type;
 };
 
@@ -60,6 +63,8 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
 {
 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
 	struct drm_connector *connector = &panel_bridge->connector;
+	struct drm_panel *panel = panel_bridge->panel;
+	struct drm_device *drm_dev = bridge->dev;
 	int ret;
 
 	if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
@@ -70,6 +75,14 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
 		return -ENODEV;
 	}
 
+	panel_bridge->link = device_link_add(drm_dev->dev, panel->dev,
+					     DL_FLAG_STATELESS);
+	if (!panel_bridge->link) {
+		DRM_ERROR("Failed to add device link between %s and %s\n",
+			  dev_name(drm_dev->dev), dev_name(panel->dev));
+		return -EINVAL;
+	}
+
 	drm_connector_helper_add(connector,
 				 &panel_bridge_connector_helper_funcs);
 
@@ -78,6 +91,7 @@ static int panel_bridge_attach(struct drm_bridge *bridge,
 				 panel_bridge->connector_type);
 	if (ret) {
 		DRM_ERROR("Failed to initialize connector\n");
+		device_link_del(panel_bridge->link);
 		return ret;
 	}
 
@@ -100,6 +114,8 @@ static void panel_bridge_detach(struct drm_bridge *bridge)
 	struct panel_bridge *panel_bridge = drm_bridge_to_panel_bridge(bridge);
 	struct drm_connector *connector = &panel_bridge->connector;
 
+	device_link_del(panel_bridge->link);
+
 	/*
 	 * Cleanup the connector if we know it was initialized.
 	 *
-- 
2.37.1