Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Suman Ghosh <sumang@marvell.com>
To:     Leon Romanovsky <leon@kernel.org>
CC:     Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>,
        Hariprasad Kelam <hkelam@marvell.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "edumazet@google.com" <edumazet@google.com>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "pabeni@redhat.com" <pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [net-next PATCH V2] octeontx2-af: Install TC filter
 rules in hardware based on priority
Thread-Topic: [EXT] Re: [net-next PATCH V2] octeontx2-af: Install TC filter
 rules in hardware based on priority
Thread-Index: AQHZuBLReDSByAA8QUue4atz53QeTq+9dC2AgAF8r4A=
Date:   Tue, 18 Jul 2023 04:32:25 +0000
Message-ID: <SJ0PR18MB5216555C87CD36768503D923DB38A@SJ0PR18MB5216.namprd18.prod.outlook.com>
References: <20230716182442.2467328-1-sumang@marvell.com>
 <20230717054725.GB9461@unreal>
In-Reply-To: <20230717054725.GB9461@unreal>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Q0tUr3rkyeogcKVoCP4160OPYpT7GtpRXWuyedjUSLE6N4n7cuulYJ5wOqXb?=
 =?us-ascii?Q?7jvWGw11oyugybB3wunnFiCXx/Uar4Q+d7XQQ/Zh8IuHflLXQAX+p9Wp2RjT?=
 =?us-ascii?Q?cwk4uxNF19KzAdKvJXNsdKfrSp5bIF4ucZ6Gy40DrBnY0YGyKypzYyWe/GWb?=
 =?us-ascii?Q?K2rEpAk/Sad3Zvcd1LhQf9jNOQEj88HF8Sjx1yi8sm3y+cly+VK+Iz/Tt99/?=
 =?us-ascii?Q?PRkeEA62M5c6ke3DBQazv3i8pg+XZdDBJu9t7iwh4bWijGNawKxcyZYdHzj7?=
 =?us-ascii?Q?VdNo7nWigSlB1Rq9m0szdijzPUbcsXG67svQtu98Ty3P2vXMB4YIxRkHq4u+?=
 =?us-ascii?Q?zzOMOtk+SsziCcAmI7p3pBgTUz1M6wBkGhA0kPpmOUGFt7wRibRY6WTfhn9y?=
 =?us-ascii?Q?Ca9DLvGugWakUOKQ3Ksck0QOZqW7DUcc2hSbh+maweJfa3vlANxXyaVmEqm5?=
 =?us-ascii?Q?DTnSTPOIXdFQMvepwgU4gABi0CopI5I7Tpg6TDfUo8g4/Nrnh4DEhpYr24Ig?=
 =?us-ascii?Q?8DSmdhkU82HGkKMCrNZbgAvDCifg1SX5O66CgeG9Egx5Vh7hSaGTAHLpKLXM?=
 =?us-ascii?Q?L6nSmK30kdcIPf3N0CDuNITnCGEVslkITcMTA5XZC1ZMtwhwvlDbG18mgVJo?=
 =?us-ascii?Q?H0N/R36cyb4slxzYwmC1+bnJOr8wvsR2jL7Bi9ef1UXYNVQ9FOZnyx76Y6Dg?=
 =?us-ascii?Q?Pn+njf/uqHUUnYoensPXjGPrzZ0QZ/GiMomwXdRC6ntY9HAc7qxXYLSpovdX?=
 =?us-ascii?Q?DoOHXkDtA1U/b6O9o3PipXFB/UqE+lJMmNICeSf5bkgq5igDjPXu2Nsj4UUu?=
 =?us-ascii?Q?TxHLZwJXdieExypbJRNF33ct66Awa10u1WGWJGdD5lY/RgvHCQ1m2m27PZ02?=
 =?us-ascii?Q?qrIRtgLH5SjUP/AcgDvpKGvbgC+QbeqS+E7dg0gjt1ZGSBNwjuZFjnxSn8kk?=
 =?us-ascii?Q?VkQl6o5CpQ0exbCd81PlCMov4LCEh7NbPd5vRz7cXiv1+wbValVMmca0s0lH?=
 =?us-ascii?Q?a8hs8/x4n2Ksew0UcEwM8/BVvjg1F8F1uSGJHKDNTOzJYf+bRDYgcDorQ+qk?=
 =?us-ascii?Q?/zW1INqo9TD/h+5ImOML/SKovOXQPDD8DWd+VUX24iKKixAG20sdUnQY/4DT?=
 =?us-ascii?Q?iF2jyUCg3T92HjAspTm4nXsgrGUSljUcVzDCFO9ww4+eg2aVNyG6n4P7ay0h?=
 =?us-ascii?Q?HzcCR3qYK5UdCcvHr1jqwh9my9IcNXJHm/tpVayRLpiMo/pOEoZFctcc/ooA?=
 =?us-ascii?Q?eMsOsVwIsLIyX2jrr4IdtbfEsqx2G2hj8dj7b156ro+zmJAw002kEKqzXBMx?=
 =?us-ascii?Q?lYwfMk/Yf6xvlXQTjkz2FVIOX2ai00eZ3uRB6u/gqDlUTTtLxYsbTPmJ0RvJ?=
 =?us-ascii?Q?vs2l2ZPy+XSqsFF1LFToH44ECi+GlIvh3g7c4dqwuK/v31T+I0jscAhOOfYB?=
 =?us-ascii?Q?1Eic8bETFVFh4D59SkO3TnS2d5q5xhOfNfTAcL4Y/Z69HD878pdGgYB0N5TO?=
 =?us-ascii?Q?5cF0ATcvuzLufuX62MelOfRq5eYOs92k9mgdosesT5JHp/eqSXvRUsqk/25H?=
 =?us-ascii?Q?BwqSjAVRtzVT5PMtCvk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR18MB5216.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6e2baeab-b8f9-4725-f0b8-08db8747fcff
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2023 04:32:25.9985
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j3vtWv4zHlEY3dRpFWYytTxsLFNvSmsvoiFZ/bMnJwVCXx/lronpgeJBMxQ+57SJzSAeL0T67LYUrEDKLazWlA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR18MB4252
X-Proofpoint-GUID: _Nx5BVenB-3jrkmMqYdSFyP57lSzlMkd
X-Proofpoint-ORIG-GUID: _Nx5BVenB-3jrkmMqYdSFyP57lSzlMkd
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26
 definitions=2023-07-17_15,2023-07-13_01,2023-05-22_02
X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>On Sun, Jul 16, 2023 at 11:54:42PM +0530, Suman Ghosh wrote:
>> As of today, hardware does not support installing tc filter rules
>> based on priority. This patch fixes the issue and install the hardware
>> rules based on priority. The final hardware rules will not be
>> dependent on rule installation order, it will be strictly priority
>> based, same as software.
>>
>> Signed-off-by: Suman Ghosh <sumang@marvell.com>
>> ---
>> Changes since v1:
>> - Rebased the patch on top of current 'main' branch
>>
>>  .../net/ethernet/marvell/octeontx2/af/mbox.h  |   9 +-
>>  .../marvell/octeontx2/af/rvu_npc_fs.c         |   9 +-
>>  .../marvell/octeontx2/af/rvu_switch.c         |   6 +-
>>  .../marvell/octeontx2/nic/otx2_common.h       |  11 +-
>>  .../marvell/octeontx2/nic/otx2_devlink.c      |   1 -
>>  .../marvell/octeontx2/nic/otx2_ethtool.c      |   1 +
>>  .../marvell/octeontx2/nic/otx2_flows.c        |   2 +
>>  .../ethernet/marvell/octeontx2/nic/otx2_tc.c  | 313
>> +++++++++++++-----
>>  8 files changed, 248 insertions(+), 104 deletions(-)
>
><...>
>
>> +static void otx2_tc_del_from_flow_list(struct otx2_flow_config
>*flow_cfg,
>> +				       struct otx2_tc_flow *node)
>>  {
>> +	struct otx2_tc_flow *tmp;
>> +	struct list_head *pos, *n;
>
>Please declared variables in rversed Christmas tree, in all places,
>thanks.
[Suman] Ack, will update in v3 patch.
>
>> +
>> +	list_for_each_safe(pos, n, &flow_cfg->flow_list_tc) {
>> +		tmp =3D list_entry(pos, struct otx2_tc_flow, list);
>> +		if (node =3D=3D tmp) {
>> +			list_del(&node->list);
>> +			return;
>> +		}
>> +	}
>> +}
>> +
>> +static int otx2_tc_add_to_flow_list(struct otx2_flow_config
>*flow_cfg,
>> +				    struct otx2_tc_flow *node)
>> +{
>> +	struct otx2_tc_flow *tmp;
>> +	struct list_head *pos, *n;
>> +	int index =3D 0;
>
>Ditto.
[Suman] Ack, will update in v3 patch.
>
>> +
>
><...>
>
>> +static int otx2_del_mcam_flow_entry(struct otx2_nic *nic, u16 entry,
>> +u16 *cntr_val) {
>> +	struct npc_delete_flow_rsp __maybe_unused *rsp;
>
>Why __maybe_unused? This keyword is usually used when in some CONFIG_*
>option, it won't be used. It is not the case here.
[Suman] Ack, not needed her. Will update in v3 patch
>
>>  	struct npc_delete_flow_req *req;
>>  	int err;
>
><...>
>
>> +	ntuple =3D !!(nic->netdev->features & NETIF_F_NTUPLE);
>
>No need in !! for bool variables.
[Suman] Ack, will update in v3 patch.
>
>Thanks