Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <72c44b42-0ed3-9eea-22dc-4b35b24c8ba7@linaro.org>
Date:   Tue, 18 Jul 2023 08:48:36 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.13.0
Subject: Re: [PATCH] KVM: x86: Fix error & warning in i8254.h
Content-Language: en-US
To:     shijie001@208suo.com, tglx@linutronix.de, mingo@redhat.com,
        bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org
Cc:     hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        seanjc@google.com, pbonzini@redhat.com
References: <tencent_EA89B0582F8F8C3CC33C9F7AE407FC956F09@qq.com>
 <f1a0806ffdb74240f9bfbba9f4ece732@208suo.com>
From:   =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@linaro.org>
In-Reply-To: <f1a0806ffdb74240f9bfbba9f4ece732@208suo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/7/23 08:02, shijie001@208suo.com wrote:
> The following checkpatch error & warning are removed:
> WARNING: please, no space before tabs
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
>   arch/x86/kvm/i8254.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)


>       struct mutex lock;
> @@ -52,7 +52,7 @@ struct kvm_pit {
>   #define KVM_SPEAKER_BASE_ADDRESS    0x61
>   #define KVM_PIT_MEM_LENGTH        4
>   #define KVM_PIT_FREQ            1193181
> -#define KVM_MAX_PIT_INTR_INTERVAL   HZ / 100
> +#define KVM_MAX_PIT_INTR_INTERVAL   (HZ / 100)

This looks like dead code, maybe better just remove?

>   #define KVM_PIT_CHANNEL_MASK        0x3
> 
>   struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags);