Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230711091155.2216848-1-wenst@chromium.org> <CAD=FV=UW=VrrCB8Ko7ysWTia--hG6t+4BmRwodY=nkL=DyP6CQ@mail.gmail.com>
In-Reply-To: <CAD=FV=UW=VrrCB8Ko7ysWTia--hG6t+4BmRwodY=nkL=DyP6CQ@mail.gmail.com>
From:   Chen-Yu Tsai <wenst@chromium.org>
Date:   Tue, 18 Jul 2023 14:36:59 +0800
Message-ID: <CAGXv+5Fu1JR_9Mjn+hQNnh+iZYL6D9u=KM4AuAKEkSW3JTNxhQ@mail.gmail.com>
Subject: Re: [PATCH] drm/panel-edp: Add AUO B116XAB01.4 (HW:0A) panel entry
To:     Doug Anderson <dianders@chromium.org>
Cc:     Neil Armstrong <neil.armstrong@linaro.org>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 18, 2023 at 5:40=E2=80=AFAM Doug Anderson <dianders@chromium.or=
g> wrote:
>
> Hi,
>
> On Tue, Jul 11, 2023 at 2:12=E2=80=AFAM Chen-Yu Tsai <wenst@chromium.org>=
 wrote:
> >
> > This panel is found at least on the MT8183-based Juniper Chromebook,
> > also known as the Acer Chromebook Spin 311. It matches the common
> > delay_200_500_e50 set of delay timings.
> >
> > Add an entry for it.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> >  drivers/gpu/drm/panel/panel-edp.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/=
panel-edp.c
> > index fbd114b4f0be..df7e3cff004c 100644
> > --- a/drivers/gpu/drm/panel/panel-edp.c
> > +++ b/drivers/gpu/drm/panel/panel-edp.c
> > @@ -1866,6 +1866,7 @@ static const struct panel_delay delay_200_500_e20=
0 =3D {
> >   */
> >  static const struct edp_panel_entry edp_panels[] =3D {
> >         EDP_PANEL_ENTRY('A', 'U', 'O', 0x1062, &delay_200_500_e50, "B12=
0XAN01.0"),
> > +       EDP_PANEL_ENTRY('A', 'U', 'O', 0x145c, &delay_200_500_e50, "B11=
6XAB01.4"),
> >         EDP_PANEL_ENTRY('A', 'U', 'O', 0x1e9b, &delay_200_500_e50, "B13=
3UAN02.1"),
> >         EDP_PANEL_ENTRY('A', 'U', 'O', 0x1ea5, &delay_200_500_e50, "B11=
6XAK01.6"),
> >         EDP_PANEL_ENTRY('A', 'U', 'O', 0x405c, &auo_b116xak01.delay, "B=
116XAK01"),
>
> You're about 1 month too late. ;-) This landed in drm-misc-next as
> commit 1ebc9f0365ef ("drm/panel-edp: Add AUO B116XAB01.4 edp panel
> entry").
>
> You can find it on drm-misc-next: https://cgit.freedesktop.org/drm/drm-mi=
sc/log/
>
> Specifically see:
> https://cgit.freedesktop.org/drm/drm-misc/commit/?id=3D1ebc9f0365ef

Argh, you're right. I vaguely remember it. I was on v6.5-rc1 when I sent
this.

ChenYu
> -Doug