Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <843b7912-4e99-652a-ef3f-9fbb231c4c65@ideasonboard.com>
Date:   Tue, 18 Jul 2023 10:06:01 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH -next] media: i2c: No need to set device_driver owner
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     mchehab@kernel.org, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
References: <20230718010154.36550-1-yang.lee@linux.alibaba.com>
Content-Language: en-US
From:   Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
In-Reply-To: <20230718010154.36550-1-yang.lee@linux.alibaba.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/07/2023 04:01, Yang Li wrote:
> Remove .owner field if calls are used which set it automatically.
> 
> to silence the warning:
> ./drivers/media/i2c/ds90ub953.c:1390:3-8: No need to set .owner here.  The core will do it.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5902
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>   drivers/media/i2c/ds90ub953.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 1e3827a60029..ce1c6f8b656e 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -1387,7 +1387,6 @@ static struct i2c_driver ds90ub953_driver = {
>   	.id_table	= ub953_id,
>   	.driver = {
>   		.name	= "ds90ub953",
> -		.owner = THIS_MODULE,
>   		.of_match_table = ub953_dt_ids,
>   	},
>   };

Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>

  Tomi