Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6541505rwp; Tue, 18 Jul 2023 01:52:33 -0700 (PDT) X-Google-Smtp-Source: APBJJlEWqH3N96dx+jmmxvDbUZ1YVALJjx6hRMhYk6mAq/Bdd8X9H6kUpp8lx8mB5BWKUnnKG2Ji X-Received: by 2002:a17:906:74d0:b0:993:d75b:63ea with SMTP id z16-20020a17090674d000b00993d75b63eamr13713073ejl.16.1689670353555; Tue, 18 Jul 2023 01:52:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689670353; cv=none; d=google.com; s=arc-20160816; b=vp+r7um2DGHLRca1x+vdQP3mu3LYSkOfahzywUWAOfzn7g9q4xOBIBCf3yq2lkVahw m7/8MmJUSYVXKlsDdIX4qhWB1CFHv2z9DYsTpsnxzzTkn6wvSE6w7FGCt8PGTmLCOiih 9aFOD+W7KEyQZPrAaRoEaf8xMk9T0JgrlWPgV3g937252NA+uf1RMkJUBuVZ5UwOAcKR LZftHhUEi8gsT/s1RxYK7iutrtOyYodzLssSNAI9wbG7Cu3b3oW3xFdiC+vOfPGXxZ46 mDA6W/JFjz1r3guNWTBIrqtLctHXqMSV46Bv8sjn62vonJHBFVpuIwjnHzfqwNtvevTF lS+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=jHVX6dfpCt8cBbZngMojdlaS/kOg+Tlc6u+V2VK9DV4=; fh=rBPDFZndP+yQg0E4rxl/zLCYvBk/FwvIyC+euv1eSXY=; b=a2dLbbpakpdYGbv5WHne7qBZVMmw67NYPIwOfxRPJSv2eJfSw+a8pm4w4cWCTYMnFX oyXK5B3+q0s4Lkh7e96f6moRZGSkjxwCJKfvoyAVJDDf8JaT5fC5Av8hsV38B0cMS/W7 /iGtSivsjjt+Ij9zn9VNdSeBXveEMU939DcL5Fn9FkeFum1I/B0WiAVxf33pGUQ1Zd+I 3W7vUBzprhY51LETctyynwnWEkKtBSfj3TOqxMPK1jqKy1mcxdjSVb/hJRsGi2ihaF0i kARzTUL74R26/fJ/XAk0AqlDfGUwlMP9EtT/0Wsrg+NHvHpabMNQgy75wPKxJ+Lt8XMp XVng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kq14-20020a170906abce00b0098d2f715b89si750151ejb.102.2023.07.18.01.52.09; Tue, 18 Jul 2023 01:52:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=xs4all.nl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbjGRIcG (ORCPT + 99 others); Tue, 18 Jul 2023 04:32:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbjGRIcE (ORCPT ); Tue, 18 Jul 2023 04:32:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EE68E7F; Tue, 18 Jul 2023 01:32:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E971A614BF; Tue, 18 Jul 2023 08:32:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1B76AC433C8; Tue, 18 Jul 2023 08:31:57 +0000 (UTC) Message-ID: <53bb24a3-6aa4-4ece-e837-2cd523e0c1e7@xs4all.nl> Date: Tue, 18 Jul 2023 10:31:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 00/14] media: rkisp1: Add support for i.MX8MP Content-Language: en-US To: Paul Elder , linux-media@vger.kernel.org Cc: Dafna Hirschfeld , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Heiko Stuebner , Helen Koike , Laurent Pinchart , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221118093931.1284465-1-paul.elder@ideasonboard.com> From: Hans Verkuil In-Reply-To: <20221118093931.1284465-1-paul.elder@ideasonboard.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,NICE_REPLY_A,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 18/11/2022 10:39, Paul Elder wrote: > This series depends on v3 of "dt-bindings: media: Add macros for video > interface bus types" [1]. > > This series extends the rkisp1 driver to support the ISP found in the > NXP i.MX8MP SoC. > > The ISP IP cores in the Rockchip RK3399 (known as the "Rockchip ISP1") > and in the NXP i.MX8MP have the same origin, and have slightly diverged > over time as they are now independently developed (afaik) by Rockchip > and VeriSilicon. The latter is marketed under the name "ISP8000Nano", > and is close enough to the RK3399 ISP that it can easily be supported by > the same driver. > > The last two patches add support for UYVY output format, which can be > implemented on the ISP version in the i.MX8MP but not in the one in the > RK3399. > > This version of the series specifically has been tested on a Polyhex > Debix model A with an imx219 (Raspberry Pi cam v2). There were comments for the first few patches, but I haven't seen a v4. I'm marking this series as 'Changes Requested' in patchwork, just so you know. Regards, Hans > > [1] https://lore.kernel.org/linux-media/20220615221410.27459-2-laurent.pinchart@ideasonboard.com/ > > Laurent Pinchart (3): > dt-bindings: media: rkisp1: Add i.MX8MP ISP example > media: rkisp1: Add and use rkisp1_has_feature() macro > media: rkisp1: Configure gasket on i.MX8MP > > Paul Elder (11): > dt-bindings: media: rkisp1: Add i.MX8MP ISP to compatible > media: rkisp1: Add match data for i.MX8MP ISP > media: rkisp1: Add and set registers for crop for i.MX8MP > media: rkisp1: Add and set registers for output size config on i.MX8MP > media: rkisp1: Add i.MX8MP-specific registers for MI and resizer > media: rkisp1: Shift DMA buffer addresses on i.MX8MP > media: rkisp1: Add register definitions for the test pattern generator > media: rkisp1: Fix RSZ_CTRL bits for i.MX8MP > media: rkisp1: Support devices without self path > media: rkisp1: Add YC swap capability > media: rkisp1: Add UYVY as an output format > > .../bindings/media/rockchip-isp1.yaml | 79 ++++++++++- > .../platform/rockchip/rkisp1/rkisp1-capture.c | 102 +++++++++++--- > .../platform/rockchip/rkisp1/rkisp1-common.h | 32 +++++ > .../platform/rockchip/rkisp1/rkisp1-debug.c | 14 +- > .../platform/rockchip/rkisp1/rkisp1-dev.c | 67 +++++++-- > .../platform/rockchip/rkisp1/rkisp1-isp.c | 128 +++++++++++++++++- > .../platform/rockchip/rkisp1/rkisp1-regs.h | 90 ++++++++++++ > .../platform/rockchip/rkisp1/rkisp1-resizer.c | 35 ++++- > include/uapi/linux/rkisp1-config.h | 2 + > 9 files changed, 509 insertions(+), 40 deletions(-) >