Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <474c0241-a58e-b435-8ac1-82a5a458d79a@nxp.com>
Date:   Tue, 18 Jul 2023 11:25:03 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 1/2] remoteproc: imx_dsp_rproc: add mandatory
 find_loaded_rsc_table op
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        "Iuliana Prodan (OSS)" <iuliana.prodan@oss.nxp.com>
Cc:     Bjorn Andersson <andersson@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        "S.J. Wang" <shengjiu.wang@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Daniel Baluta <daniel.baluta@nxp.com>,
        Mpuaudiosw <Mpuaudiosw@nxp.com>, linux-imx <linux-imx@nxp.com>,
        linux-remoteproc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        LnxRevLi <LnxRevLi@nxp.com>
References: <20230712224220.26430-1-iuliana.prodan@oss.nxp.com>
 <ZLV9gAmiDldlvIUR@p14s>
Content-Language: en-US
From:   Iuliana Prodan <iuliana.prodan@nxp.com>
In-Reply-To: <ZLV9gAmiDldlvIUR@p14s>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjY1UmJxZE0xWVY2K0dlL0VwNmh2OC9ZbkNJMVA4eWxtRTRqd0RjZzIveEhm?=
 =?utf-8?B?YXJQVUtYTm1ZVWF0QVd1SEU1NzdndGxsVWFEWEJBSnV2R0greFNhNTNnMXFZ?=
 =?utf-8?B?YVZYSVJkbzB0eTd5MXhPM1JVVlBScTYrR21CZXpoaU1WQTczdG5oWWo0MWlz?=
 =?utf-8?B?aW54Rk1jTTBITXhrUytsN0NjQk5yaVd3OVFUSmc4MFJXTHEyNEhXOWNUZkpO?=
 =?utf-8?B?c3YvaFp2bFdrdllXSUpLQjZhd2RkemJmMzJIQVdZY2JXRkpvbkJOK3pzOEdP?=
 =?utf-8?B?ekpOaW5ITDgwdVRmeUxYaFM2UmFEL3IzNTIzallvbkpyTFErK2VhUTZaTERY?=
 =?utf-8?B?M0RsSUVFenhFWFVvcnJMdU1NTUNpMlMyZDFSSjdzNC93NXdLNjc5ZEQ0YjVM?=
 =?utf-8?B?R0Y2cVNpRzNzNjEzK0VSd0ZxdVBlVlZzZnVKOGRHOEVvZTM1ZnoyeDd3RFAx?=
 =?utf-8?B?UFMyc1AwblErTW9sQ1Y5S3JOTzFXWXdFQ21URTBYeDA2UmNUY09lM0xlZlY1?=
 =?utf-8?B?WnZ6b3VEZ1R0MVpvdWE0VUUwMk13eTJkOWZKYS85YTBYRGo5aWpnOCtjMGY1?=
 =?utf-8?B?cVJKWUpLYTYwWTF1Q2kvcTJHdzd6cTFBS3dnbUpyam5vMDlOcU9MUmhETnBi?=
 =?utf-8?B?WUpFRnowM1c0UlNaekJoSC9LSlFxd1IvU2NObWxSalMvSUk5NE1adVd5eWlU?=
 =?utf-8?B?dHRvenJlajdhbUpsN0NTR3RvenBwSUtPL1JzYmIzdUFyQVozOFRGV3V1Y3h5?=
 =?utf-8?B?ZENNQkdPcDhReUNhZG1SdTQ2U1Q3cVoxWG1kRGNjR0s3RlJXRm5nUjd6SDZl?=
 =?utf-8?B?eWkwY2J3RUZ5VW5OK1pnQ3VQT1Q0MER5Z2JrZVFiK1R2VkM0Z3dBV1owclBH?=
 =?utf-8?B?bFVSbUFjT21vbnpsWGdZbDZ3ejlVUERvWFF5SDJ2NkpHTWM4SCtBYklCNElT?=
 =?utf-8?B?a0dRV2NRWnFDMEdQL0k4dzl2THZJWGVBSTFBM3hkaXJhMTVaOFE2VjNSM1Jr?=
 =?utf-8?B?T3FraEh6NWdlL1N4Y2ZPbUFydEFjeUhRVzdzbnBKYk9MUWJmQWluZzlGNjRi?=
 =?utf-8?B?K3dRT0Nyd3RwbXZwSm95L0V1R0VkN2xjT3R0Z0xtUWh1Rjk5aUQxc0tMOEt6?=
 =?utf-8?B?b2o5MnorRFFiY0d1eTBBMGU5c3hTYlhHVUhweFZiVjg0V2VQeTUvbkVyeE8v?=
 =?utf-8?B?QnZWcGpLaExBekJpWjRiVGo5QlprR05RTFFRY0FMR3FTQ0VBNjluaUYwaHBv?=
 =?utf-8?B?c3FjN1RWbDhoSGpxQ1B5SStrVzg5R0MyRS8xWGVDNW5nY0Vqdm5aOUtoTFlV?=
 =?utf-8?B?a29GWk8zZHRPYmNPNk8zRHFzQzNvcFlKM0tST3V1bWtsZkkwcFpjY0E1OWEw?=
 =?utf-8?B?YkRCSXp5NzVaSmZmeGUrSkU5dXQ2NkY1aVVYL1B0TmRwZHRBQzE0RjRLWGVL?=
 =?utf-8?B?eVRXL3pZbjB5VUhsNHgwRTUwdjVmMTZQSXNWZlZoSlRDQUtUb0hTRFBOSVdn?=
 =?utf-8?B?a29zOVVzVHZLRmRmRWZZZTk1UnhESXMvbmJBL3pjaXM4Z0R1L3JFeDNpYTI1?=
 =?utf-8?B?WHIrVjcxbnNJS3FBVXZwN0xaaCtGeGcyL0w0d3B4L1VZeDRvRy9ISXZVdjU0?=
 =?utf-8?B?ZjVNMkhPNE40eHh1NjUwdVlEaWZETEpWcnc2d24xR0MrR0t6SjRGM2o4MExO?=
 =?utf-8?B?NFZwSkJPUCtoSy9BSnZTWGFQSUJpQjAyS0pFb2FOaFdBRnRidFFqZlhCdDJY?=
 =?utf-8?B?ME1tYjZ6ekkzbE9oSkZMNzBFYmw0Ynh5U0g2cVRlVk4xQ2wxSXd6R0xURURt?=
 =?utf-8?B?S1lpWkVlMUNxdUtRYnpWWFpJNG1uY3VHUEdtNTZwSkVpenU1MHpjVFRTWGxH?=
 =?utf-8?B?NC9rSnZYY0FnV05XeVFKaVNIblJ1VnNyZkZiVUE0VVNIK1l1YmtTRzN2TzBS?=
 =?utf-8?B?VFB4UUlEblA5cFZyL2o4Tlp1RVh3UVJSL0NoZW1Ta2wzajdONHJySFBoZUdH?=
 =?utf-8?B?bWVlejJKTEtYWHJsQmdBazBVUXE0OUozd1NTSzdvY1lUc2F5TmZwNXVKWE1B?=
 =?utf-8?B?L0RCNGRWbTdsaG51TWhaZXRRM3lvZWtqbG5jTlRIdEV2UHozeGdhMnhWZENQ?=
 =?utf-8?B?UkhIYnA4MW9OYitiWXV0bUxwMkpKWUxBL0NQcVRTQ3dPR3FIMXViSlRGZWlK?=
 =?utf-8?B?QVE9PQ==?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c07ab93-610e-4d43-e675-08db87687dc9
X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8774.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 08:25:06.2328
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DpfC27EA7O6K6rv/EJnaQyAW8TojUaAYkRJkVK5USvSPvbJZW0CbPp1if/wQh3iqovsIKagaELJQl7id3C7dTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8775
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,T_SCC_BODY_TEXT_LINE,
        T_SPF_PERMERROR,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/17/2023 8:42 PM, Mathieu Poirier wrote:
> On Thu, Jul 13, 2023 at 01:42:20AM +0300, Iuliana Prodan (OSS) wrote:
>> From: Iuliana Prodan <iuliana.prodan@nxp.com>
>>
>> Add the .find_loaded_rsc_table operation for i.MX DSP.
>> We need it for inter-process communication between DSP
>> and main core.
>>
>> This callback is used to find the resource table (defined
>> in remote processor linker script) where the address of the
>> vrings along with the other allocated resources (carveouts etc)
>> are stored.
>> If this is not found, the vrings are not allocated and
>> the IPC between cores will not work.
> Is there a constraint on the system memory the M4 can address?  If so there
> will be a need to declare address ranges for vrings and buffers in reserved
> memory in the DT.
>
> Thanks,
> Mathieu

Hi Mathieu,

No, there is no constraint on memory.

We want the Cortex A core to communicate with the HiFi4 DSP.
The Cortex A is in charge of starting the DSP and loading the firmware 
in HiFi4's memory.
When using rpmsg for IPC, the Cortex A needs to find the resource table 
(defined in the DSP linker script) and this is done using 
.find_loaded_rsc_table callback.

For the DT, we are using a (not upstream) device tree where we have the 
reserved-memory for dsp_vdev0vring0, dsp_vdev0vring1 and dsp_vdev0buffer.

Iulia


>> Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
>> ---
>>   drivers/remoteproc/imx_dsp_rproc.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/remoteproc/imx_dsp_rproc.c b/drivers/remoteproc/imx_dsp_rproc.c
>> index d95fa5586189..b5634507d953 100644
>> --- a/drivers/remoteproc/imx_dsp_rproc.c
>> +++ b/drivers/remoteproc/imx_dsp_rproc.c
>> @@ -941,6 +941,7 @@ static const struct rproc_ops imx_dsp_rproc_ops = {
>>   	.kick		= imx_dsp_rproc_kick,
>>   	.load		= imx_dsp_rproc_elf_load_segments,
>>   	.parse_fw	= imx_dsp_rproc_parse_fw,
>> +	.find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table,
>>   	.sanity_check	= rproc_elf_sanity_check,
>>   	.get_boot_addr	= rproc_elf_get_boot_addr,
>>   };
>> -- 
>> 2.17.1
>>