Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20190716131005.761-1-bogdan.togorean@analog.com>
 <20230718062854.29875-1-alex@shruggie.ro> <1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com>
In-Reply-To: <1c3fde3a873b0f948d3c4d37107c5bb67dc9f7bb.camel@gmail.com>
From:   Alexandru Ardelean <alex@shruggie.ro>
Date:   Tue, 18 Jul 2023 11:35:04 +0300
Message-ID: <CAH3L5Qq5t3FgMCCF7YB7-W1R2kewz_OFFETz1NQc_K5egfps=w@mail.gmail.com>
Subject: Re: [PATCH V2] drm: adv7511: Fix low refresh rate register for ADV7533/5
To:     =?UTF-8?B?TnVubyBTw6E=?= <noname.nuno@gmail.com>
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        architt@codeaurora.org, bogdan.togorean@analog.com,
        nuno.sa@analog.com, daniel@ffwll.ch, airlied@gmail.com,
        jonas@kwiboo.se, Laurent.pinchart@ideasonboard.com,
        rfoss@kernel.org, neil.armstrong@linaro.org,
        andrzej.hajda@intel.com, festevam@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 18, 2023 at 10:00=E2=80=AFAM Nuno S=C3=A1 <noname.nuno@gmail.co=
m> wrote:
>
> On Tue, 2023-07-18 at 09:28 +0300, Alexandru Ardelean wrote:
> > From: Bogdan Togorean <bogdan.togorean@analog.com>
> >
> > For ADV7533 and ADV7535 low refresh rate is selected using
> > bits [3:2] of 0x4a main register.
> > So depending on ADV model write 0xfb or 0x4a register.
> >
> > Fixes: 2437e7cd88e8 ("drm/bridge: adv7533: Initial support for ADV7533"=
)
> > Reviewed-by: Nuno Sa <nuno.sa@analog.com>
> > Signed-off-by: Bogdan Togorean <bogdan.togorean@analog.com>
> > ---
> >
>
> It looks like you dropped your S-o-b tag in v2? I guess it was not on pur=
pose :)

oops; yes;
will send a V3;

thanks for the notification;

>
> - Nuno S=C3=A1
>
> > Changelog v1 -> v2:
> > *
> > https://lore.kernel.org/dri-devel/20190716131005.761-1-bogdan.togorean@=
analog.com/
> > * added Fixes: tag
> > * added Reviewed-by: tag for Nuno
> >
> >  drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > index ddceafa7b637..09290a377957 100644
> > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> > @@ -786,8 +786,13 @@ static void adv7511_mode_set(struct adv7511 *adv75=
11,
> >         else
> >                 low_refresh_rate =3D ADV7511_LOW_REFRESH_RATE_NONE;
> >
> > -       regmap_update_bits(adv7511->regmap, 0xfb,
> > -               0x6, low_refresh_rate << 1);
> > +       if (adv7511->type =3D=3D ADV7511)
> > +               regmap_update_bits(adv7511->regmap, 0xfb,
> > +                       0x6, low_refresh_rate << 1);
> > +       else
> > +               regmap_update_bits(adv7511->regmap, 0x4a,
> > +                       0xc, low_refresh_rate << 2);
> > +
> >         regmap_update_bits(adv7511->regmap, 0x17,
> >                 0x60, (vsync_polarity << 6) | (hsync_polarity << 5));
> >
>