Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230718080812.16801-1-xujianghui@cdjrlc.com> <98a14fa23e4fb81d4630264cba0cecc8@208suo.com>
In-Reply-To: <98a14fa23e4fb81d4630264cba0cecc8@208suo.com>
From:   Kjetil Oftedal <oftedal@gmail.com>
Date:   Tue, 18 Jul 2023 10:51:53 +0200
Message-ID: <CALMQjD-JB-53dpJ92V4tdmiD_mO0AiyDthRv8obnpw=1FtRJ1g@mail.gmail.com>
Subject: Re: [PATCH] floppy: add missing put_device()
To:     sunran001@208suo.com
Cc:     davem@davemloft.net, sparclinux@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, 18 Jul 2023 at 10:15, <sunran001@208suo.com> wrote:
>
> The of_find_device_by_node() takes a reference to the underlying device
> structure, we should release that reference.
>
> Detected by coccinelle with the following ERROR:
> ./arch/sparc/include/asm/floppy_64.h:595:3-9: ERROR: missing put_device;
> call of_find_device_by_node on line 589, but without a corresponding
> object release within this function.
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   arch/sparc/include/asm/floppy_64.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/arch/sparc/include/asm/floppy_64.h
> b/arch/sparc/include/asm/floppy_64.h
> index 070c8c1f5c8f..e74a4d4e6519 100644
> --- a/arch/sparc/include/asm/floppy_64.h
> +++ b/arch/sparc/include/asm/floppy_64.h
> @@ -592,6 +592,7 @@ static unsigned long __init sun_floppy_init(void)
>
>           state_prop = of_get_property(op->dev.of_node, "status", NULL);
>           if (state_prop && !strncmp(state_prop, "disabled", 8))
> +            put_device(&op->dev);

From the same domain as "Liubin" earlier, introducing the same kind of error
(Not adding curly braces)


>               return 0;
>
>           FLOPPY_IRQ = op->archdata.irqs[0];