Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6562660rwp; Tue, 18 Jul 2023 02:17:32 -0700 (PDT) X-Google-Smtp-Source: APBJJlG9iTw9WMoeesyVQtH/Jf70luxl8JyFrCZDzhTSrpqdIdaF+53hg7Zk0pdS0zOTkPAfATA5 X-Received: by 2002:a05:6a20:54b:b0:134:469b:a28b with SMTP id 11-20020a056a20054b00b00134469ba28bmr5259527pzq.19.1689671852103; Tue, 18 Jul 2023 02:17:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689671852; cv=none; d=google.com; s=arc-20160816; b=R+g8TI0rQy34mW6CnP6Rczx4M3XkOBuktu6MIVolDMHHId1eyC+97tpP/vt0NVPh7D 3U5O7sPOuf5X4v6Nm5xukZBN/K+W3yuGBls+QkPLMBswqhvOZIUd4sOiOfV/otfRiu3P ueSqmXHfXSCLoXfoZXR0WGWdXez2Tu6OVXAvjIef/OcfeXSgw65fEJMXnKhSYL/SRK0s PYuhqg/ACleD2d7Y07i4QCSkSt73Iheetnoc4UhD6wYlxcdCPNGvsZCAJV+91cTuzJrd Fz9TcfN3r+j+PqIRBM3yH85dnKUOT0nDT9EZJ19gDfaffkjs6iyfol62XjnraHfYyR9p 2N4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=GehVwH3Xwy/U1Jg57Nh78uC1UHEcZbVFEAIbHMC5x6g=; fh=wVYnlJkdCBQCsPBltOpwRZY1Ob8weyxSizm8alLbX9s=; b=Z4WzxLw+lO26wT+SAXYrxqFjrojjIa+y08iJj56+R3lMURXP1Grzw27vQqpkwlhy3c fOb51+LziRfxm0foEOZP/fTYCiVP/0VUUb7wAWnVkk67Q3e+YByhgEsIS3Y3VCDnL/35 4aH4Mx1051SThdGZQp46oXYzx/3SXOBpwsnC3DVGYgeOC5nLDkR/iq9bwQ7mXbgpbGwA K9zL+ygQJhToEFvsDVkY9yZ5eBMuoKfJXMvLtmqmfsVJRIhnDfB9SKP2yqNJrFEqELiA O7tuxE7xVRk20+bck3Cs0h4D1vYRFWOl6wAJQsYHJ5Bz+s40j/+8dIhgapHpfahtEJUc A4Eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f20-20020a056a00239400b0068270404171si1228985pfc.208.2023.07.18.02.17.19; Tue, 18 Jul 2023 02:17:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232107AbjGRIyh (ORCPT + 99 others); Tue, 18 Jul 2023 04:54:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38182 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232052AbjGRIyS (ORCPT ); Tue, 18 Jul 2023 04:54:18 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8076BE76 for ; Tue, 18 Jul 2023 01:54:16 -0700 (PDT) Received: from dggpemm500009.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4R4t5k6shWzrRhY; Tue, 18 Jul 2023 16:53:30 +0800 (CST) Received: from huawei.com (10.175.127.227) by dggpemm500009.china.huawei.com (7.185.36.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 18 Jul 2023 16:54:13 +0800 From: ZhaoLong Wang To: , , CC: , , , , Subject: [PATCH V2 4/5] ubi: Reserve sufficient buffer length for the input mask Date: Tue, 18 Jul 2023 16:51:18 +0800 Message-ID: <20230718085119.3885747-5-wangzhaolong1@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20230718085119.3885747-1-wangzhaolong1@huawei.com> References: <20230718085119.3885747-1-wangzhaolong1@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500009.china.huawei.com (7.185.36.225) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because the mask received by the emulate_failures interface is a 32-bit unsigned integer, ensure that there is sufficient buffer length to receive and display this value. Signed-off-by: ZhaoLong Wang --- V2: - A 16-byte buffer is reserved, as implemented by other interfaces. drivers/mtd/ubi/debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c index 016a861c5029..1c3f1a2436e5 100644 --- a/drivers/mtd/ubi/debug.c +++ b/drivers/mtd/ubi/debug.c @@ -332,7 +332,7 @@ static ssize_t dfs_file_read(struct file *file, char __user *user_buf, struct dentry *dent = file->f_path.dentry; struct ubi_device *ubi; struct ubi_debug_info *d; - char buf[8]; + char buf[16]; int val; ubi = ubi_get_device(ubi_num); @@ -400,7 +400,7 @@ static ssize_t dfs_file_write(struct file *file, const char __user *user_buf, struct ubi_device *ubi; struct ubi_debug_info *d; size_t buf_size; - char buf[8] = {0}; + char buf[16] = {0}; int val; ubi = ubi_get_device(ubi_num); -- 2.31.1