Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5a6a3d3-f91d-2aae-6961-550f284d0691@traphandler.com>
Date:   Tue, 18 Jul 2023 11:04:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH v10 3/5] leds: class: store the color index in struct
 led_classdev
To:     Lee Jones <lee@kernel.org>
CC:     <linux-leds@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20230624084217.3079205-1-jjhiblot@traphandler.com>
 <20230624084217.3079205-4-jjhiblot@traphandler.com>
 <20230713095328.GH10768@google.com>
Content-Language: en-US
From:   Jean-Jacques Hiblot <jjhiblot@traphandler.com>
In-Reply-To: <20230713095328.GH10768@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 13/07/2023 11:53, Lee Jones wrote:
> On Sat, 24 Jun 2023, Jean-Jacques Hiblot wrote:
>>   
>> +static ssize_t color_show(struct device *dev,
>> +		struct device_attribute *attr, char *buf)
>> +{
>> +	const char *color_text = "invalid";
>> +	struct led_classdev *led_cdev = dev_get_drvdata(dev);
> 
> Can this be NULL?
Thanks for your feedback.

No it can't be NULL.

> 
>> +	if (led_cdev->color < LED_COLOR_ID_MAX)
>> +		color_text = led_colors[led_cdev->color];
> 
> '\n'