Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6582782rwp; Tue, 18 Jul 2023 02:44:30 -0700 (PDT) X-Google-Smtp-Source: APBJJlFvxjjZpjv186tjDXE/ixsm7qS3PJ8Sdr/zyWMkM376vDR4tduep2lxUwH3fikuZm9YGr10 X-Received: by 2002:a17:90a:4109:b0:262:cb1c:a782 with SMTP id u9-20020a17090a410900b00262cb1ca782mr12175266pjf.37.1689673470575; Tue, 18 Jul 2023 02:44:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689673470; cv=none; d=google.com; s=arc-20160816; b=zLr3ZXN4qLipb6cdhNRfZ3qmFEKaI1YECrNqxTFlg2Vco/qrHBD31u0ohR7Sudk1pt xGcfema72BqCOVfkUPcBohiEbnFyL57AORhWVP8JvsQSTgr8ja8m1mnE93qv9O4amFPq NHqUiHRjnjs9pFWGu4IybQFoG/X1Z9WuYkpTCWaeqVe8QXV18+PnH8/xIQ6QvfSZRjFg PeI1ZeRLu+Y1T/e1paJp6iPcySQ9Blgz0pP9QLw6JdjAObWpzhb8aAMe6/gtPjaoQMHo lLPQ3+xmm/hx8Kr/Tgha21KIrJQRMxuZkNmvrZZRa0Si7XptMpwpWb1wgcQ3mv7gbGFJ GlWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6U0ivmK+OD2iLsWKjuPfkp86w61vJmhvBzlDEBqiXqo=; fh=ysPuqYb0osWd0J8KA4c0nbPBPgCRPrPcJz2ieJW1Wcs=; b=Hr0AV/Is6YgDydtB3GUmRwUjhwx3J4b2Z+CJskSIMuYxzdmMAKKUqMt1ChJ5PIkRaa 8iiQlPByCa3iSYON0j+EwI3MWNCsszjgsgZiXmPNPL/QSgq+/U7PoTw3Z72mTfH9Fs7W Lx+EAxbw6fdE2/BFRNzSjRGyO7L//jY3YQTGbyYIdVbNaSQ7gn7hDr/00t2JnOIGjOd7 lIAQFuPBNFSJL0FHAKauGK6ZtP44UCTCrx96ryw2WEqXuJK7toDf3LG+3A2cbP638cZK e9OscrJW0E77c4griYVGaFksUiTIMzS36x5kHBALi6lbhicykB+xdjmo302IrxUV/0DZ Jqrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTjdRvnC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j23-20020a635517000000b0055bc2561b6esi1313256pgb.673.2023.07.18.02.44.17; Tue, 18 Jul 2023 02:44:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iTjdRvnC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjGRJFu (ORCPT + 99 others); Tue, 18 Jul 2023 05:05:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230126AbjGRJFs (ORCPT ); Tue, 18 Jul 2023 05:05:48 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8408EFA for ; Tue, 18 Jul 2023 02:05:43 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3143b72c5ffso5418586f8f.3 for ; Tue, 18 Jul 2023 02:05:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689671142; x=1692263142; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6U0ivmK+OD2iLsWKjuPfkp86w61vJmhvBzlDEBqiXqo=; b=iTjdRvnCW3zSo3ABfPXoSk5JhJ+uAhzYg6YmwS3CBF7Zeo+hLD83sn5TY0Rt9WagAR +c7Jse96ejEz3Nt+LUcOtkqKm6JgzpaEd0qn05xbkqzUyGxbnMK4PBkBwvc5F5Ekqe+O NMTTjwobVLkE1A/oSdECk45WJeGVRLtqIpUZdgU+i5f6zPmdgz1psCqnjNxo41MU9vrf 3f0I4YG6QnZXSzoz6sa69mb7TfT/uS5ULky4GGhplBwALPU2n1ozYfoKKNR+aCOxbLLt 7O9iN2HVm4obbcVWF/FPq64MuNciur40C75FXTND1NapySXq5NgdHh/roebMZB6QpLsU bSkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689671142; x=1692263142; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6U0ivmK+OD2iLsWKjuPfkp86w61vJmhvBzlDEBqiXqo=; b=LpDrO820RAWSPKhJBadaUu9I321ufyWWFu1Av3wRP6p+736FwlcNqS1CTbrLZ75+ce +KBNKSh7XfoywHzN1naBtX7VVJu2qoBYtAl3b7HlI752Sb35MTtlN2aO+38Vb0AInPQD E8j6y77nZ9ZedswwWg8PDjrXQAekJX8Ehiwz6YgUqzcL8yB6u+qTdwCjBMmhDJl2vTKc fZHzq3PdUOUFePs0H+pc457zUrdPP9iTygXACKzpDrD9efSZ/DAX/NuZkiAeapcya1k4 aiR0MJ1woj3fvB2WLpoDvS4HBUof95dFtGzLXQJ4jeLlOV2hZYtHy/Chqs9DXYgkOXag dfQA== X-Gm-Message-State: ABy/qLZk5rk5n74Sg0yJcCu5x1zJBbL9mT90Fupf3+s3kEWnF++XDjd2 TvO6Su+z6XfU9gAuVzpjc6Cy2l98TrGeZJTG6ig= X-Received: by 2002:adf:df84:0:b0:315:9993:1caa with SMTP id z4-20020adfdf84000000b0031599931caamr16112948wrl.12.1689671142048; Tue, 18 Jul 2023 02:05:42 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id i2-20020adffc02000000b0030c4d8930b1sm1768918wrr.91.2023.07.18.02.05.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 02:05:39 -0700 (PDT) Date: Tue, 18 Jul 2023 12:05:36 +0300 From: Dan Carpenter To: Sukrut Bellary Cc: Sudeep Holla , Cristian Marussi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling Message-ID: References: <20230718085529.258899-1-sukrut.bellary@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718085529.258899-1-sukrut.bellary@linux.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote: > Handle signed error return values returned by simple_write_to_buffer(). > In case of an error, return the error code. > > Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support") > Reported-by: Dan Carpenter > Signed-off-by: Sukrut Bellary > --- Thanks! Reviewed-by: Dan Carpenter regards, dan carpenter