Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.117.160 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C
Date:   Tue, 18 Jul 2023 12:52:42 +0300
From:   Leon Romanovsky <leonro@nvidia.com>
To:     Ilia Lin <quic_ilial@quicinc.com>
CC:     <steffen.klassert@secunet.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, Ilia Lin <ilia.lin@kernel.org>
Subject: Re: [PATCH] xfrm: Allow ESP over UDP in packet offload mode
Message-ID: <20230718095242.GC8808@unreal>
References: <20230718092405.4124345-1-quic_ilial@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230718092405.4124345-1-quic_ilial@quicinc.com>
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 09:52:54.9984
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 96ba5525-55f1-41e3-16a8-08db8774c27b
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT091.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6728
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 18, 2023 at 12:24:05PM +0300, Ilia Lin wrote:
> The ESP encapsulation is not supported only in crypto mode.
> In packet offload mode, the RX is bypassing the XFRM,
> so we can enable the encapsulation.

It is not accurate. RX is bypassed after XFRM validated packet to ensure
that it was really handled by HW.

However, this patch should come with relevant driver code which should
support ESP over UDP. You can see it here:

https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next
 xfrm: Support UDP encapsulation in packet offload mode
 net/mlx5e: Support IPsec NAT-T functionality
 net/mlx5e: Check for IPsec NAT-T support
 net/mlx5: Add relevant capabilities bits to support NAT-T

Thanks

> 
> Signed-off-by: Ilia Lin <ilia.lin@kernel.org>
> ---
>  net/xfrm/xfrm_device.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/net/xfrm/xfrm_device.c b/net/xfrm/xfrm_device.c
> index 4aff76c6f12e0..3018468d97662 100644
> --- a/net/xfrm/xfrm_device.c
> +++ b/net/xfrm/xfrm_device.c
> @@ -246,8 +246,10 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
>  		return -EINVAL;
>  	}
>  
> -	/* We don't yet support UDP encapsulation and TFC padding. */
> -	if (x->encap || x->tfcpad) {
> +	is_packet_offload = xuo->flags & XFRM_OFFLOAD_PACKET;
> +
> +	/* We don't yet support UDP encapsulation except full mode and TFC padding. */
> +	if ((!is_packet_offload && x->encap) || x->tfcpad) {
>  		NL_SET_ERR_MSG(extack, "Encapsulation and TFC padding can't be offloaded");
>  		return -EINVAL;
>  	}
> @@ -258,7 +260,6 @@ int xfrm_dev_state_add(struct net *net, struct xfrm_state *x,
>  		return -EINVAL;
>  	}
>  
> -	is_packet_offload = xuo->flags & XFRM_OFFLOAD_PACKET;
>  	dev = dev_get_by_index(net, xuo->ifindex);
>  	if (!dev) {
>  		if (!(xuo->flags & XFRM_OFFLOAD_INBOUND)) {
> -- 
> 
>