Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e420f2c9-4c29-e2c4-4312-291b05c97224@quicinc.com>
Date:   Tue, 18 Jul 2023 17:52:15 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.2
Subject: Re: [PATCH v1] led: flash: various minor fixes for leds-qcom-flash
 driver
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <lee@kernel.org>, <pavel@ucw.cz>,
        ChiaEn Wu <chiaen_wu@richtek.com>,
        "Alice Chen" <alice_chen@richtek.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        "Dylan Van Assche" <me@dylanvanassche.be>,
        Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
        Tom Rix <trix@redhat.com>, <linux-leds@vger.kernel.org>
CC:     <quic_collinsd@quicinc.com>, <quic_subbaram@quicinc.com>
References: <20230718092439.2482320-1-quic_fenglinw@quicinc.com>
 <d246292b-c0df-fa70-7561-9523e4db6138@linaro.org>
From:   Fenglin Wu <quic_fenglinw@quicinc.com>
In-Reply-To: <d246292b-c0df-fa70-7561-9523e4db6138@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 7/18/2023 5:32 PM, Krzysztof Kozlowski wrote:
> On 18/07/2023 11:24, Fenglin Wu wrote:
>> Update the driver to address following minor issues:
>>   - Add a sentence in Kconfig to explain the driver can be compiled
>>     as a module
>>   - strobe off the LED channel before setting flash current to prevent
>>     the flash LED being lit with an incorrect brightness if it was
>>     already active in torch mode
>>   - put the child node if register any flash LED device failed.
> 
> Don't mix different fixes and changes in one commit.
> 
> Also, please use scripts/get_maintainers.pl to get a list of necessary
> people and lists to CC (and consider --no-git-fallback argument). I
> really do not see a point why I am cc-ed here.
> 
> Best regards,
> Krzysztof

I understood that we should separate the changes for different fixes.

I am trying to address the review comment from Pavel that was coming 
late after the original changes were applied: 
https://lore.kernel.org/linux-arm-msm/20230325170957.GA2904@bug/ (sorry 
for just got time to work on this), since all of them are small ones and 
all related with the same driver, so I thought it might be good to put 
them together and update with a single patch?

BTW, you are copied because you also reviewed the original changes.
Thanks


>