Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Ming Qian <ming.qian@nxp.com>
To:     mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc:     shawnguo@kernel.org, robh+dt@kernel.org, s.hauer@pengutronix.de,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        xiahong.bao@nxp.com, eagle.zhou@nxp.com, tao.jiang_2@nxp.com,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/5] media: amphion: fix UNINIT issues reported by coverity
Date:   Tue, 18 Jul 2023 17:50:11 +0800
Message-Id: <ce7271cadd194feb56f3e4b2d7d3b41b704811fb.1689673395.git.ming.qian@nxp.com>
In-Reply-To: <cover.1689673395.git.ming.qian@nxp.com>
References: <cover.1689673395.git.ming.qian@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sqptiiUJcYkbqD/eRGYAJ49z+7EV14ts55lWT+YKirH/ee+DV22/eyYrrvHu?=
 =?us-ascii?Q?im80tMqthgFu+15euzifEsVGLrqVcuQiDTTlrn6sz0p95Q3Vg5RCzK0MySXE?=
 =?us-ascii?Q?X5do4H0oD44xbFBckgIvU41Y0KLHLlQ1L0KtDbG/axtJKJUKmY0V2oA8DcX8?=
 =?us-ascii?Q?7IbxW01SadXCcQPfIyrJoF3mipyXkmhlzeXXC/yfbFqbslDMTenZES2iVwX2?=
 =?us-ascii?Q?1wpIHXFD70O0NGnnTy5dLhZ/MSjOia6xq0gUPaVpiPTFI/PD6svdI941aREe?=
 =?us-ascii?Q?OULImQwEKQz/8YDiZpXfEdVTKV6sA7LSRfpZFPqTZzvN2/+NZJeuwqBgvs/x?=
 =?us-ascii?Q?YG6cls8otRqcedhc7nEChezzCsKFjgynFuuf359dd5rZ0FGlEvHxcw1/UXUB?=
 =?us-ascii?Q?67zc3/sGTGQfOGvJeAcqFqbe/dZHrTRXz15qhhQAKRg56/2qjXyerj1GsyO2?=
 =?us-ascii?Q?PA4ESIbn47DxQxr0eZuW1JxZS3pPz/654xxmLFOCDBahI9KzozSfU0M86C3v?=
 =?us-ascii?Q?j6z5i7/LPTiL22WKrieNFdeeNLwR9tmoqhCUCBfnZ6aN7a6/SPX7xiF5lPfj?=
 =?us-ascii?Q?+MKe8dtllaa53svtETxVtfDyoBExWH4gNlpcJNevgAa64UfjCqxXYc5l8bPb?=
 =?us-ascii?Q?ZH8BuYsyyefq0l2Us+0NawMb5bdOQJpixBnnlmhdF262X/BiZSGakNZvNYn8?=
 =?us-ascii?Q?/zqAozHvI0POF36xTxakaw+5L+CRxwYxZnY1dz8UsGEMYt04g48nOQ9IlMsL?=
 =?us-ascii?Q?cf91VGzd0J02KRJDE6jZwZ8iCFf8+MB1mm8N8MAGtxKWzbypdMNTEQC165jU?=
 =?us-ascii?Q?7UW6L8FObkltsq1YCb/xDmr9Ji12Jq40VIGzVe5WH6KNeRGvT0ypJyEfOGnc?=
 =?us-ascii?Q?eLu/fO3ce0bnAFvlClA76AmmAdNzhh9g1wPX38xm7BKz7Z2jjOwAmBZYrHKg?=
 =?us-ascii?Q?3TsYuJj1NQbGSsrlOhKEVpFMHRncT3W+eMNUw2y8elW5KYhQKyFt7wEjUXIi?=
 =?us-ascii?Q?y0qHhGV/O3dcDS+zCLfZkUwWwsw1QU9fSRZdwkhtx7Vngt00VOBPyURS4Kqx?=
 =?us-ascii?Q?HO1wUIOUWng2c10ee7lgYTvAREIu20F48AJsaKxF7UmO6bTnaOZpZ7RFYN8V?=
 =?us-ascii?Q?dRYb2AHCGZBxUeV5sRYVBFm2cuge8jzpW/Ff2yvcs9Ya+8gV1qIkcv7qbdaq?=
 =?us-ascii?Q?yGjpK7Q2p72X/fx7F/wmU0kShoqwiF9RFHMwWHy6H4QgMegm8giL7VFY/5tX?=
 =?us-ascii?Q?PaC65FF52JvSe/o9RDbhzoou6uRNZj0Y+0wjRppmT/peOiYZTUNkhHqFr5ay?=
 =?us-ascii?Q?nbt3iC/Y15e2daIRpm1Uf3XtkSjESGmNPNxeRlLfcUA4NdooWeWmDeB8Ircj?=
 =?us-ascii?Q?KKtB0RQimSCDkfWlRy6d1L/hGXrrKcgOH4jQp5S8qx1A91FCFPrEnbuecaQI?=
 =?us-ascii?Q?9cdts/20gNQVBJXB4cFYdsEgPg9i95AAq9zlySz6VKKu/YFLNV9MpBmQUe5Z?=
 =?us-ascii?Q?hYtxBZvidZ8bkUJXgtDzqthl0pj8Vnw8NeRzdrfwpWp27qbebO1ybJ2/86eb?=
 =?us-ascii?Q?IHzeHXcDQxzs8KBfksOJiktbpwRg/qloVKzaR4Y4?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f7116e4-3e69-4877-46cb-08db87747ad0
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6341.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2023 09:50:55.1908
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UtG3ux/ERUrBDiez0CHuT8i1BSQI4L5TGCi9MLnuSdYle+SYoc6v5YOGCHNqhX3ci09tZviptaOtO8h1V0yJcw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7067
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

using uninitialized value may introduce risk

Fixes: 9f599f351e86 ("media: amphion: add vpu core driver")
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
 drivers/media/platform/amphion/vpu_msgs.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/platform/amphion/vpu_msgs.c b/drivers/media/platform/amphion/vpu_msgs.c
index f9eb488d1b5e..d0ead051f7d1 100644
--- a/drivers/media/platform/amphion/vpu_msgs.c
+++ b/drivers/media/platform/amphion/vpu_msgs.c
@@ -32,7 +32,7 @@ static void vpu_session_handle_start_done(struct vpu_inst *inst, struct vpu_rpc_
 
 static void vpu_session_handle_mem_request(struct vpu_inst *inst, struct vpu_rpc_event *pkt)
 {
-	struct vpu_pkt_mem_req_data req_data;
+	struct vpu_pkt_mem_req_data req_data = { 0 };
 
 	vpu_iface_unpack_msg_data(inst->core, pkt, (void *)&req_data);
 	vpu_trace(inst->dev, "[%d] %d:%d %d:%d %d:%d\n",
@@ -80,7 +80,7 @@ static void vpu_session_handle_resolution_change(struct vpu_inst *inst, struct v
 
 static void vpu_session_handle_enc_frame_done(struct vpu_inst *inst, struct vpu_rpc_event *pkt)
 {
-	struct vpu_enc_pic_info info;
+	struct vpu_enc_pic_info info = { 0 };
 
 	vpu_iface_unpack_msg_data(inst->core, pkt, (void *)&info);
 	dev_dbg(inst->dev, "[%d] frame id = %d, wptr = 0x%x, size = %d\n",
@@ -90,7 +90,7 @@ static void vpu_session_handle_enc_frame_done(struct vpu_inst *inst, struct vpu_
 
 static void vpu_session_handle_frame_request(struct vpu_inst *inst, struct vpu_rpc_event *pkt)
 {
-	struct vpu_fs_info fs;
+	struct vpu_fs_info fs = { 0 };
 
 	vpu_iface_unpack_msg_data(inst->core, pkt, &fs);
 	call_void_vop(inst, event_notify, VPU_MSG_ID_FRAME_REQ, &fs);
@@ -107,7 +107,7 @@ static void vpu_session_handle_frame_release(struct vpu_inst *inst, struct vpu_r
 		info.type = inst->out_format.type;
 		call_void_vop(inst, buf_done, &info);
 	} else if (inst->core->type == VPU_CORE_TYPE_DEC) {
-		struct vpu_fs_info fs;
+		struct vpu_fs_info fs = { 0 };
 
 		vpu_iface_unpack_msg_data(inst->core, pkt, &fs);
 		call_void_vop(inst, event_notify, VPU_MSG_ID_FRAME_RELEASE, &fs);
@@ -122,7 +122,7 @@ static void vpu_session_handle_input_done(struct vpu_inst *inst, struct vpu_rpc_
 
 static void vpu_session_handle_pic_decoded(struct vpu_inst *inst, struct vpu_rpc_event *pkt)
 {
-	struct vpu_dec_pic_info info;
+	struct vpu_dec_pic_info info = { 0 };
 
 	vpu_iface_unpack_msg_data(inst->core, pkt, (void *)&info);
 	call_void_vop(inst, get_one_frame, &info);
@@ -130,7 +130,7 @@ static void vpu_session_handle_pic_decoded(struct vpu_inst *inst, struct vpu_rpc
 
 static void vpu_session_handle_pic_done(struct vpu_inst *inst, struct vpu_rpc_event *pkt)
 {
-	struct vpu_dec_pic_info info;
+	struct vpu_dec_pic_info info = { 0 };
 	struct vpu_frame_info frame;
 
 	memset(&frame, 0, sizeof(frame));
-- 
2.38.1