Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6607263rwp; Tue, 18 Jul 2023 03:11:34 -0700 (PDT) X-Google-Smtp-Source: APBJJlGKXMHLY3lNcHNg8hY21kDfJ0DxqZC/dLSsfStCFBnOeFyik85B2By3cVPGRUxygGwKYqTE X-Received: by 2002:a17:906:7786:b0:993:d8be:53f5 with SMTP id s6-20020a170906778600b00993d8be53f5mr1637547ejm.14.1689675093923; Tue, 18 Jul 2023 03:11:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689675093; cv=none; d=google.com; s=arc-20160816; b=XJLdMsvHHIF4uJJ8NnvTybwresqq3nF3uDGp1VuYCFHNOclalpB6iW3X6tUaK04Iqj UdYBUgWnpL9LGx2oSy0h6k2bc0KuwMJ4yXem8vWdLGgwoORoD14072FpBYoT0eLDxOfI Wa/oTv/RQsqeI7UPS38uk1QeWIc5zq/eDloIJqJcsbSd0PrRb8tm2KFIzcTg6JVMdTdK YO+HVngtaOOSN+bmwe8kNM+xLIbIgBJZHvmuHzZK3omTYCqJ60jasGFXZgYcLjvSrJQT cHuLlrUMtl3DxXE54/YM0uVP29SZwViz0zTPf98ALLmvFmUR2bfnFN2CAjm3GJmJdgBS rnmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=9LdsEbzsY4c1J1JHWuVtjptWKb91L+dqZVAqdTsMizo=; fh=8w8wf6I1yBWaHrvUotEpZxiR78yuwPA1p+GHJBxdyyA=; b=MLaWucg1ezjvZtXMDTUfvaQK2+fhGi/mC88sZYKGiZYsblOw53ODQt0+t9hZESkpkF EFj/2KVct+Fo4p6hk/08jpl43oUXZk10flNxHTIXzrKLS/48Bx+IVcDUM52JmPk2Pa2f NLztZNssbQalwED52SNvq0A1bxFSAIx+G9hHNlThUGgkpyqHl4JOD3qVmEpK3n2Qn7D2 p8fsGSKIok165DpfkDJ2MKOkQt00DZi+K+pR8IIZP9OhIT+2p3ZThmh7UzU2HCvQqXWe 8+5/cI6tm1RiXQomQ2QsjQBkhVJ0mJCuT0x8Jj013Yx1tLSOOSb8DhWqVr1P3VNQ+syo 6Vvw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a170906680700b009823926ec36si991565ejr.931.2023.07.18.03.11.08; Tue, 18 Jul 2023 03:11:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230187AbjGRJqf (ORCPT + 99 others); Tue, 18 Jul 2023 05:46:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbjGRJqe (ORCPT ); Tue, 18 Jul 2023 05:46:34 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5AACA9E for ; Tue, 18 Jul 2023 02:46:32 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 767D82F4; Tue, 18 Jul 2023 02:47:15 -0700 (PDT) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 053623F67D; Tue, 18 Jul 2023 02:46:30 -0700 (PDT) Date: Tue, 18 Jul 2023 10:46:28 +0100 From: Cristian Marussi To: Sukrut Bellary Cc: Sudeep Holla , Dan Carpenter , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] firmware: arm_scmi: Fix signed error return values handling Message-ID: References: <20230718085529.258899-1-sukrut.bellary@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230718085529.258899-1-sukrut.bellary@linux.com> X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 18, 2023 at 01:55:29AM -0700, Sukrut Bellary wrote: > Handle signed error return values returned by simple_write_to_buffer(). > In case of an error, return the error code. > > Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support") > Reported-by: Dan Carpenter > Signed-off-by: Sukrut Bellary > --- > This is based on static analysis. Compilation tested. > --- Hi Sukrut, thanks for this. Reviewed-by: Cristian Marussi Tested-by: Cristian Marussi Thanks, Cristian