Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d954ee43-d0cc-ef2b-8467-57883e9defd7@quicinc.com>
Date:   Tue, 18 Jul 2023 16:07:45 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v7 0/2] spi-geni-qcom: Add SPI device mode support for
 GENI based QuPv3
Content-Language: en-CA
To:     Praveen Talari <quic_ptalari@quicinc.com>, <agross@kernel.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <broonie@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC:     <quic_msavaliy@quicinc.com>, <quic_vtanuku@quicinc.com>,
        <quic_arandive@quicinc.com>
References: <20230714042203.14251-1-quic_ptalari@quicinc.com>
From:   Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
In-Reply-To: <20230714042203.14251-1-quic_ptalari@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

LGTM...


On 7/14/2023 9:52 AM, Praveen Talari wrote:
> This series adds spi device mode functionality to geni based Qupv3.
> The common header file contains spi slave related registers and masks.
>
> Praveen Talari (2):
>    soc: qcom: geni-se: Add SPI Device mode support for GENI based QuPv3
>    spi: spi-geni-qcom: Add SPI Device mode support for GENI based QuPv3
> ---
> v6 -> v7:
> - Corrected author mail
>
> v5 -> v6:
> - Added code comments
> - Dropped get_spi_master api
>
> v4 -> v5:
> - Addressed review comments in driver
>
> v3 -> v4:
> - Used existing property spi-slave
> - Hence dropped dt-binding changes
>
> v2 -> v3:
> - Modified commit message
> - Addressed comment on dt-binding
>
> v1 -> v2:
> - Added dt-binding change for spi slave
> - Modified commit message
> - Addressed review comments in driver
>
>   drivers/spi/spi-geni-qcom.c      | 53 ++++++++++++++++++++++++++++----
>   include/linux/soc/qcom/geni-se.h |  9 ++++++
>   2 files changed, 56 insertions(+), 6 deletions(-)


Reviewed-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>