Received: by 2002:a05:6358:7058:b0:131:369:b2a3 with SMTP id 24csp6665739rwp; Tue, 18 Jul 2023 04:12:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFbaoVjtxxlZocijPJQ0FD6/+UFvImDnk7Vw581UbiNCtngjRsU9LO2xYJ66kQlFbDi7UU+ X-Received: by 2002:a05:6402:3cb:b0:51e:fb9:7f20 with SMTP id t11-20020a05640203cb00b0051e0fb97f20mr12923642edw.41.1689678735846; Tue, 18 Jul 2023 04:12:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689678735; cv=none; d=google.com; s=arc-20160816; b=G/IUScToMO1VlfvKaHZQHTaASN4UMWmCP4/ZG29AYR0S6rgOlrWlJSTgBWs+zL9hMn CDdWHi8G+grorimo91c55xRE80YBtlLCl/DbcLfXbgtpOiUxgVQ0djygxO9rsRMVIM/b P7B+eRY3R4Jd7codlGoro96cGLEg9P43Nax1PUduXIDEe7wSNwKDw7AtY8c1bF/QhCke Khh23RGuHpHb7BxS13Y8mBFecJO/9i53SbEDd8lT5/qIdBRVtJTgbP+RCah4c/sAUlvg 3X+xQe0VXBCUkxyElJH6mlhtRVlIazzEDpYgw4bTmtTGLaQ+SbKNvua+boycsVPHc728 sXNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :organization:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:dkim-signature; bh=HS9F3B1FkkKetCW5lCpx853xObPpzhaVMc4xtNSq1uU=; fh=vuGGynpGlI7L9U8ZbG8QHGErapdIZJS+WWEWbJe3oRM=; b=mVWWwXIS/tI5hol/2D54pbzm61FpQsvKgj3QwtR8w6ogonZuFXd0OyWw+a26Z7FtXZ c9nWyNn5+iUvwwaUCcOv1XsceHgOcmvbz227/E8DtJsT8Cef0zGNVFArqgzHuErLYUGE HexfwC1UIJ6wSLgT3I9Frt4b86ZoeU2Wqw/b/ABcGG3WFavzVDAWsAwUGDJQOwlmfND4 1+xlPE67ZaZc/0WTPsKuF4ncvPFiHF9NYmZHC6Q96QCeKzk3u4q3ayDoqApPXtEOuIb+ jDGpJKu0Lzqs3At0JGvOfQ8t9z00xpWMDfA9UXjKYhvZVx2kdBAEfHtKuDQJeAd5FJWR GmJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rRayySnL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d26-20020aa7c1da000000b00521837216cesi1031641edp.604.2023.07.18.04.11.52; Tue, 18 Jul 2023 04:12:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rRayySnL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbjGRKqH (ORCPT + 99 others); Tue, 18 Jul 2023 06:46:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229811AbjGRKqG (ORCPT ); Tue, 18 Jul 2023 06:46:06 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C51F189; Tue, 18 Jul 2023 03:46:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CBD0D6150C; Tue, 18 Jul 2023 10:46:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D6C48C433C7; Tue, 18 Jul 2023 10:46:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689677164; bh=NP8hk+WVflZAzc8MTekAOt7HnsMBveyW+5Dxwu+GBX0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=rRayySnLiFad+UOmpBaN2mLBnxnQh1wllU8eTCNLufhk78DLxJBFIdesN6gKVzT8D 2QTNUxZ/mvaU9NW7feMxVB2RWb45upzDZp6ctvJVNjZjIyrnVXvW/l0i9VabOimkYY ngTF7morzLcEPF+E40V7aYYHxMFSa3G1O2RpoGRYepVY3xztihhQ5CBshdh1iq5dDq 0VVpcaNIkbhnEos87Ubki5fW3izjRCVeM9qfeLwy1IXLsujPLTonRC8+SXNy0IzmXa FkClfe8Q5SjrbAf4Zx5l+ls3zATGyOhNdjHu53+jzzwADUnXRV6zhnAGEhIBB4VR4b CKgTSyyzBCqSA== Message-ID: Date: Tue, 18 Jul 2023 19:46:02 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] ata: remove whitespace after '(' and before ')' Content-Language: en-US To: hanyu001@208suo.com Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org References: <07f7ac9c59d027f959a69836fee9940c@208suo.com> From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <07f7ac9c59d027f959a69836fee9940c@208suo.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/18/23 17:53, hanyu001@208suo.com wrote: > This patch fixes the following checkpatch errors: The subject should be: ata: pata_sis: xxx But in any case, the above message says that this is a warning from checkpatch. But what are you patching to get this ? If you run checkpatch directly on drivers/ata/pata_sis.c, you will get *a lot* more warnings than just this. And I would not want patches to fix that, unless the warnings are also generated with "make W=1" or "make C=1". If you actually fix a bug in this driver that touches code around the lines you touch, then it is fine to fix that to avoid the warnings, but not just for the sake of it. libata code overall has a lot of code style issues that will trigger checkpatch warnings. When code is changed, fixing the code style at the same time is fine. Exception to this is again if you see warnings with "make W=1" or "make C=1". I applied a lot of patches recently to fix the code style in the pata_parport protocol modules because they were generating compilation warnings. > > ./drivers/ata/pata_sis.c:691: ERROR: space prohibited after that open > parenthesis '(' > ./drivers/ata/pata_sis.c:691: ERROR: space prohibited before that close > parenthesis ')' > > Signed-off-by: Yu Han < hanyu001@208suo.com> > --- > drivers/ata/pata_sis.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ata/pata_sis.c b/drivers/ata/pata_sis.c > index 31de06b..2019777 100644 > --- a/drivers/ata/pata_sis.c > +++ b/drivers/ata/pata_sis.c > @@ -688,7 +688,7 @@ static void sis_fixup(struct pci_dev *pdev, struct > sis_chipset *sis) > > if (sis->info == &sis_info33) { > pci_read_config_byte(pdev, PCI_CLASS_PROG, ®); > - if (( reg & 0x0F ) != 0x00) > + if ((reg & 0x0F) != 0x00) > pci_write_config_byte(pdev, PCI_CLASS_PROG, reg & 0xF0); > /* Fall through to ATA16 fixup below */ > } -- Damien Le Moal Western Digital Research