Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <b974af38-af5d-5d09-0e18-791769c95522@linaro.org>
Date:   Tue, 18 Jul 2023 13:42:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.13.0
Subject: Re: [PATCH 2/3] dt-bindings: soc: mediatek: Add mtk-socinfo driver
Content-Language: en-US
To:     William-tw Lin <william-tw.lin@mediatek.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@collabora.com>,
        Kevin Hilman <khilman@kernel.org>
Cc:     Project_Global_Chrome_Upstream_Group@mediatek.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org
References: <20230718112143.14036-1-william-tw.lin@mediatek.com>
 <20230718112143.14036-3-william-tw.lin@mediatek.com>
From:   Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
In-Reply-To: <20230718112143.14036-3-william-tw.lin@mediatek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 18/07/2023 13:21, William-tw Lin wrote:
> dt-binding documentation for mtk-socinfo driver.
> mtk-socinfo driver provides SoC-related information.
> Such information includes manufacturer information, SoC name,
> SoC segment name, and SoC marketing name.
> 
> Signed-off-by: William-tw Lin <william-tw.lin@mediatek.com>
> ---
>  .../bindings/soc/mediatek/mtk-socinfo.yaml    | 58 +++++++++++++++++++

Put it in appropriate place - hwinfo.

>  1 file changed, 58 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml

Wrong filename: missing vendor prefix, not matching compatibles.

> 
> diff --git a/Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml b/Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml
> new file mode 100644
> index 000000000000..4420430a9bca
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/mediatek/mtk-socinfo.yaml
> @@ -0,0 +1,58 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/mediatek/mtk-socinfo.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek SOC information
> +
> +maintainers:
> +  - William Lin <william-tw.lin@mediatek.com>
> +  - Matthias Brugger <matthias.bgg@gmail.com>
> +  - Kevin Hilman <khilman@kernel.org>
> +
> +description:
> +  The MTK socinfo driver can retrieve several

Driver? As in Linux driver? Drop. Describe hardware instead.

> +  SoC related information based on settings in eFuse.
> +  Such information include manufacturer information, SoC name,
> +  SoC segment name, and SoC marketing name.
> +
> +

Just one blank line.

> +properties:
> +  compatible:
> +    enum:
> +      - mediatek,mt8173-socinfo
> +      - mediatek,mt8183-socinfo
> +      - mediatek,mt8186-socinfo
> +      - mediatek,mt8188-socinfo
> +      - mediatek,mt8192-socinfo
> +      - mediatek,mt8195-socinfo
> +
> +

Ditto...


> +  nvmem-cells:
> +    description:
> +      Phandle to the eFuse data for SoC differentiation.
> +    items:
> +      - description: eFuse data that mtk-socinfo driver uses for SoC differentiation
> +
> +  nvmem-cell-names:
> +    minItems: 1
> +    items:
> +      - const: socinfo-data1
> +      - const: socinfo-data2

This does not match your cells.

> +
> +required:
> +  - compatible
> +  - nvmem-cells
> +  - nvmem-cell-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +        mtk_socinfo: socinfo {

Broken indentation.

> +            compatible = "mediatek,mt8186-socinfo";
> +            nvmem-cells = <&socinfo_data1>;
> +            nvmem-cell-names = "socinfo-data1";

No other resources? So this is just DT description of driver? Does not
look like suitable for DT in the first place.


Best regards,
Krzysztof