Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 13:35:05 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Oliver Neukum <oneukum@suse.com>
Cc:     Haotien Hsu <haotienh@nvidia.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org,
        linux-kernel@vger.kernel.org, Wayne Chang <waynec@nvidia.com>,
        JC Kuo <jckuo@nvidia.com>, WK Tsai <wtsai@nvidia.com>,
        Henry Lin <henryl@nvidia.com>
Subject: Re: [PATCH v2] usb: xhci: tegra: Add shutdown callback for Tegra XUSB
Message-ID: <ZLZ46fPCdPt1Bpul@orome>
References: <20230718091425.307589-1-haotienh@nvidia.com>
 <525bc794-b797-9a53-7f59-debcfca9edd8@suse.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="KDREtPOnoIrM9MEt"
Content-Disposition: inline
In-Reply-To: <525bc794-b797-9a53-7f59-debcfca9edd8@suse.com>
User-Agent: Mutt/2.2.10 (2023-03-25)
Precedence: bulk


--KDREtPOnoIrM9MEt
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 18, 2023 at 11:18:25AM +0200, Oliver Neukum wrote:
>=20
>=20
> On 18.07.23 11:14, Haotien Hsu wrote:
> > From: Henry Lin <henryl@nvidia.com>
> >=20
> > If memory accesses by the Tegra XUSB controller are translated through
> > the SMMU (System MMU), the hardware may continue accessing memory even
> > after the SMMU translations have been disabled during the shutdown
> > process and this can in turn cause unpredictable crashes.
> > Fix this by adding a shutdown implementation that ensures the hardware
> > is turned off during system reboot or shutdown.
> >=20
> > Signed-off-by: Henry Lin <henryl@nvidia.com>
> > Signed-off-by: Haotien Hsu <haotienh@nvidia.com>
> > Acked-by: Thierry Reding <treding@nvidia.com>
> >=20
> > ---
> > V1 -> V2: Resend for the typo in the mailing list
> > ---
> >   drivers/usb/host/xhci-tegra.c | 28 +++++++++++++++++++++-------
> >   1 file changed, 21 insertions(+), 7 deletions(-)
> >=20
> > diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegr=
a.c
> > index a56cc81b9404..6ef2eac9835d 100644
> > --- a/drivers/usb/host/xhci-tegra.c
> > +++ b/drivers/usb/host/xhci-tegra.c
> > @@ -1925,6 +1925,15 @@ static int tegra_xusb_probe(struct platform_devi=
ce *pdev)
> >   	return err;
> >   }
> > +static void tegra_xusb_disable(struct tegra_xusb *tegra)
> > +{
> > +	tegra_xusb_powergate_partitions(tegra);
> > +	tegra_xusb_powerdomain_remove(tegra->dev, tegra);
> > +	tegra_xusb_phy_disable(tegra);
> > +	tegra_xusb_clk_disable(tegra);
> > +	regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> > +}
> > +
> >   static int tegra_xusb_remove(struct platform_device *pdev)
> >   {
> >   	struct tegra_xusb *tegra =3D platform_get_drvdata(pdev);
> > @@ -1947,18 +1956,22 @@ static int tegra_xusb_remove(struct platform_de=
vice *pdev)
> >   	pm_runtime_put(&pdev->dev);
> > -	tegra_xusb_powergate_partitions(tegra);
> > -
> > -	tegra_xusb_powerdomain_remove(&pdev->dev, tegra);
> > -
> > -	tegra_xusb_phy_disable(tegra);
> > -	tegra_xusb_clk_disable(tegra);
> > -	regulator_bulk_disable(tegra->soc->num_supplies, tegra->supplies);
> > +	tegra_xusb_disable(tegra);
> >   	tegra_xusb_padctl_put(tegra->padctl);
> >   	return 0;
> >   }
> > +static void tegra_xusb_shutdown(struct platform_device *pdev)
> > +{
> > +	struct tegra_xusb *tegra =3D platform_get_drvdata(pdev);
> > +
> > +	pm_runtime_get_sync(&pdev->dev);
>=20
> Where is this balanced?

Well, I suppose we could add a pm_runtime_put() at the end of this
function, but since we expect the system to shut down after this, at
which point any runtime PM accounting is going to go bye-bye anyway,
do we really want to bother?

Thierry

--KDREtPOnoIrM9MEt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS2eOYACgkQ3SOs138+
s6G2DhAAqDAGSWBzjm2Ul3XGEIDkj9UxFJ5HEhBxD3+oeW1RvnFMMjj54xRV+GwE
J0+4KDAaQVKEp8k29X6hDHR4jDqoMsAWpZj5FGIC2IQBiZUflILX0zajOlTI3l3e
IjS2GUQyQ0/XqJ7fN/tsIK3tY+Phpz+GvttXAqb8srhaY8gA+/n1+/fePx/vYCyw
Ne3Ajz0WLKzOfdUv16uZdlNKVGD6kyUZsgnFjCZpFGxteAUcyEjoJayYMsoJF0ch
SiAI5XWeDM6pxDxJnOX+hk2QF3Wpgv0anxm/3IAu3P923t5+QuIbSEvmOvWiJeXe
ACSpQD/RY5ID5llsr3PxGcTZsOqQ5YRUbq0bcEgfoH6s5WmsEkme1YpVt1YBC96m
Z8yO2IpOiSQOVkBm8s9bg1SYJBZ8hcSgOWX7kXU89TGzz9UrC5bQo7qK+EVDhpXo
HWdDdTdnSCoZSjsln1j3cPkQMAXgb9PSaE7yZUqOj8KTvwRcELp3IrIOhfZ15H+0
3nsPb97Rp3olURkqZIQv0Ex+1OLKMZXmHd2genONATMqHq6Jb4na1svHq/pUx1EK
K4B2MS2ZF8l2QMog0FbWIB3WWyfTurUQ06/usGnG2P9eWfKDOLagApFyHLwDmYul
sDKZqgru6gD+WYgilAoBUgLbhwD8lm9ELvUQ0ncQUuqvwHhJ/Ss=
=nUaM
-----END PGP SIGNATURE-----

--KDREtPOnoIrM9MEt--