Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 18 Jul 2023 14:27:31 +0200
From:   Michal =?iso-8859-1?Q?Such=E1nek?= <msuchanek@suse.de>
To:     Jan Engelhardt <jengelh@inai.de>
Cc:     linux-modules@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
        Lucas De Marchi <lucas.de.marchi@gmail.com>,
        Michal =?iso-8859-1?Q?Koutn=FD?= <mkoutny@suse.com>,
        Jiri Slaby <jslaby@suse.com>,
        Masahiro Yamada <masahiroy@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Nicolas Schier <nicolas@fjasle.eu>,
        linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH kmod v4 4/4] libkmod, depmod, modprobe: Make directory
 for kernel modules configurable
Message-ID: <20230718122731.GX9196@kitsune.suse.cz>
References: <20230711153126.28876-1-msuchanek@suse.de>
 <cover.1689589902.git.msuchanek@suse.de>
 <cc04472084dc016679598fcffafc788bbb6d9c0f.1689589902.git.msuchanek@suse.de>
 <76o21q7n-8qo8-37p6-oqno-q08nqpos471@vanv.qr>
 <20230718084300.GU9196@kitsune.suse.cz>
 <81n281ns-s8on-rsrn-pp61-q28pn42ns531@vanv.qr>
 <20230718102958.GW9196@kitsune.suse.cz>
 <pq42o77-73np-66r-rrn9-ns24o907n59@vanv.qr>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <pq42o77-73np-66r-rrn9-ns24o907n59@vanv.qr>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Jul 18, 2023 at 02:17:08PM +0200, Jan Engelhardt wrote:
> 
> On Tuesday 2023-07-18 12:29, Michal Such?nek wrote:
> >> -static const char *dirname_default_prefix = MODULE_DIRECTORY;
> >> +const char *dirname_default_prefix = MODULE_DIRECTORY;
> >>  
> >> @@ -2943,6 +2944,9 @@ static int do_depmod(int argc, char *argv[])
> >>  				free(out_root);
> >>  			out_root = path_make_absolute_cwd(optarg);
> >>  			break;
> >> +		case 'M':
> >> +			dirname_default_prefix = optarg;
> >> +			break;
> >>  		case 'C': {
> >>  			size_t bytes = sizeof(char *) * (n_config_paths + 2);
> >>  			void *tmp = realloc(config_paths, bytes);
> >
> >That breaks kmod for the usrmerged distributions, though.
> 
> Does it though?
> The *distro* has /lib -> /usr/lib,
> the *staging area* for installation does not.

Yes, currently the fully installed distribution has the symlink, at
least openSUSE does.

However, there is a goal to remove it eventually, and even now it is not
present at all times.

Thanks

Michal